From eb522eece2f04cefd75931be5066eaebf2b34b51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20K=C3=BChne?= Date: Mon, 9 Dec 2002 06:27:40 +0000 Subject: [PATCH] fixed i18n issues --- .../com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java | 2 +- .../checkstyle/checks/SimplifyBooleanExpressionCheck.java | 3 +-- .../tools/checkstyle/checks/SimplifyBooleanReturnCheck.java | 5 +---- .../puppycrawl/tools/checkstyle/checks/messages.properties | 6 +++++- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java index 2fb116c2f..5b606062c 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/HeaderCheck.java @@ -60,7 +60,7 @@ public class HeaderCheck public void beginTree() { if (mHeaderLines == null) { - log(1, "Unable to check as missing lines to check."); + log(1, "header.spec.missing"); return; } diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheck.java index e4e249d6f..9cca898ac 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanExpressionCheck.java @@ -72,8 +72,7 @@ public class SimplifyBooleanExpressionCheck case TokenTypes.LOR: case TokenTypes.LAND: log(parent.getLineNo(), parent.getColumnNo(), - // TODO: i18n - "Expression can be simplified."); + "simplify.expression"); break; default: break; diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanReturnCheck.java b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanReturnCheck.java index 9eabedff4..b8770e40b 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanReturnCheck.java +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/SimplifyBooleanReturnCheck.java @@ -67,10 +67,7 @@ public class SimplifyBooleanReturnCheck if (returnsOnlyBooleanLiteral(thenStatement) && returnsOnlyBooleanLiteral(elseStatement)) { - // TODO: i18n - log(aAST.getLineNo(), - aAST.getColumnNo(), - "Remove conditional logic."); + log(aAST.getLineNo(), aAST.getColumnNo(), "simplify.boolreturn"); } } diff --git a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/messages.properties b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/messages.properties index 5dc608604..94f879d29 100644 --- a/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/messages.properties +++ b/src/checkstyle/com/puppycrawl/tools/checkstyle/checks/messages.properties @@ -46,6 +46,7 @@ instantiation.avoid=Avoid instantiation of {0}. upperEll=Should use uppercase ''L''. +header.spec.missing=Unable to check as missing lines to check. header.missing=Missing a header - not enough lines in file. header.mismatch=Line does not match expected header line of ''{0}''. @@ -66,4 +67,7 @@ equals.noHashCode=Definition of ''equals()'' without corresponding defnition of hidden.field=''{0}'' hides a field. -translation.missingKey=Key ''{0}'' missing. \ No newline at end of file +translation.missingKey=Key ''{0}'' missing. + +simplify.expression=Expression can be simplified. +simplify.boolreturn=Remove conditional logic. \ No newline at end of file