From ee7d6e9df391945a64c23210cd0fdc1a58fb7d95 Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Thu, 3 Sep 2015 22:08:07 +0200 Subject: [PATCH] Issue #1555: Add locale to lower case conversion Fixes `StringToUpperWithoutLocale` inspection violations introduced in recent commits. Description: >Reports any call of toUpperCase() or toLowerCase() on String objects which do not specify a java.util.Locale. Such calls are usually incorrect in an internationalized environment. --- .../tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java index 3b283e3f6..335d581ea 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java @@ -20,6 +20,7 @@ package com.puppycrawl.tools.checkstyle.checks; import static com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck.MSG_KEY_NO_NEWLINE_EOF; +import static java.util.Locale.ENGLISH; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertTrue; import static org.powermock.api.mockito.PowerMockito.mock; @@ -188,7 +189,7 @@ public class NewlineAtEndOfFileCheckTest } catch (InvocationTargetException ex) { assertTrue(ex.getCause() instanceof IOException); - if (System.getProperty("os.name").toLowerCase().startsWith("windows")) { + if (System.getProperty("os.name").toLowerCase(ENGLISH).startsWith("windows")) { assertEquals(ex.getCause().getMessage(), "Unable to read 2 bytes, got 0"); } else {