From ef834b210cc5c7803ef930fcff96219b6b91922d Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Fri, 28 Aug 2015 17:27:02 +0200 Subject: [PATCH] Issue #1555: Narrow scope of variable Fixes `TooBroadScope` inspection violations introduced in recent commit. Description: >Reports any variable declarations of which the scope can be narrowed. Especially useful for "Pascal style" declarations at the start of a method, but variables with too broad a scope are also often left over after refactorings. --- .../tools/checkstyle/checks/javadoc/JavadocMethodCheck.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java index 2e6af4409..526d63656 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java @@ -748,9 +748,8 @@ public class JavadocMethodCheck extends AbstractTypeAwareCheck { tagIt.remove(); - boolean found; final String arg1 = tag.getFirstArg(); - found = removeMatchingParam(params, arg1); + boolean found = removeMatchingParam(params, arg1); if (CommonUtils.startsWithChar(arg1, '<') && CommonUtils.endsWithChar(arg1, '>')) { // Loop looking for matching type param