From f17f1410a5bb22fd62c75aae3d40fd22bb86129e Mon Sep 17 00:00:00 2001 From: Ilja Dubinin Date: Mon, 17 Aug 2015 01:14:34 +0100 Subject: [PATCH] Floating point numbers should not be tested for equality. Issue #46 --- .../checkstyle/checks/coding/ExplicitInitializationCheck.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java index 78315b596..5bff52ce2 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheck.java @@ -173,7 +173,8 @@ public class ExplicitInitializationCheck extends Check { case TokenTypes.NUM_INT: case TokenTypes.NUM_LONG: final String text = expr.getText(); - return CheckUtils.parseDouble(text, type) == 0.0; + return Double.compare( + CheckUtils.parseDouble(text, type), 0.0) == 0; default: return false; }