From f58f92adf6804395c66c41d408dc8e2155cb0c5d Mon Sep 17 00:00:00 2001 From: Michal Kordas Date: Fri, 28 Aug 2015 23:58:10 +0200 Subject: [PATCH] Issue #1555: Fix false-positive in mismatched array read write rule False-positive reported to JetBrains as [IDEA-144521](https://youtrack.jetbrains.com/issue/IDEA-144521). Fixes `MismatchedArrayReadWrite` inspection violations. Description: >Reports any array fields or variables whose contents are read but not written, or written but not read. Such mismatched reads and writes are pointless, and probably indicate dead, incomplete or erroneous code. --- .../tools/checkstyle/checks/javadoc/JavadocNodeImpl.java | 7 +------ .../puppycrawl/tools/checkstyle/utils/JavadocUtils.java | 4 ++++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java index 2dfcab77a..0c882f999 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImpl.java @@ -32,11 +32,6 @@ import com.puppycrawl.tools.checkstyle.utils.JavadocUtils; * */ public class JavadocNodeImpl implements DetailNode { - /** - * Empty array of {@link DetailNode} type. - */ - private static final DetailNode[] EMPTY_DETAIL_NODE_ARRAY = new DetailNode[0]; - /** * Node index among parent's children */ @@ -95,7 +90,7 @@ public class JavadocNodeImpl implements DetailNode { @Override public DetailNode[] getChildren() { if (children == null) { - return EMPTY_DETAIL_NODE_ARRAY.clone(); + return JavadocUtils.EMPTY_DETAIL_NODE_ARRAY; } else { return Arrays.copyOf(children, children.length); diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java b/src/main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java index 9065b08db..5961a3420 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtils.java @@ -43,6 +43,10 @@ import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTags; * @author Lyle Hanson */ public final class JavadocUtils { + /** + * Empty array of {@link DetailNode} type. + */ + public static final DetailNode[] EMPTY_DETAIL_NODE_ARRAY = new DetailNode[0]; /** Maps from a token name to value */ private static final ImmutableMap TOKEN_NAME_TO_VALUE; /** Maps from a token value to name */