TouchInstinct
/
checkstyle
305
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #2080: Replace ternary condition operator with if 

Fixes `ConditionalExpression` inspection violations.

Description:
>Reports the ternary condition operator. Some coding standards prohibit the use of the condition operator, in favor of if-else statements.
This commit is contained in:
Michal Kordas 2015-09-03 23:57:38 +02:00 committed by Roman Ivanov
parent 2b4a02d2c8
commit f7e41edb94
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/intellij-idea-inspections.xml
View File

@ -367,7 +367,7 @@
<inspection_tool class="ComparisonOfShortAndChar" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="ComparisonToNaN" enabled="true" level="ERROR" enabled_by_default="true" />
<inspection_tool class="ConditionSignal" enabled="true" level="WARNING" enabled_by_default="true" />
<inspection_tool class="ConditionalExpression" enabled="false" level="ERROR" enabled_by_default="false">
<inspection_tool class="ConditionalExpression" enabled="true" level="ERROR" enabled_by_default="true">
<option name="ignoreSimpleAssignmentsAndReturns" value="false" />
</inspection_tool>
<inspection_tool class="ConditionalExpressionJS" enabled="true" level="ERROR" enabled_by_default="true" />

5
src/it/java/com/google/checkstyle/test/base/BaseCheckTestSupport.java
View File

@ -123,7 +123,10 @@ public abstract class BaseCheckTestSupport
parseInt = parseInt.substring(parseInt.indexOf(':') + 1);
parseInt = parseInt.substring(0, parseInt.indexOf(':'));
int lineNumber = Integer.parseInt(parseInt);
Integer integer = Arrays.asList(aWarnsExpected).contains(lineNumber) ? lineNumber : 0;
Integer integer = 0;
if (Arrays.asList(aWarnsExpected).contains(lineNumber)) {
integer = lineNumber;
}
assertEquals("error message " + i, (long) integer, lineNumber);
}