Commit Graph

319 Commits

Author SHA1 Message Date
Rick Giles 7fb81fdf90 added WhitespaceAfterCheck 2002-11-11 11:54:06 +00:00
Rick Giles 9eb9d9b3ea replaced NoWhiteSpaceAroundCheck by NoWhitespaceAfterCheck and
NoWhitespaceBeforeCheck
2002-11-10 20:48:33 +00:00
Rick Giles bed446244a added NoWhitespaceBefore, NoWhitespaceAfter checks 2002-11-10 20:35:13 +00:00
Rick Giles 333e944de5 added check for wrap of assignment operators at eol 2002-11-10 19:45:25 +00:00
Rick Giles ecaaaeb254 added operator wrap check 2002-11-09 20:24:22 +00:00
Oliver Burn 5fc3ff2bfb Please ensure you thoroughly test code before committing it. As a sanity test,
ensure that the target "checkstyle.checkstyle" will run! If in doubt, do not
commit, but instead said a patch to the devel mailing list for a review.

Finished the port of the ClassResolver code. Even though it compiled, it had
no chance of working due to class casting problems. They have not been
fixed. Also needed to ensure the correct class loader is being used.
2002-11-06 03:57:58 +00:00
Oliver Burn 93bba09f70 Wanting to turn on the check - but it fails. Need to resolve as it is most
likely to be a classpath issue.
2002-11-06 00:14:40 +00:00
Rick Giles 3bcc2c1391 update for JavadocMethodCheck 2002-11-05 20:39:56 +00:00
Oliver Burn fb97056b9b Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
abstract methods.
2002-11-03 12:06:15 +00:00
Oliver Burn 4945b82e6d Folded the constructor length test into the method length check. Seems silly
to have them as separate checks.
2002-11-03 02:37:20 +00:00
Oliver Burn ba8a851e90 Fixed bug in MethodLengthCheck where it was assuming that a method definition
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
Oliver Burn 3288a81e30 Just converted over the Checkstyle ANT task to use the new framework. In
process I had to fix numerous errors now being reported.

There are some bugs with the method checks, which I will now investigate.
2002-11-02 12:22:14 +00:00
Oliver Burn 2effcfd0bc Start of conversion to only supporting the new framework. Also refactored
error handling.
2002-10-31 12:28:47 +00:00
Oliver Burn 75482cc4f0 disable todo checking when run under gump 2002-09-15 11:30:51 +00:00
Oliver Burn 2b9b1e2021 Added some advice on upgrading 2002-09-14 05:14:15 +00:00
Oliver Burn 310100c239 Added some advice on upgrading 2002-09-14 05:07:00 +00:00
Oliver Burn ea13b70f2f updated for JDE 2002-09-14 04:24:08 +00:00
Oliver Burn 63c7ac019f removed unused property 2002-09-13 09:10:07 +00:00
Lars Kühne 3fecb73fb3 incorporte patch 607481 from Ville Skyttä to enforce wrap on operator at EOL 2002-09-13 05:43:47 +00:00
Lars Kühne 8a65d2ff82 docs for package name check 2002-09-08 12:55:14 +00:00
Lars Kühne 218bbeb80d added <h2> headers 2002-09-08 07:53:14 +00:00
Oliver Burn 7f06106f4e Yahoo! Implemented checking for unused private fields. Just need to document
the new feature. It is off by default as the class path must be set up. Can
use the same technique for private methods.
2002-09-08 07:31:37 +00:00
Oliver Burn 98c8a0db55 The absolutely last refactoring change with the properties config stuff. I am
sick it. Absolutely sick of it! Completely and utterly sick of it!! Still, the
change is better for the future.
2002-09-07 02:02:24 +00:00
Oliver Burn 49eb0e934e Yet another refactor to have the ANT task support a nested <property>
element. This let me remove the ugly have I put in to support relative
paths. Got the idea from Vincet Massol. Bug 605141.
2002-09-07 01:36:40 +00:00
Oliver Burn aff5047c9e Patch to make loading of relative file paths work. Basically duplicating the
work that ANT used to do. There had to be some pain in the refactoring. ;-)
2002-09-05 02:46:40 +00:00
Oliver Burn ac18264bf6 Patch to make Checkstyle run. Need to fix the TODO reported. 2002-09-04 14:35:10 +00:00
Oliver Burn 8a2f9d179f Fixed bugs in the build.xml file. 2002-09-04 14:30:14 +00:00
Oliver Burn a5bd0522b8 Cleaned up to use the new config files. 2002-09-04 12:28:11 +00:00
Oliver Burn 47f3495932 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:17:29 +00:00
Oliver Burn a926120685 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:10:15 +00:00
Oliver Burn ece0896556 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 12:02:11 +00:00
Oliver Burn 87879a7e57 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 11:55:19 +00:00
Oliver Burn a743ec6339 fixed null reference :-) 2002-09-04 11:54:51 +00:00
Oliver Burn f02124d9d3 Renamed all checksXXXX.html files to configXXXX.html 2002-09-04 11:40:53 +00:00
Oliver Burn 19815691c6 Added copyright statements (I have lawyers!). Also removed invalid docs from
main documents.
2002-09-04 11:37:28 +00:00
Oliver Burn 573daea049 Against a snap shot of changes I do not want to lose. 2002-09-04 11:00:28 +00:00
Oliver Burn 2817b05ecc Against a snap shot of changes I do not want to lose. 2002-09-04 10:23:55 +00:00
Oliver Burn c6d2120f6e Against a snap shot of changes I do not want to lose. 2002-09-04 08:03:05 +00:00
Oliver Burn bfe1cbdbed Against a snap shot of changes I do not want to lose. 2002-09-04 04:04:03 +00:00
Oliver Burn e55cf9b0bc Please ignore - a work in progress that I want to backup. 2002-09-03 13:45:38 +00:00
Oliver Burn 0e733a20c8 Please ignore - a work in progress that I want to backup. 2002-09-02 13:19:01 +00:00
Oliver Burn 1192d56554 Please ignore - a work in progress that I want to backup. 2002-09-02 13:13:11 +00:00
Oliver Burn e98d817e3f Please ignore - a work in progress that I want to backup. 2002-09-02 12:21:17 +00:00
Oliver Burn a37a1d7ba9 Please ignore - a work in progress that I want to backup. 2002-09-02 12:12:38 +00:00
Oliver Burn f8a53831f0 Incorporate patch 555878 from Rick Giles to allow pattern for local final
variables to be specified.
2002-08-21 08:08:43 +00:00
Oliver Burn 1fdf65bf01 Incorporate patch 566855 from Rob Worth to optionally check that parenthesis
are padded with spaces.

Big thanks to Lars for suggesting that the Pad Option not be a boolean so
somebody could one day submit this patch. :-)
2002-08-21 04:39:27 +00:00
Oliver Burn d92ceb81a6 Implemented enforcing having @version tag. (Request 543964). 2002-08-20 13:08:37 +00:00
Oliver Burn ecc852d48b Added support to specify a country so that the call to the Locale()
constructor is not dependent on JDK 1.4.
2002-08-12 12:10:57 +00:00
Oliver Burn 5890d22a6d Added documentation for localisation and the ability to set the language. 2002-08-12 09:02:41 +00:00
Oliver Burn 7781985a34 Request 582144: added documentation. 2002-08-12 07:40:29 +00:00
Oliver Burn c682b5725d Major rework to support localized error messages. Inspired by patch 580410. At
the moment it is not possible to override the system locale, this probably
should be added.
2002-08-10 14:15:00 +00:00
Oliver Burn 6946a8440c Incorporate patch 590931 from Vijay Aravamudhan. 2002-08-10 09:23:52 +00:00
Oliver Burn e7c7215349 request 583719 - detect unused @throws that subclass java.lang.Error. 2002-08-04 05:01:20 +00:00
Oliver Burn a9884dffce Incorporate patch from ronald _DOT d _DOT hastings _AT boeing _DOT com to
correctly handle C++ style comments being between Javadoc comments and
declarations.
2002-08-02 00:02:26 +00:00
Oliver Burn 257d848c62 Added reference to an example report. 2002-07-17 00:08:22 +00:00
Oliver Burn ea371c4f3a Changed the wrap on operator implementation to take an option rather than a
boolean. This allows it to be extended easily in the future.
2002-07-08 03:47:56 +00:00
Lars Kühne 3230cfbc88 use checkstyle-all in the -jar example to make sure that the example works no matter how the CLASSPATH is setup 2002-07-06 09:08:11 +00:00
Lars Kühne f10286c78b avoid double negation in description of illegal.instantiations 2002-07-06 08:56:30 +00:00
Lars Kühne 90f1a05e2b removed my email address to avoid spam 2002-07-06 08:50:57 +00:00
Oliver Burn fd1225fe8b Fixed grammar mistake - thanks Lars. 2002-07-04 06:01:02 +00:00
Oliver Burn ba5a640c86 Document the -jar option. 2002-07-04 00:01:59 +00:00
Lars Kühne 8c8aabd141 added example for -r option (rfe #568911) 2002-07-02 20:50:18 +00:00
Lars Kühne b87542b262 fixed bug 561616 2002-07-02 20:21:04 +00:00
Oliver Burn b3133035a4 576165: better error handling for missing properties file. 2002-07-02 11:51:56 +00:00
Oliver Burn bbe51f6884 571161: Added support for basedir attribute. 2002-07-01 01:57:36 +00:00
Oliver Burn 0e62f23a10 573485: detect redundant 'abstract' 2002-06-26 13:17:31 +00:00
Oliver Burn 0c8c6f3b45 Added jEdit reference. 2002-06-25 02:50:22 +00:00
Oliver Burn ab32ca0d86 Fixed typo 2002-06-22 12:05:15 +00:00
Oliver Burn c176f8b8eb 568553: fix Javadoc errors under JDK 1.4 2002-06-22 10:50:13 +00:00
Oliver Burn 119aa7439f Implement checking for whitespace around "{" & "}". 2002-06-17 12:17:31 +00:00
Oliver Burn d8d9269bbc Added documentation for checkUnusedThrows. 2002-06-16 12:23:37 +00:00
Lars Kühne 14f2b27f8f added new commandline flag '-p' 2002-06-11 04:23:19 +00:00
Oliver Burn 3da466b9bf Added check to ensure that long integer literals use L, not l. Also fixed bug
by my over zealous removal of toString() methods.
2002-06-06 11:45:40 +00:00
Oliver Burn 4018efa9fe Refactored the catch block checking code to include try/catch/finally blocks. 2002-06-05 13:17:20 +00:00
Lars Kühne 87fb75661f added new feature "detect illegal instantiation" to 2.3 2002-05-30 04:45:18 +00:00
Oliver Burn ccd30545e2 Added documentation for checking for wrapping on operators 2002-05-29 13:00:28 +00:00
Lars Kühne da940af362 Implementation, tests and docs for generalization of instantiation check. Users can now specify a list of classes that are not allowed to be instantiated.
This also fixes Bug 556317, Boolean instantiation, as now a config option is provided and the check for java.lang.Boolean is turned off by default
2002-05-28 20:23:00 +00:00
Oliver Burn 1c5c068b3a Updated for catchBlock option 2002-05-26 13:27:36 +00:00
Lars Kühne 502082c736 docs for '-p' option 2002-05-20 10:36:25 +00:00
Lars Kühne 4425afa0c2 - #516255, find empty exception handlers. Maybe we should add some
"OK if commented" option, but I don't see how to do that in the grammar.
- initial support for #550205, find instantiations of Boolean. This is not
  configurable yet, and we should generalize it to find instantiation of
  arbitrary types. Docs are also still missing, will write them after
  generalization.
2002-05-15 04:34:59 +00:00
Oliver Burn dfd7310b96 Fix documentation to:
- Include a version number in headings
- Use the ANT <filterset> to update the version number. No longer need to
  update the docs for each release.
2002-05-14 04:33:54 +00:00
Oliver Burn fca8c91804 Request 504275: detect to-do comments 2002-05-13 12:52:55 +00:00
Oliver Burn 65989e76a4 Request 555262: Include column number in the XML output 2002-05-13 01:48:41 +00:00
Oliver Burn 9556af52eb Updated the version number. 2002-05-10 11:50:03 +00:00
Lars Kühne 1b7f3c143d real names for style sheet contributors 2002-05-10 04:39:00 +00:00
Lars Kühne 475115172e added hint about regexp-disabling of linelength check 2002-05-05 12:27:55 +00:00
Lars Kühne a84406be77 doc for tab expansion 2002-05-05 11:45:53 +00:00
Lars Kühne 7a9a4c2045 added releasenotes for old releases, rewrote 2.2 releasenotes 2002-05-01 07:35:39 +00:00
Lars Kühne a851e6db3c added releasenotes. Oliver, please spellcheck and fill in the 2.1 release if possible 2002-04-30 20:36:38 +00:00
Lars Kühne a736b629f8 added documentation for patch 531230, 'add properties file functionality' 2002-04-28 12:53:33 +00:00
Lars Kühne 1825bf38b9 fixed capitalization error that prevented link from working 2002-04-28 12:47:17 +00:00
Oliver Burn 3ded17ac3d Changed support for parenthesises padding to take an option, rather that being
a boolean of whether to ignore or not. This will allow the adding of more
styles in the future. Good idea Lars! :-)
2002-04-24 14:36:27 +00:00
Oliver Burn 083a7d432a Added option to disable checking for padding of parenthesis. As asked for by
Lars. Eventually should have an option to allow different styles - rather the
current "Sun way" or the "highway.
2002-04-22 10:41:10 +00:00
Lars Kühne caf539ded2 Implementation + docs for rfe 537107, "public" in interface methods 2002-04-21 21:02:57 +00:00
Oliver Burn e200d9bf3d 545128: implemented "-r" recursive option and improved the argument handling 2002-04-17 11:59:52 +00:00
Lars Kühne 00447a8fe3 added check for illegal imports 2002-04-17 04:43:55 +00:00
Lars Kühne 8eb824037e added documentation for regexp-disabling of line-length checks 2002-04-13 08:31:46 +00:00
Oliver Burn 49314771b6 Fixed bug that allowed constant declarations to contain "__". 2002-04-07 09:16:43 +00:00
Lars Kühne 9a8acc01fd added example for failureProperty, contribution from Gray Herter [gray _AT_ fgm _DOT_ com] 2002-03-24 09:05:28 +00:00
Lars Kühne 50d5a434f1 removed Eclipse from 'plugins wanted' list 2002-03-24 08:04:32 +00:00
Lars Kühne 0e0ca2bddf added failureProperty to ant task (RFE 534038) 2002-03-23 17:03:15 +00:00
Oliver Burn 2666ced62f Added reference to Eclipse plug-in 2002-03-21 11:32:34 +00:00
Oliver Burn ba441b3fd6 Added doc for allowing tabs. 2002-03-15 14:14:02 +00:00
Lars Kühne 59a8339758 updated tested JREs, fixed bug 517398 2002-02-26 06:03:31 +00:00
Oliver Burn 1a596b6827 Renamed anttasks.properties to checkstyletask.properties. A much clearer name. 2002-02-25 12:15:07 +00:00
Lars Kühne 10691121f4 fixed typo (making vs. maximum) 2002-02-24 16:00:00 +00:00
Lars Kühne 2a1cd247d2 upated feature list to reflect current status 2002-02-24 15:58:47 +00:00
Lars Kühne 15640a8a1a added documentation for anttasks.properties 2002-02-24 15:56:22 +00:00
Oliver Burn 171e8d02b5 Documented the rcurly option 2002-02-23 11:14:59 +00:00
Oliver Burn 05e366ecf3 Fixed errors found by Tidy (http://www.w3.org/People/Raggett/tidy/). 2002-02-22 04:49:30 +00:00
Oliver Burn 2afaad3fa2 Added documentation for the lcurly options. 2002-02-22 04:43:09 +00:00
Oliver Burn 59ce3f31d7 Added support for brace checking on the keywords try, catch, finally, static.
What are not covered deliberately are labels and instance initializers.
2002-02-22 04:12:04 +00:00
Oliver Burn 41e2089574 Added support for - for, do, else, synchronized 2002-02-22 03:37:41 +00:00
Oliver Burn f4860ef3b4 Implemented brace checking for "if" and "while" 2002-02-22 03:11:36 +00:00
Oliver Burn e61ba618f2 Scaring myself, but writing the documentation first for the brace checking. 2002-02-19 02:50:35 +00:00
Lars Kühne b7c466d38c replaced Netbeans from the list of IDE's missing Checkstyle integration
instead added VisualCafe
2002-02-17 10:52:11 +00:00
Oliver Burn d097038b81 added reference to nbCheckstyle 2002-02-16 22:07:30 +00:00
Lars Kühne faf76530d8 RFE #514033, check order of modifiers (implementation, test, and documentation) 2002-02-15 06:47:51 +00:00
Lars Kühne 913028d7f2 Implementation, docs and test for RFE 438478, ignore multiple lines in header.
This change is compatible for command line, Ant, and API.

The API compatibility resulted in some deprecated methods in Configuration,
you can remove them if you think that API compatibility is not as
important as clean code.
2002-02-10 18:29:10 +00:00
Oliver Burn bdd55605c0 Clarified (hopefully:-) how line counts are made on methods 2002-02-09 13:26:25 +00:00
Oliver Burn db84febeb5 Update the tests and documentation for checking whitespace around periods.
#493383
2002-02-09 13:18:30 +00:00
Lars Kühne 6fc674d4bf new feature 'headerfile regular expression support, rfe #499259' 2002-02-07 20:34:11 +00:00
Oliver Burn d7bc542ef7 fixed copy & paste error 2002-02-06 05:45:48 +00:00
Oliver Burn 6350e4c223 Updated version to 2.1 - as building for Conor who wants the requirePackageHtml
option.
2002-02-06 05:39:38 +00:00
Oliver Burn 2ceae1b3c4 Small cleanup 2002-02-06 05:33:59 +00:00
Lars Kühne aeacc039ed Added documentation for new parameters
requirePackageHtml, methodPattern, localVarPattern, allowPackage
2002-02-05 20:34:21 +00:00
Oliver Burn b779f3c1da Updated to the LGPL and version 2.0. 2002-02-04 12:44:04 +00:00
Oliver Burn 82ed05b01a Fixed HTML errors reported by Tidy. 2002-01-24 04:10:58 +00:00
Oliver Burn 673e98d6eb Added the SourceForge logo as required 2002-01-23 13:02:37 +00:00
Oliver Burn 9dd92fc237 cleaned up after a review by a colleague. 2002-01-22 05:39:28 +00:00
Oliver Burn 130a7d0932 improved comments about output format 2002-01-22 01:48:05 +00:00
Oliver Burn 604162085b improved comments about output format 2002-01-22 01:22:43 +00:00
Oliver Burn 7d5276b6a2 added support for generating Javadoc 2002-01-22 01:05:56 +00:00
Oliver Burn f5e1312191 ignore files 2002-01-21 23:45:23 +00:00
Lars Kühne 3cb5c532cf use consistent style in all documentation files 2002-01-21 18:51:25 +00:00
Oliver Burn d0dd35e29d added comments on formatter (draft) 2002-01-21 12:46:46 +00:00
Oliver Burn 1a8665ffc1 started to add docs on the formatter 2002-01-21 12:35:37 +00:00
Oliver Burn f1aa8a33bc Final comments about output 2002-01-21 12:08:30 +00:00
Oliver Burn acb0b4e16a started on documenting the formatters - not finished yet. 2002-01-21 06:33:43 +00:00
Oliver Burn b7fd0ec6c7 fixed the corrupt binary 2002-01-21 06:28:23 +00:00
Oliver Burn d137c3a72e grammar correction 2002-01-21 04:12:23 +00:00
Oliver Burn 16a2469de9 fixed the link errors 2002-01-21 04:12:00 +00:00
Oliver Burn e4d4d72440 renamed to index.html 2002-01-21 03:45:54 +00:00
Oliver Burn 359500ded0 Converted to be the home page 2002-01-21 03:44:45 +00:00
Oliver Burn ea8c1c3bc8 added more text 2002-01-21 03:42:16 +00:00
Oliver Burn ae0c61668f removed the annoying font size stuff 2002-01-21 03:41:38 +00:00
Oliver Burn b07067274b first cut 2002-01-21 03:41:07 +00:00
Lars Kühne c23d3ef0d5 make it easier to read varformat table when following the links from cmdline.html 2002-01-20 08:41:59 +00:00
Lars Kühne 7f16f80c83 included all links except the javadoc link in left menu 2002-01-20 08:21:11 +00:00
Lars Kühne df523818b2 refer to checkstyle version 1.4 and sourceforge homepage 2002-01-20 08:15:00 +00:00
Lars Kühne b127875884 display code in medium size, extra small is almost unreadable (at least in Mozilla) 2002-01-17 06:43:41 +00:00
Lars Kühne eaf23591a5 added secions 'Related Tools' and 'Download' 2002-01-17 06:42:26 +00:00
Oliver Burn 62f7c400e1 The start of the new home page/documentation. 2002-01-16 11:47:36 +00:00
Oliver Burn 2727473656 Changed the defaults for member/static/parameter regexps to match the Sun coding
standard. The intent of this change is to make it easier for people to use
checkstyle out-of-the-box to check the Sun coding standard.
2002-01-15 12:54:03 +00:00
Oliver Burn 0b7bf27706 Now support ignoring whether whitespace is after a type cast. As requested by
Lars.
2002-01-08 04:18:02 +00:00
Lars Kühne 6eaab74faa javadoc checkscope documentation 2002-01-06 12:50:43 +00:00
Oliver Burn b7f1d0d1b7 Added support to check that commas ',' are followed by whitespace (ala the Sun
coding standard). This mainly involved refactoring the code I just wrote for
checking casts.
2002-01-06 10:31:32 +00:00
Oliver Burn d87ea06ebb Added support for checking the file length does not exceed a specified max. 2002-01-06 07:08:20 +00:00
Oliver Burn a3d490b41f Updated documentation for the new checks on method and constructor lengths 2002-01-06 06:29:19 +00:00
Oliver Burn 1d83e8ea2e fixed building 2001-11-03 11:00:48 +00:00
Oliver Burn 78ab632ff2 updated docs 2001-11-02 05:58:51 +00:00
Oliver Burn a40de3bf77 improve docs 2001-11-01 23:05:30 +00:00
Oliver Burn f8a69b0780 fix typos 2001-10-31 13:16:47 +00:00
Oliver Burn 403a3f70a3 patch to control ANT stopping the build on violations 2001-10-31 13:06:28 +00:00
Oliver Burn d3f39e6b87 Added support for public member patterns. 2001-08-05 06:41:59 +00:00
Oliver Burn dbe008a549 added reference to sourceforge 2001-07-02 06:49:18 +00:00
Oliver Burn b06dd9801e updated for the IgnoreBraces property 2001-07-02 06:42:29 +00:00
Oliver Burn ba46163e7c Added support for IgnoreWhitespace property. 2001-06-29 14:31:36 +00:00
Oliver Burn 5f53a2a380 first cut 2001-06-22 13:15:09 +00:00