Commit Graph

743 Commits

Author SHA1 Message Date
Lars Kühne 2149a9c42d removed todo items that have already been resolved 2002-12-27 09:58:26 +00:00
Lars Kühne 58ce4c4097 fixed bug #648708, Misleading doc for checkUnusedThrows
Renamed property checkUnusedThrows to allowUndeclaredRTE to better reflect the meaning of the property.
2002-12-27 09:31:33 +00:00
Lars Kühne b8c558e473 Moved detection of missing headerFile property to configuration phase
This means that Checkstyle will not run, until now it was writing
a configuration error in the audit log file.

Also fixes bug #629139, Empty value ignores file
2002-12-27 08:16:46 +00:00
Lars Kühne 2a71cac7e0 improved end user error message for module hierarchy problems 2002-12-26 17:21:44 +00:00
Rick Giles b52b887d19 fixed typo 2002-12-26 13:30:35 +00:00
Rick Giles 28753ca5fe performance improvement: avoiding charAt range checks is worth the
cost of toCharArray
2002-12-25 23:27:31 +00:00
Rick Giles 4e0914c73b performance improvement - eliminate multiple instance creation for
tree context HashMap.
Still at the top of the performance hit parade for Checkstyle non-parsing methods.
2002-12-25 14:05:55 +00:00
Rick Giles 3badd996bf performance improvement - eliminate multiple instance creation for
context HashMap.
Still at the top of the performance list of Checkstyle non-parsing methods.
2002-12-25 13:07:08 +00:00
Rick Giles e0651ea2fb corrected expected error message 2002-12-25 12:51:17 +00:00
Rick Giles 23c8b2a107 corrected Checkstyle errors 2002-12-25 12:07:25 +00:00
Lars Kühne 661274b680 improved error messages for JavadocTypeCheck 2002-12-23 15:58:16 +00:00
Lars Kühne e8d025321c don't silently ignore misspelled property names 2002-12-23 07:39:40 +00:00
Lars Kühne b9da95f948 improve error messages 2002-12-23 00:30:12 +00:00
Lars Kühne 2674c0cb24 VisibilityModifier didn't have the set of allowed names that were mentioned in the docs,
which is OK since that can be done by pattern matching.
Replaced the f-pattern with serialVersionUID and fixed the docs and tests accordingly.
2002-12-22 08:34:45 +00:00
Rick Giles 44ad8ceedb added attribute "packageNamesFile" to checkstyle task element 2002-12-19 23:27:52 +00:00
Rick Giles 56dc1248f7 prevent user from setting tokens in configuration 2002-12-19 11:18:31 +00:00
Rick Giles 787ac33df7 minor Javadoc correction 2002-12-19 11:17:54 +00:00
Rick Giles 7feaf606e8 Prevent user from changing tokens in the configuration. 2002-12-19 09:46:36 +00:00
Oliver Burn a14bce7522 Refactored all the LeftCurly checks into one 2002-12-19 06:55:35 +00:00
Oliver Burn f50c47545a Refactored all the LeftCurly checks into one 2002-12-19 06:50:19 +00:00
Oliver Burn b2ceac7a2b Removed test as requested. Not required anymore 2002-12-19 03:50:22 +00:00
Rick Giles 8ccfddcd2d version 3.0 documentation and minor corrections 2002-12-19 00:04:37 +00:00
Rick Giles 65d0c68b6c Removed unused import (oops). 2002-12-18 19:04:50 +00:00
Rick Giles e68e6c3cff Prevent user from specifying tokens in a configuration file. 2002-12-18 18:58:59 +00:00
Rick Giles 1612aaf7d7 minor documentation corrections 2002-12-18 18:06:23 +00:00
Rick Giles 2d88ca65d2 Javadoc correction 2002-12-18 16:18:31 +00:00
Rick Giles 0dc5dd977b allocate acceptable tokens only when necessary 2002-12-18 11:19:02 +00:00
Rick Giles 95a5040ccc Added required tokens. 2002-12-18 10:55:36 +00:00
Oliver Burn 39ff4631b4 should this test still exist??? 2002-12-17 22:21:17 +00:00
Rick Giles 2a29a7cb4c Added method getAcceptableTokens.
Rationale: user can configure only METHOD_DEF and CTOR_DEF tokens.
2002-12-17 20:48:30 +00:00
Lars Kühne 0d9674b955 with the delegation approach the PackageNamesBean is obsolete 2002-12-16 06:30:17 +00:00
Lars Kühne 88e89a138a Changed implementation of module name resolution from inheritance to delegation approach 2002-12-16 06:26:46 +00:00
Rick Giles 72b40a3552 corrected Javadoc comment 2002-12-16 00:40:47 +00:00
Rick Giles fa0c0353c2 Changed Javadoc documentation for "config" elements to "module" elements. 2002-12-16 00:37:36 +00:00
Rick Giles 4564aecb5c Changed configuration XML element "config" to "module".
Dropped suffix "Check" in Check configurations.
2002-12-16 00:22:14 +00:00
Rick Giles fedf99f9a8 Minor cleanup. Uncomfortable with duplication in TreeWalker. 2002-12-15 12:11:50 +00:00
Rick Giles 958d0dae4d if instantiating with aName fails, try aName + "Check" (Lars' suggestion) 2002-12-15 12:10:07 +00:00
Lars Kühne 3a5f587882 renamed ASSERT to LITERAL_ASSERT for consistency with other literal tokens 2002-12-15 09:02:11 +00:00
Lars Kühne 278b12b7c2 Removed DetailsAST.setParent() from public API.
I'm scaring myself with the techniques I used to achieve this, but
I opted for getting the API right. We can't fix the API once
it's out the door, whereas we can try to remove this hack later after
more investigation how ANLTR works.
2002-12-14 11:09:22 +00:00
Rick Giles 6ba28f2ef1 Added XML declaration.
A DTD would be nice, too.
Will work on that tomorrow.
2002-12-12 23:52:30 +00:00
Rick Giles 148513d67a paranoia 2002-12-12 20:51:56 +00:00
Rick Giles b25fe8281b restore original LineLengthCheck ignorePattern property 2002-12-12 11:39:05 +00:00
Lars Kühne a49ad917dd fixed NPE in TranslationCheck, make sure getParentFile is not null 2002-12-12 06:51:25 +00:00
Oliver Burn b3caa3b7ad Fix bug where init/destroy not called for Checks. 2002-12-12 04:19:11 +00:00
Rick Giles 97993a0de7 more Javadoc 2002-12-11 00:32:25 +00:00
Rick Giles 2992f90777 more Javadoc 2002-12-10 23:55:08 +00:00
Lars Kühne 08d6efe49d make AutomaticBean.configure() final and provide defined extension points
to prevent programming errors in user classes.
2002-12-10 19:13:35 +00:00
Lars Kühne 987da3a4c5 removed redundant type cast (the magic of InelliJ IDEA) 2002-12-10 18:04:01 +00:00
Lars Kühne 30bb5b3a28 make it clear that DetailAST is not meant to be extended by Check authors 2002-12-10 06:06:55 +00:00
Rick Giles ae7e188a7e beef up Javadoc. Could use a proofreader now.
TODO:
HeaderCheck,
RegexpHeaderCheck - what's RFE 597676?
VisibilityModifierCheck - is the comment about "serialVersionUID" consistent with the code?
2002-12-10 00:37:43 +00:00