Commit Graph

1785 Commits

Author SHA1 Message Date
Oliver Burn 61f25fbed0 start of refactoring to consolidate all the regexp checks. 2008-12-22 11:21:35 +00:00
Oliver Burn a1c457174f opps - forgot to delete this. 2008-11-16 11:16:47 +00:00
Oliver Burn f66b504b06 consolidation of code. 2008-11-16 11:11:02 +00:00
Oliver Burn 4a54918109 removing CrossLanguageRegexpHeaderCheck. 2008-11-16 10:54:31 +00:00
Oliver Burn bf16d371da converting the header checks to be fileset based. 2008-11-16 10:30:12 +00:00
Oliver Burn fc8a5ae78c Changed FileLength check to be a FileSetCheck. 2008-11-09 12:12:27 +00:00
Oliver Burn 67e304551b documentation update. 2008-11-09 11:04:09 +00:00
Oliver Burn f1fcae2314 remove an unneeded setter. 2008-11-09 10:43:58 +00:00
Oliver Burn 379fbd8e20 update documentation for charset. 2008-11-09 10:31:34 +00:00
Oliver Burn 2e4762f171 consolidate charset handling. 2008-11-09 10:19:43 +00:00
Oliver Burn 13b7c63433 A large refactoring to move the functionality of open/reporting on files into Checker and out of FileSetCheck. The advantages are:
- reduces the logic required in each implementation of FileSetCheck.

- reduces, but not eliminates, the number of times a file is reported as being audited.

- reduces the amount of times a file needs to be read in from the file system.

The motivation is the desire to move more checks to be purely FileSetCheck based, like the TabCharacter check.

I still need to do some tidying up of the documentation, and make Checker support "charset".
2008-11-09 09:37:27 +00:00
Oliver Burn 5dfb3f5a9e fix broken test. 2008-11-08 03:27:46 +00:00
Oliver Burn bd8a1a545f New check FileTabCharacter for ensuring that any files does not contain a tab character. It is now used to ensure the documentation files do not contain tabs.
Also introduced Utils.closeQuietly to clean up code.
2008-11-06 07:21:12 +00:00
Oliver Burn 4542d7c95e Added documentation for the enhanced DescendantTokenCheck. 2008-11-05 00:48:09 +00:00
Oliver Burn 6a5d1ff834 enhanced the DescendantTokenCheck to have a property to use the total of found tokens, not the individual counts. This allows a check to be configured to find code like:
if (this != null) { ...

Where it is crazy to "this" in this way (pun intended!).

Still need to document the change.
2008-11-04 20:10:43 +00:00
Oliver Burn c6d30db200 Checkstyle command-line no longer reports a usage error if the user specifies a directory with the -r option that does not contain any files. Thanks to Florian for patch #2151706. 2008-10-28 07:11:26 +00:00
Oliver Burn b2ac4e14e7 remove old file. 2008-10-28 06:51:59 +00:00
Oliver Burn 203fb68335 update list of tools to include Sonar 2008-10-23 11:08:39 +00:00
Lars Kühne 0cc473e04f The NCSS complexity checker reported an incorrect fileMax value (bug #2161419). 2008-10-20 21:50:18 +00:00
Oliver Burn a9e923790f Fix a typo. 2008-09-22 23:50:14 +00:00
Oliver Burn d62a2cc020 Inspired by patch# 2111354 - changes to remove casting. Neat trick 2008-09-18 11:34:16 +00:00
Oliver Burn 22136c67e9 Add new options to the ImportOrderCheck to make it more flexible. Thanks to David Didier for providing patch #1854213. 2008-09-07 11:28:48 +00:00
Oliver Burn 7f1be5c858 New check OuterTypeNumber for enforcing the maximum number of outer types per file. Inspired by patch #1145023 from Alexander Jesse. 2008-07-22 06:12:22 +00:00
Oliver Burn a6471e8a26 fix a bug found with inner definitions. 2008-07-16 08:23:02 +00:00
Oliver Burn 756e47a05a fix a warning. 2008-07-16 07:21:43 +00:00
Oliver Burn a940528692 fix bug #2018094 2008-07-16 06:58:54 +00:00
Oliver Burn 27cb05b945 final changes for patch [ 1917420 ] Allow custom, parametrized check messages 2008-07-16 06:52:24 +00:00
Oliver Burn aac769a0be minor clean up 2008-07-16 05:16:02 +00:00
Oliver Burn a1422eed4e clean up a unit test and documentation. 2008-07-16 04:29:48 +00:00
Oliver Burn 17754d3636 snapshot of changes - need to refactor 2008-07-15 22:27:42 +00:00
Oliver Burn 3b5c81da39 New checks ClassTypeParameterName and MethodTypeParameterName for type name formats.
Thanks to Travis Schneeberger for providing patch #1956561.
2008-07-02 06:33:55 +00:00
Oliver Burn d4b933799a Overhaul of how <span class="code">AbstractOptionCheck</span> works.
It now requires that the option type is a Java 5 Enum and hence the
<span class="code">AbstractOption</span> class has been removed.
2008-07-02 05:19:54 +00:00
Oliver Burn d2af4accdd Apply parts of patch #1952556 fixing some FindBugs bugs. Thanks to Travis Schneeberger 2008-07-02 03:16:04 +00:00
Oliver Burn ecc5239c78 Changed the classes Scope and SeverityLevel to be based on the Java 5 Enum class. Used patch #2004776 from Travis Schneeberger. 2008-07-02 01:22:16 +00:00
Oliver Burn 3e05297d53 Fix up silly compiler warnings. 2008-06-23 05:42:24 +00:00
Oliver Burn 428c1a057e Applied patch #1993103 to make the format of end of sentence configurable in the JavadocStyle check. 2008-06-17 04:41:09 +00:00
Lars Kühne dc554dea8a fixed spelling 2008-05-23 20:58:56 +00:00
Lars Kühne 9531dbd640 fixed typo in javadoc 2008-05-21 20:34:32 +00:00
Lars Kühne 6cd4235971 fixed typo in javadoc 2008-05-12 19:34:19 +00:00
Lars Kühne 369c315ff0 fixed typo in javadoc 2008-04-28 20:22:49 +00:00
Lars Kühne 6a3391fc1b fixed typo in javadoc 2008-04-28 20:20:18 +00:00
Lars Kühne fa3199e2bc cleaned up old hack to check that aCharset is supported 2008-04-28 20:10:17 +00:00
Lars Kühne 3b0a175562 fixed typo in javadoc 2008-04-28 19:44:17 +00:00
Lars Kühne ce8556574f fixed typo in javadoc 2008-04-27 19:28:46 +00:00
Lars Kühne 4f86310014 upgraded to commons-cli 1.1 (ASL 2.0) 2008-04-27 13:18:27 +00:00
Oliver Burn a3a38cbee4 rename the base class to be abstract 2008-04-27 12:26:14 +00:00
Oliver Burn 2ee144e379 Refactor out common code. 2008-04-27 11:24:50 +00:00
Oliver Burn 911065320f fixing things reported by FindBugs 2008-04-26 03:45:31 +00:00
Oliver Burn ff6c49e6a7 This change makes a lot of sense. 2008-04-24 14:49:08 +00:00
Oliver Burn b3f724f871 Remove use of ArrayStack and rename get(int) to peek(int) which is a better name IMHO. 2008-04-24 14:42:27 +00:00