Commit Graph

103 Commits

Author SHA1 Message Date
Michal Kordas 4e0cb46ae5 Fix RegexpMultiline causing exception with default config. #1129 2015-05-26 02:20:05 +02:00
Roman Ivanov 9f9c810af3 system property '-Dcheckstyle.ant.skip=true' will skip execution of Checkstyle validation over its own code 2015-05-22 20:19:46 -07:00
Roman Ivanov 14bca4f18d checkstyle launcher is wrapped by timestamps 2015-05-22 10:43:18 -04:00
Michal Kordas 0f58857d73 Change location of left curly braces to end of line. #1089 2015-05-17 13:47:09 +02:00
Roman Ivanov 6cdcfc135a Findbugs violation: defines compareTo(LineColumn) and uses Object.equals(). #911 2015-05-15 23:52:15 -07:00
Roman Ivanov e6034ec381 Findbugs violation: AuditEvent.message is transient but isn't set by deserialization. #909 2015-05-15 17:04:32 -07:00
Roman Ivanov cd6f271a6b explanation for findbug suprpession. #778 2015-05-15 15:52:57 -07:00
Roman Ivanov 5e0b6286ac Findbugs violation: api.TokenTypes do System.exit(...). #923 2015-05-15 15:31:59 -07:00
Roman Ivanov c3dc1a94f3 Findbugs violation: resolve all violations from gui package. #925 2015-05-15 13:23:17 -07:00
Roman Ivanov d6938de537 explanation of suppression was added. #910 2015-05-15 10:38:21 -07:00
Michal Kordas dba746ba93 Fix PMD violations from PrematureDeclaration rule. #948 2015-05-13 09:58:12 -07:00
Michal Kordas 5ff1834a22 Fix PMD violations from AvoidFieldNameMatchingMethodName rule. #984 2015-05-13 09:54:48 -07:00
Michal Kordas 3c7c3cbe88 Remove obsolete exclusion from PMD configuration. #960 2015-05-13 09:49:07 -07:00
Michal Kordas 466b1ebb31 Fix SeparatorWrap Check violations in Checkstyle code. #945 2015-05-13 09:47:17 -07:00
Michal Kordas 3300c3c835 Enable several Checkstyle Checks on codebase, issue #945 2015-05-10 21:04:18 +02:00
Roman Ivanov 93e0187129 removal of validation suppressions, and resoling of them. Issue #596 2015-05-05 17:40:26 -04:00
Michal Kordas a0acabc125 Fix FallThrough check violation in code, issue #945 2015-05-03 11:34:00 -07:00
Michal Kordas a2b8be14bb Fix PMD violations from SimplifyStartsWith rule, issue #949 2015-05-03 17:00:25 +02:00
Michal Kordas 0f543a21fe Fix DeclarationOrder check violations in Checkstyle code, issue #1049 2015-05-02 23:27:11 -07:00
Michal Kordas d784ab7f69 Enable several Checkstyle checks on code, issue #945 2015-05-01 22:38:17 -07:00
Michal Kordas e63c0fb258 Enable EmptyLineSeparator check, issue #1040 2015-05-02 01:32:54 +02:00
Michal Kordas f9374238b2 Fix inner class should be static FindBugs violations, issue #928
All violations of [SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS](http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS) are fixed.
2015-05-01 09:28:08 -07:00
Michal Kordas 193474f518 Fix PMD violations from TooFewBranchesForASwitchStatement rule, issue #998 2015-05-01 07:29:17 -07:00
Michal Kordas 4f9b3cdad8 Fix EmptyCatchBlock violations in Checkstyle codebase, issue #945 2015-05-01 15:19:10 +02:00
Michal Kordas c0446a8255 Fix PMD violations from UseVarargs rule, issue #999
The changes are fully backward-compatible. Method with vararg can be invoked both using array and list of parameters.
2015-04-29 17:21:14 -07:00
Roman Ivanov e971fcd9b5 fix for PMD logging-java rules. Issue #870 2015-04-26 10:33:29 -07:00
Roman Ivanov a033b87e5e suppression comments were added. Issue #744 2015-04-26 10:22:06 -07:00
Roman Ivanov 0552912c9f fix for violations of PMD LogicInversion. Issue #744 2015-04-26 10:14:36 -07:00
Roman Ivanov e453e5bdb3 fixed violations for PMD rule SingularField. Issue #744 2015-04-26 09:57:28 -07:00
Roman Ivanov c1ce1f8f0c fixed violations for PMD rule UseCollectionIsEmpty. Issue #744 2015-04-26 09:49:35 -07:00
Roman Ivanov 32774b62c8 comments were added for suppressions. Issue #744 2015-04-26 09:43:31 -07:00
Michal Kordas 51b2114e61 Fix AnnotationLocation violation in Checkstyle codebase, issue #945 2015-04-26 09:15:13 -07:00
Michal Kordas f374e2e7a0 Fix AvoidStaticImport check violations in codebase, issue #979 2015-04-26 09:13:56 -07:00
Roman Ivanov cb5f9827e5 activation and suppression comments for PMD design rules. Issue #744 2015-04-25 23:46:48 -07:00
Michal Kordas 55b266cd92 Fix AtclauseOrder check violations in codebase, issue #978 2015-04-26 02:30:41 +02:00
Michal Kordas fe345d3db7 Fix PMD violations from 'javabeans' ruleset in Checkstyle, issue #987 2015-04-25 16:33:25 -07:00
Roman Ivanov 228936fb40 PMD rule LongVariable is activated. Issue #744 2015-04-25 16:29:45 -07:00
Michal Kordas fcb9246b30 Provide reasons for exclusions in 'naming' ruleset, issue #982 2015-04-24 23:09:20 +02:00
Michal Kordas b29ca6b5f6 Fix and suppress PMD violations from ShortClassName rule, issue #982 2015-04-24 23:09:13 +02:00
Michal Kordas 4ac32a7c0c Fix PMD violations from ShortMethodName rule, issue #982 2015-04-24 21:21:29 +02:00
Michal Kordas f9a9d6c3d3 Fix PMD violations from BooleanGetMethodName rule, issue #982 2015-04-24 21:19:14 +02:00
Michal Kordas 5cd16d56a2 Fix PMD violations - AvoidFieldNameMatchingTypeName rule, issue #982 2015-04-24 21:12:15 +02:00
Michal Kordas e8a4ab77ab Expand PMD configuration for 'naming' ruleset, issue #982 2015-04-24 21:12:10 +02:00
Roman Ivanov 3d3f3d5f9c PMD rule AbstractClassWithoutAbstractMethod is activated. Issue #744 2015-04-23 19:51:10 -04:00
Roman Ivanov b26b43a331 some PMD design rules were activated and commented with reason of exclude. Issue #744 2015-04-23 19:40:47 -04:00
Roman Ivanov 18ed7958cf PMD rule AvoidSynchronizedAtMethodLevel is activated. Issue #744 2015-04-23 19:34:59 -04:00
Roman Ivanov 6b58e1c7fd some PMD design rules were activated and commented with reason of exclude. Issue #744 2015-04-23 19:32:48 -04:00
Roman Ivanov e6cb719f9b some PMD design rules are activated. Issue #744 2015-04-23 19:03:30 -04:00
Roman Ivanov e30fa27dc4 PMD Rule:AccessorClassGeneration Priority:3 Avoid instantiation through private constructors from outside of the constructors class. Issue #744 2015-04-23 18:52:43 -04:00
Roman Ivanov 22cbf810a0 PMD rule ConstructorCallsOverridableMethod is activated. Issue #744 2015-04-23 18:51:23 -04:00