Commit Graph

223 Commits

Author SHA1 Message Date
Oliver Burn e7c7215349 request 583719 - detect unused @throws that subclass java.lang.Error. 2002-08-04 05:01:20 +00:00
Oliver Burn a9884dffce Incorporate patch from ronald _DOT d _DOT hastings _AT boeing _DOT com to
correctly handle C++ style comments being between Javadoc comments and
declarations.
2002-08-02 00:02:26 +00:00
Oliver Burn 7f8726ee78 Changed # parameters to 7 (from 5) and in the process spent more time writing
this comment that changing the code. :-)
2002-07-21 12:04:27 +00:00
Lars Kühne 49bcb59031 fixed false alarm about unused imports for class array objects (e.g. Vector[].class), reported by Michael Rumpf 2002-07-21 10:27:32 +00:00
Oliver Burn c8a57d0b85 Added a check for excessive numbers of parameters. Still need to add the
documentation and a unit test. Still not sure what the correct default value
it, taken the value of 5.
2002-07-16 13:25:15 +00:00
Oliver Burn e543c01abd Changed the wrap on operator implementation to take an option rather than a
boolean. This allows it to be extended easily in the future.
2002-07-08 02:23:38 +00:00
Lars Kühne 7521f1897b fixed bug where reported file names were not correct when checkstyle.basedir ended with File.separator 2002-07-06 06:35:29 +00:00
Lars Kühne 784085d313 close the OutputStream when audit has finished 2002-07-04 04:21:11 +00:00
Oliver Burn f60f8b7e20 Made the output like it was before 2002-07-04 01:30:55 +00:00
Oliver Burn f5d8599819 Corrected problem where property JAVADOC_CHECK_UNUSED_THROWS_PROP not being
set.
2002-07-03 23:45:37 +00:00
Oliver Burn 3382af9cc9 Fixed a compile error. 2002-07-03 01:38:28 +00:00
Oliver Burn 041413baf7 Fixed what I believe was a bug in closing the streams - the logic was around
the wrong way. Also made some member variables private.

LARS - PLEASE CHECK I GOT THIS RIGHT!
2002-07-03 01:35:05 +00:00
Lars Kühne add2bdfb27 fixed bug 561616 (ant task should log errors, not infos)
This required a redesign of the AuditListener interface, the get/setOutputStream methoeds have been removed, as there might be listeners that have no or more than one OutputStream.

The DefaultLogger now differentiates between info messages ("started checking file ...", etc.) and error messages (style errors found by checkstyle) by writing the messages to two different OutputStreams.
2002-07-02 20:08:37 +00:00
Oliver Burn b3133035a4 576165: better error handling for missing properties file. 2002-07-02 11:51:56 +00:00
Oliver Burn bbe51f6884 571161: Added support for basedir attribute. 2002-07-01 01:57:36 +00:00
Oliver Burn f8eaf47b4e 573485: detect redundant 'abstract' and also added test for long c-style
comments
2002-06-26 13:16:58 +00:00
Oliver Burn 119aa7439f Implement checking for whitespace around "{" & "}". 2002-06-17 12:17:31 +00:00
Oliver Burn 37e181d6dc Fix bug I introduced with the class loader. I hang me head in shame as I did
not look at the output of the unit tests.
2002-06-17 00:38:23 +00:00
Oliver Burn 2795663dae Cleanup on naming. 2002-06-16 12:22:05 +00:00
Oliver Burn 92358288d9 Support setting the classpath to locate classes 2002-06-15 13:34:48 +00:00
Oliver Burn a95e61912c Added test that gets 100% code coverage. Sweet! :-) 2002-06-15 13:04:25 +00:00
Oliver Burn 4a0711b2be Improving code coverage while watching England demolish Denmark in the world
cup.
2002-06-15 13:03:31 +00:00
Oliver Burn 9ef2cd2121 Changed to use class loader in configuration. 2002-06-15 13:02:21 +00:00
Oliver Burn 5ff797c94a Added support for specifying a class loader 2002-06-15 13:01:08 +00:00
Oliver Burn d114de9013 Added a reminder message. 2002-06-15 12:59:31 +00:00
Oliver Burn a097f67d1c Removed an extra debugging statement 2002-06-14 13:52:20 +00:00
Oliver Burn e823178df0 First cut at a class to resolve class names. It has some limitations (inner
classes), but I think it is a good enough start. Still need to do the unit
tests.
2002-06-14 13:23:18 +00:00
Oliver Burn 4404c2d308 Removed the logic for resolving classes 2002-06-14 13:21:17 +00:00
Oliver Burn 4509e18f16 Changed to use the new ClassResolver 2002-06-14 13:19:58 +00:00
Lars Kühne 47adf64795 Fixed another NPE for toplevel package.
Maybe I should test first and then commit ... :-(
2002-06-08 10:19:59 +00:00
Oliver Burn d84b2a1c6b Added the comment with the logic to determine FQCN. 2002-06-07 06:43:26 +00:00
Oliver Burn 503677ccb9 A basic working implementation of checking for @throws tags that are instances
of RuntimeException. Marked with TODO: comments what still needs to be
done. This should work in most cases.
2002-06-07 06:27:51 +00:00
Oliver Burn 1a7694f787 A whole lot more refactoring on the setting of properties. I am going to stop
now and obey the law of decreasing returns. :-)
2002-06-07 03:11:30 +00:00
Oliver Burn 4065b43922 Cleanup moving from flag to property 2002-06-07 00:10:11 +00:00
Oliver Burn 957f644aef Refactored the handling of integer properties. 2002-06-06 23:59:44 +00:00
Lars Kühne 3a5f01cc66 fixed NPE for classes in toplevel package when instantiation checks were turned on 2002-06-06 20:13:24 +00:00
Oliver Burn 8af07e5dfd Start of a re-factor on the way options are set. Started on the easy
booleans. The downside of this approach is that is not 100% full-proof for the
plug-in developers. I think it is an acceptable compromise.
2002-06-06 13:52:36 +00:00
Oliver Burn 9ad235214f Start of a re-factor on the way options are set. Started on the easy
booleans. The downside of this approach is that is not 100% full-proof for the
plug-in developers. I think it is an acceptable compromise.
2002-06-06 13:39:41 +00:00
Oliver Burn 3da466b9bf Added check to ensure that long integer literals use L, not l. Also fixed bug
by my over zealous removal of toString() methods.
2002-06-06 11:45:40 +00:00
Oliver Burn 4018efa9fe Refactored the catch block checking code to include try/catch/finally blocks. 2002-06-05 13:17:20 +00:00
Oliver Burn dc92fd1b89 Removed deprecated methods that have floating around for 2 releases. Their
time was up.
2002-06-02 23:20:35 +00:00
Lars Kühne 9f4ef5821a Javadoc cleanup 2002-06-02 12:09:55 +00:00
Oliver Burn f3895598fe Watching Germany destroy a team in the 2002 world cup. Oh, also updating the
code coverage of the tests. :-)
2002-06-01 12:19:27 +00:00
Oliver Burn 4e49cc8d2a Added to improve code coverage. Trying out Clover (www.thecortex.org/clover). 2002-05-31 13:58:02 +00:00
Oliver Burn acb49a1e58 Removed unused code - will add a proper implementation is required. 2002-05-31 13:55:52 +00:00
Oliver Burn 3507ce50c1 oversight 2002-05-29 13:11:13 +00:00
Oliver Burn 7adeb1ad63 Fixed a misleading comment 2002-05-29 12:42:59 +00:00
Oliver Burn 4c02d6ec94 First cut 2002-05-29 12:41:56 +00:00
Oliver Burn ff0a2c0479 Added the ability to turn off checking for wrapping on operators 2002-05-29 12:41:01 +00:00
Oliver Burn 474e266acd Turn off the operator wrapping test until I can provide an option to
turn just it off.
2002-05-28 21:50:24 +00:00