Commit Graph

665 Commits

Author SHA1 Message Date
Oliver Burn 8a75a5feec improve code coverage 2002-12-08 04:09:15 +00:00
Oliver Burn 4a93f55b6c Fix what I believe is a bug 2002-12-08 03:54:03 +00:00
Oliver Burn 3215661e63 minor changes found will trying to debug why the tests
are failing.
2002-12-08 03:18:25 +00:00
Rick Giles 4c653936fa Javadoc corrects. Property setters for regular expressions conform
with other checks.
2002-12-07 20:49:44 +00:00
Oliver Burn f1918ff499 Move across to the correct package 2002-12-07 14:44:27 +00:00
Oliver Burn 2584fe7a9b Move across to the correct package 2002-12-07 14:34:07 +00:00
Oliver Burn 913cb76d04 Move across to the correct package 2002-12-07 14:22:45 +00:00
Oliver Burn de9f3e7b88 Move across to the correct package 2002-12-07 14:04:50 +00:00
Oliver Burn 09b3756690 Move across to the correct package 2002-12-07 13:56:24 +00:00
Oliver Burn 57bb8f3e0f Move across to the correct package 2002-12-07 13:49:22 +00:00
Oliver Burn 3d77a28657 Move across the import checks 2002-12-07 13:43:21 +00:00
Oliver Burn 5190c8f656 Refactoring to put the unit tests for the checks into the
proper package.

Side note: Eclipse makes this refactoring very easy to do.
As part of the move it performs all the CVS operations
that are required for moving a file. I actually like the
Eclipse support for CVS, I thought nothing would beat
good old Emacs.
2002-12-07 13:34:49 +00:00
Oliver Burn 76ae239351 Refactoring to move all the XML parsing logic into a
common place.
2002-12-07 13:02:52 +00:00
Oliver Burn 9d4233b0b7 Fixed the checkstyle errors 2002-12-07 12:24:03 +00:00
Oliver Burn 8dd310c982 Changes to get the header check going again. I like the
change that was made for the properties, it leverages
off the work we did in the 2.4 release to allow properties
to be overriden in the ANT file.
It is now possible to run the checkstyle task from any
directory - nothing is now location specific. This includes
the location of the header file or the DTDs. Good to
finally reach this milestone.
2002-12-07 12:18:57 +00:00
Oliver Burn f8459eb674 Refactoring after re-reading the code 2002-12-07 12:16:10 +00:00
Rick Giles 730ade67d5 changed to regular expressions for @author and @version tags
- thanks to Lars for suggestion
2002-12-07 12:02:32 +00:00
Oliver Burn a0054eede0 Removed unused code now that we have validation
against a DTD.
2002-12-07 11:50:12 +00:00
Oliver Burn 9f6a98ac72 Added a flag - something needs to be done about
dependencies
2002-12-07 11:12:47 +00:00
Oliver Burn 12231e14b8 Changed the loading of package names to use the new
technique used by the configuration loader. So this means
that all the XML files are now validated against a DTD.
2002-12-07 09:51:33 +00:00
Lars Kühne f16dd37dba fixed NPE, Class.getPackage() sometimes return null - use String operations instead 2002-12-07 09:40:58 +00:00
Oliver Burn 09dde6e471 Abstracted out the XML error handling policy. 2002-12-07 09:30:44 +00:00
Oliver Burn 2386d3e852 Implemented proper error handling for parse errors. 2002-12-07 07:09:13 +00:00
Oliver Burn d451459484 Remove dead code 2002-12-07 03:29:29 +00:00
Oliver Burn 52fa475168 Changed to make the XML be validated using the DTD. The
DTD is located using a technique that gets it from the JAR
file. Idea "borrowed" from Struts.
2002-12-07 03:28:36 +00:00
Rick Giles 6580a8e40e minor comment correction 2002-12-06 19:25:11 +00:00
Rick Giles 3088559eda start on real DTD incorporation 2002-12-06 16:15:08 +00:00
Rick Giles 2e0c946e06 minor Javadoc correction 2002-12-06 14:04:28 +00:00
Rick Giles 118b4451d1 updated to current set of test cases 2002-12-06 14:04:04 +00:00
Oliver Burn 53e4d78c19 Fix some more checkstyle errors. Big thanks Rick for doing the others. 2002-12-06 13:40:11 +00:00
Rick Giles 6b55f0fc42 refactoring. If it gets like a bean and sets like a bean, then it is a bean. 2002-12-06 12:59:25 +00:00
Rick Giles 9dfb4e0f6b removed dead code. 2002-12-06 12:41:35 +00:00
Rick Giles 256220f857 corrected checkstyle errors. removed dead code. 2002-12-06 11:24:21 +00:00
Rick Giles 419d924386 corrected checkstyle errors 2002-12-06 11:23:46 +00:00
Rick Giles 3020319895 corrected checkstyle errors 2002-12-06 10:38:08 +00:00
Oliver Burn cf5946b2ce Now all the tests run again! Now we need to fix all the
Checkstyle errors in the newly added source code.
2002-12-06 06:39:14 +00:00
Oliver Burn 5b90aaa412 Start of investigation into getting the unit tests to run. 2002-12-06 06:31:51 +00:00
Oliver Burn 4d769d48f1 Fixed up all the class loader issues that were preventing
Checkstyle running via ANT.
2002-12-06 05:29:34 +00:00
Oliver Burn d38ddaad92 Found it - was looking for this file 2002-12-06 04:07:07 +00:00
Oliver Burn 90ab42cdc7 Small refactoring 2002-12-06 03:52:36 +00:00
Oliver Burn fed8d5b5e8 Cleaned up the imports 2002-12-06 03:50:54 +00:00
Rick Giles d056b3b6bb error message correction 2002-12-06 00:46:14 +00:00
Rick Giles eb68cde2e3 Correct Javadoc 2002-12-06 00:38:26 +00:00
Oliver Burn 64daa21b1c Cosmetic changes - but unable to run the tests to see if I
broke anything. :-(
2002-12-06 00:31:34 +00:00
Rick Giles 5ce7d2562f Improved exception message for the case that a registering
Check has an invalid token.
2002-12-06 00:10:45 +00:00
Rick Giles bd2731070a Hacked replacement class for StringArrayConverter so that it
properly converts an array of tokens with an element
containing an underscore :(
2002-12-05 23:47:41 +00:00
Rick Giles 06f9b6d255 removed unnecessary imports and made mPackageNames private with
accessor method.
2002-12-05 20:57:37 +00:00
Rick Giles 16ba5b35f9 modified for config XML and mapping names to full class names - see
posting to checkstyle-devel@lists.sourceforge.net
2002-12-05 18:54:28 +00:00
Rick Giles 686afc521a modified for config XML 2002-12-05 18:50:13 +00:00
Rick Giles 440cf6836f test inputs for ConfigurationLoaderTest 2002-12-05 18:48:37 +00:00