Commit Graph

42 Commits

Author SHA1 Message Date
Rick Giles 916417fc62 Check for policy of space at an empty for interator.
Addresses requests 565666, 583725.
ParenPad and WhitespaceAfter no longer check an empty for iterator.
Not doing so, and using check EmptyForIterator, is less complex than
providing properties for ParenPad and WhitespaceAfter.
2003-01-11 20:17:02 +00:00
Lars Kühne 2440fa45b2 removed PublicMemberNameCheck, check public members with MemberNameCheck
updated docs to reflect that change
2002-12-30 14:58:12 +00:00
Lars Kühne 5ce6ad4df6 ModifierCheck to ModifierOrderCheck 2002-12-29 08:46:55 +00:00
Lars Kühne 58ce4c4097 fixed bug #648708, Misleading doc for checkUnusedThrows
Renamed property checkUnusedThrows to allowUndeclaredRTE to better reflect the meaning of the property.
2002-12-27 09:31:33 +00:00
Rick Giles 58af01acc8 moved property tabWidth 2002-12-25 12:05:32 +00:00
Rick Giles f1d485ff49 configure for LeftCurly 2002-12-19 11:01:13 +00:00
Rick Giles 3411c89f4c Removed redundant configuration 2002-12-18 16:17:50 +00:00
Rick Giles 4564aecb5c Changed configuration XML element "config" to "module".
Dropped suffix "Check" in Check configurations.
2002-12-16 00:22:14 +00:00
Rick Giles b25fe8281b restore original LineLengthCheck ignorePattern property 2002-12-12 11:39:05 +00:00
Oliver Burn 12acba75f4 hopefully fix problems people have been having with encoding 2002-12-12 02:22:05 +00:00
Rick Giles 9dd70608be ignorePattern "^ *\* *[^ ]+$" is too restrictive.
Is there a better one?
2002-12-11 00:44:32 +00:00
Oliver Burn 8dd310c982 Changes to get the header check going again. I like the
change that was made for the properties, it leverages
off the work we did in the 2.4 release to allow properties
to be overriden in the ANT file.
It is now possible to run the checkstyle task from any
directory - nothing is now location specific. This includes
the location of the header file or the DTDs. Good to
finally reach this milestone.
2002-12-07 12:18:57 +00:00
Rick Giles 730ade67d5 changed to regular expressions for @author and @version tags
- thanks to Lars for suggestion
2002-12-07 12:02:32 +00:00
Oliver Burn 2386d3e852 Implemented proper error handling for parse errors. 2002-12-07 07:09:13 +00:00
Oliver Burn 52fa475168 Changed to make the XML be validated using the DTD. The
DTD is located using a technique that gets it from the JAR
file. Idea "borrowed" from Struts.
2002-12-07 03:28:36 +00:00
Oliver Burn d287d70b77 Cool! Used the ignoreFormat property to fix up checkstyle errors. Very nice. 2002-12-06 23:56:37 +00:00
Rick Giles 3088559eda start on real DTD incorporation 2002-12-06 16:15:08 +00:00
Rick Giles 88f46c600c start on real DTD incorporation 2002-12-06 16:04:58 +00:00
Oliver Burn 1b7dd85b3f Finish the conversion job. 2002-12-06 06:31:06 +00:00
Rick Giles 5f0d69b64d included OperatorWrapCheck with assignment tokens, now that
BeanUtils conversion of String arrays has been remedied.
2002-12-05 23:51:20 +00:00
Rick Giles 16ba5b35f9 modified for config XML and mapping names to full class names - see
posting to checkstyle-devel@lists.sourceforge.net
2002-12-05 18:54:28 +00:00
Oliver Burn a9d73e7c59 Commented out the header check 2002-11-26 06:04:45 +00:00
Oliver Burn 3e5b819aa9 Added a parameter to the HeaderCheck to actually
specify a file. Unfortunately this is relative and hence can
only be used from the root directory. Will uncomment in
a minute.
2002-11-26 05:58:22 +00:00
Oliver Burn bed61e1afd Fix indentation 2002-11-25 00:42:52 +00:00
Oliver Burn 91aa657832 putting back the checkstyle settings back and now getting 67 odd errors. :-( 2002-11-22 12:37:00 +00:00
Rick Giles cf7e4c19e3 renamed XML element "set-property" to "property" 2002-11-18 10:03:05 +00:00
Rick Giles 3c0608f33a Wrapped GlobalProperties and CheckConfiguration[] into a Configuration
class. TODO: Integrate with CheckStyleTask
2002-11-15 18:18:52 +00:00
Rick Giles 4a638fc0e6 Added global-property to DTD.
Removed DTD from XML file until fix of ConfigurationLoader
2002-11-14 10:10:27 +00:00
Rick Giles 6f36f2811d added DTD for checkstyle configuration 2002-11-12 23:20:51 +00:00
Rick Giles 7fb81fdf90 added WhitespaceAfterCheck 2002-11-11 11:54:06 +00:00
Rick Giles 9eb9d9b3ea replaced NoWhiteSpaceAroundCheck by NoWhitespaceAfterCheck and
NoWhitespaceBeforeCheck
2002-11-10 20:48:33 +00:00
Rick Giles bed446244a added NoWhitespaceBefore, NoWhitespaceAfter checks 2002-11-10 20:35:13 +00:00
Rick Giles 333e944de5 added check for wrap of assignment operators at eol 2002-11-10 19:45:25 +00:00
Rick Giles ecaaaeb254 added operator wrap check 2002-11-09 20:24:22 +00:00
Oliver Burn 5fc3ff2bfb Please ensure you thoroughly test code before committing it. As a sanity test,
ensure that the target "checkstyle.checkstyle" will run! If in doubt, do not
commit, but instead said a patch to the devel mailing list for a review.

Finished the port of the ClassResolver code. Even though it compiled, it had
no chance of working due to class casting problems. They have not been
fixed. Also needed to ensure the correct class loader is being used.
2002-11-06 03:57:58 +00:00
Oliver Burn 93bba09f70 Wanting to turn on the check - but it fails. Need to resolve as it is most
likely to be a classpath issue.
2002-11-06 00:14:40 +00:00
Rick Giles 3bcc2c1391 update for JavadocMethodCheck 2002-11-05 20:39:56 +00:00
Oliver Burn fb97056b9b Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
abstract methods.
2002-11-03 12:06:15 +00:00
Oliver Burn 4945b82e6d Folded the constructor length test into the method length check. Seems silly
to have them as separate checks.
2002-11-03 02:37:20 +00:00
Oliver Burn ba8a851e90 Fixed bug in MethodLengthCheck where it was assuming that a method definition
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
Oliver Burn 3288a81e30 Just converted over the Checkstyle ANT task to use the new framework. In
process I had to fix numerous errors now being reported.

There are some bugs with the method checks, which I will now investigate.
2002-11-02 12:22:14 +00:00
Oliver Burn 2effcfd0bc Start of conversion to only supporting the new framework. Also refactored
error handling.
2002-10-31 12:28:47 +00:00