Commit Graph

75 Commits

Author SHA1 Message Date
Lars Kühne c617457933 Implementation for RFEs 466756, 500378, 504964, 510441
Details:

466756 - Check for package.html:
 - new parameter requirePackageHtml, default is false

500378 - Check names of methods + local variables
 - new parameters methodPattern and localVarPattern,
   default is ^[a-z][a-zA-Z0-9]*$

504964 - no default access
510441 - allowprotect should incl. packageprivate (requests the same feature)
 - new parameter allowPackage, default is false

Sorry that I did not split this into separate patches, I had this in
my local tree as is and it would require too much work to split it.  I
think the changes are easy enough to review three feature
implementations in one go.
2002-02-05 20:22:02 +00:00
Oliver Burn b779f3c1da Updated to the LGPL and version 2.0. 2002-02-04 12:44:04 +00:00
Oliver Burn a5abed5101 Changed direct reference to getProject() 2002-01-28 22:15:08 +00:00
Lars Kühne 8e6328559e fix bug #508010, documentation and code are inconsistent 2002-01-24 18:34:47 +00:00
Oliver Burn 2b6c9c654a Added warning not to use this class outside of this package. 2002-01-23 12:42:01 +00:00
Oliver Burn 15c7162ea4 Refactored Checker to not take a PrintStream. All errors are not logged to
standard output.
2002-01-23 12:28:49 +00:00
Lars Kühne 45120a140e must be public, used as param in public method of Configuration 2002-01-22 05:23:25 +00:00
Oliver Burn f755213c9e tightened the scope 2002-01-22 01:05:22 +00:00
Oliver Burn d4e7792f24 Made public so can be used outside the package 2002-01-21 11:54:27 +00:00
Lars Kühne 2fdc69f6a9 include author email address, make class package visible instead of public 2002-01-20 08:49:03 +00:00
Lars Kühne 5a9a68e619 removed hashmarks from @see tags, they resulted in errors during javadoc generation 2002-01-20 08:27:55 +00:00
Oliver Burn f0d7921279 Added a default constructor to XMLLogger so it can be used by the ANT task.
Also updated build.xml to use the plain logger.
2002-01-15 23:51:49 +00:00
Oliver Burn 2727473656 Changed the defaults for member/static/parameter regexps to match the Sun coding
standard. The intent of this change is to make it easier for people to use
checkstyle out-of-the-box to check the Sun coding standard.
2002-01-15 12:54:03 +00:00
Lars Kühne d7de3bef0b Added tests to WS around DIV and MOD. All multiplicative expressions are now covered. 2002-01-15 06:04:46 +00:00
Oliver Burn 3af1c99a0c Removed support for assert keyword. It breaks the parser on legal java
prior to JDK 1.4.
2002-01-14 05:07:22 +00:00
Oliver Burn cb0fdf5428 Fixed a bug with JavaDoc checking in class/instance initialisers. 2002-01-14 04:33:15 +00:00
Oliver Burn 8d6fa332a9 Re-factored VerifierImpl to be called Verifier. The original intention of
the interface was to allow different verifiers to be swapped in. Considering
how much work would be required to create a verifier from scratch, people
are more likely to just want to extend VerifierImpl.
2002-01-14 02:56:15 +00:00
Oliver Burn f8ea4c69a2 Removed all evidence of the java.tree.g file. 2002-01-14 01:33:42 +00:00
Oliver Burn 1104baffa4 Moved the final tests out of java.tree.g. Yahoo! 2002-01-14 01:18:50 +00:00
Oliver Burn 5ab5020a27 Moved all the checking for {}'s into java.g. 2002-01-14 00:26:43 +00:00
Oliver Burn 8d1cba0676 Moved more tests into java.g and improved some tests. 2002-01-13 07:52:23 +00:00
Oliver Burn 3335cdeb4d Moved the reference checking to java.g 2002-01-13 06:34:38 +00:00
Oliver Burn a54d892da1 removed unused method reportIdentifier() 2002-01-13 05:02:06 +00:00
Oliver Burn 1c35230164 large refactoring of moving checking into java.g (from java.tree.g). Solved
all the hard problems - only some easy checks to migrate
2002-01-11 23:58:08 +00:00
Oliver Burn bd7cfcb3e5 Refactoring: removed unused methods reportStartMethodBlock() and
reportEndMethodBlock()
2002-01-11 13:45:54 +00:00
Oliver Burn 171df8e6e1 added a toString() method to help debugging 2002-01-11 13:42:55 +00:00
Oliver Burn b7157a9946 moved with tests into java.g 2002-01-11 12:26:23 +00:00
Oliver Burn 16d7e573b0 Moved the checking for ws around "if"s to java.g. Also refactored
calls to verifyWSAfterEnd() to use verifyWSAfterBegin() where
appropriate.
2002-01-11 11:56:55 +00:00
Oliver Burn 3188792cad Now have two methods for checking if ws around some text. One takes the column
where the text starts, and the other where the text ends. Needed because the
parser is different places either gives the start or the end.
2002-01-11 11:49:57 +00:00
Oliver Burn e3c3cdcea3 tightened up checking the STAR in multiplicativeExpression. Possible source of
a NPE reported by Lars.
2002-01-11 10:47:02 +00:00
Oliver Burn d16d3f310d <ignore>removed trailing whitespace</ignore> 2002-01-11 10:46:03 +00:00
Lars Kühne 75e9d8486e support jdk 1.4 assert statements, rfe 500122 2002-01-10 06:18:41 +00:00
Oliver Burn 047f8cef4b Started migrating the whitespace tests from java.tree.g to java.g 2002-01-09 15:06:03 +00:00
Oliver Burn 0b7bf27706 Now support ignoring whether whitespace is after a type cast. As requested by
Lars.
2002-01-08 04:18:02 +00:00
Lars Kühne c8756ab481 fix bug 499072, inner classes require author tag 2002-01-06 15:27:44 +00:00
Lars Kühne 9982fc546a javadoc checkscope tests 2002-01-06 12:53:48 +00:00
Lars Kühne 17d3b314bb javadoc checkscope implementation 2002-01-06 12:48:59 +00:00
Oliver Burn 7d82fd670a Added support to check that commas ';' in "for" statements are followed by
whitespace (ala the Sun coding standard).
2002-01-06 11:06:07 +00:00
Oliver Burn b7f1d0d1b7 Added support to check that commas ',' are followed by whitespace (ala the Sun
coding standard). This mainly involved refactoring the code I just wrote for
checking casts.
2002-01-06 10:31:32 +00:00
Oliver Burn edf2c95634 Made Checker & Configuration public so they can be used outside the package.
A requested feature to that Checkstyle can be integrated into IDE's like
NetBeans, JBuilder.
2002-01-06 07:40:36 +00:00
Oliver Burn d87ea06ebb Added support for checking the file length does not exceed a specified max. 2002-01-06 07:08:20 +00:00
Oliver Burn 637bf620e5 Support testing for the max method and constructor lengths 2002-01-06 06:40:19 +00:00
Oliver Burn 0957b67c1d Support setting the max method and constructor lengths 2002-01-06 06:30:29 +00:00
Oliver Burn efcb63fd74 Added support to check that casts are followed by whitespace, as recommended
in the Sun coding standard. Can be turned off with all other whitespace checks.
May want to specifically be able to turn off this feature.
2002-01-05 13:18:22 +00:00
Oliver Burn ad29236445 Included patch to check for whitespace around return statements. 2001-12-11 06:34:45 +00:00
Oliver Burn 518c2079d0 fixed (maybe?) a parse error 2001-12-10 02:22:25 +00:00
Oliver Burn 4fade39e72 patch for ignoring whitespace between Javadoc and declarations 2001-12-03 00:42:42 +00:00
Oliver Burn 82de45f06f Incorporate changes made to the ANTLR Java grammar 2001-11-26 12:25:45 +00:00
Oliver Burn 9a905be3a0 patch for checking more whitespace 2001-11-26 11:25:21 +00:00
Oliver Burn 7b4b37602e improved the tests 2001-11-03 10:40:15 +00:00