aede54ee77
Fully implemented the paren pad check
2002-10-13 14:05:42 +00:00
5fd3fab179
Stopped the tokens LPAREN and RPAREN being silently eaten by the grammar. Now
...
need to implement the ParenPad check. Should be easy.
Also need to refactor some the existing tests to use utility methods for
locating tokens in the tree. Currently hard code the positions, which is not
ideal.
2002-10-13 13:31:42 +00:00
5e1da0a269
Moved location of LeftCurlyOption
2002-10-13 12:53:21 +00:00
8083866f72
Removed unused options.
2002-10-13 12:46:33 +00:00
1bba9f0056
removed old implementation of Other Left Curly Check
2002-10-13 12:36:02 +00:00
21c76786c6
Implemented Other Left Curly check
2002-10-13 12:08:58 +00:00
e9faeb047f
Added the LCURLY for switch statements
2002-10-13 11:21:47 +00:00
2cca9c57c9
implemented the method left brace check
2002-10-13 11:15:29 +00:00
2213adc2bc
Pulled up common functionality
2002-10-13 10:52:03 +00:00
57d8e4b099
Implement left curly check for type definitions. Now about to implement for
...
methods to refactor the common code.
2002-10-13 10:42:15 +00:00
4927e940af
fixed imports
2002-10-13 04:28:09 +00:00
b1cfd257eb
Major refactor to implement the RightCurly check. Required the ANTLR grammar
...
to be worked to:
- Not silently eat tokens (more to be done)
- Not get the token tree out of order for try/finally
2002-10-07 09:17:16 +00:00
51941dcf24
added TreeViewer to help with development.
2002-10-06 23:52:34 +00:00
7a603d5fa8
finally managed to tell beanutils what I want, checks now have their 'natural' api
2002-10-06 13:21:27 +00:00
e20d45697c
finally managed to tell beanutils what I want, checks now have their 'natural' api
2002-10-06 13:14:16 +00:00
1efd41aa92
cleanup after port of illegal instantiations
2002-10-01 21:07:42 +00:00
eb7b7bfd3e
Major refactoring to support correct column numbers. Also removed all the old
...
code for whitespace checking around things. This required fixing the grammar
to not consume COLON tokens. Looks like you are onto something Lars with your
previous email (made it easy to find the bug).
2002-10-01 08:47:26 +00:00
81dab0c141
included the new patterns suggested by Vijay R. Aravamudhan
2002-10-01 05:14:05 +00:00
ce175a83d8
ported the illegal instantiations check
...
still need to remove the old code
2002-09-29 19:43:38 +00:00
65d3c9814b
removed unused private methods
2002-09-29 14:46:36 +00:00
6d191d438b
completed port of modifier order check, removed old code
2002-09-29 14:28:10 +00:00
553a1aec9f
removed redundant modifier checks from old code
2002-09-29 14:16:38 +00:00
021d6344b6
ups..., removing local test code
2002-09-29 14:08:13 +00:00
d7c1da9a93
removed tab check and file length check from old code
2002-09-29 14:04:36 +00:00
f7b0ed0a76
added test for tab character check
2002-09-29 13:46:35 +00:00
a7c5f33141
Added test for FileLengthCheck
2002-09-29 12:58:27 +00:00
031bc6f277
fixed style problem (package visible member)
2002-09-29 09:37:10 +00:00
18d65a1993
Moved across all the import checks
2002-09-29 05:55:02 +00:00
84c1f8375f
Clean up of import checks - removed old code
2002-09-29 05:19:13 +00:00
aa5dbacdcb
Moved across nearly all the unit tests, just the illegal import to go
2002-09-29 05:01:34 +00:00
11fad553fd
added TODO comment about incomplete port
2002-09-28 21:05:13 +00:00
4b209708c6
ported FileLengthCheck and TabCharacterCheck, tests still missing
2002-09-28 20:55:43 +00:00
4f6596703f
removed all traces of header checks in old impl and tests
2002-09-28 19:37:02 +00:00
f24c8ee834
implemented header checks, still need to remove old code
2002-09-28 19:09:34 +00:00
c2afeecbf7
remove debug output
2002-09-28 17:48:22 +00:00
d28a2aa39e
Call the lifecycle methods (beginTree, ...) of a
...
Check even if the Check does not visit any tokens.
This is required for Checks that do not operate on
the parse tree, e.g. the Header Checks
2002-09-28 17:46:48 +00:00
f8ca7fdb34
make class abstract so IDEA's JUnit integration knows that this is not a test to be run
2002-09-28 16:38:36 +00:00
f32694566e
Removed the old implementation of the package name check.
2002-09-27 07:20:00 +00:00
d077a402da
Added a lot more checks for name format. Also endeavouring to get Checkstyle
...
passing Javadoc again before it gets out of control.
2002-09-27 06:41:28 +00:00
d7142fd15f
Implemented the parameter name check. Oh so easy. :-)
2002-09-25 13:43:06 +00:00
03c8a0a7ee
Refactoring the way the Checker is configured. Not happy with the current
...
approach - it was hack. Changing to be that the Configuration will eventually
contain the CheckConfiguration objects.
Also adding support setting the properties on created checks. I am adding this
using the Jakarta Commons library as it makes it very easy.
Oh - I am now back online - no thanks to Sprint blocking my ISP for a couple
of days. I may have lost a couple of emails. :-(
2002-09-25 12:24:50 +00:00
9fdee8a722
Started converting the header check.
...
Oliver, this checkin is mainly to keep you informed what I am doing so
that we avoid duplicate work. Please email me once your ISP starts working
again (do you have an alternate email address or a webmail account?)
2002-09-25 05:35:21 +00:00
563f76592d
Moved across the check for upper case ell
2002-09-24 11:46:34 +00:00
e77f0c5c6e
cleaned up some imports
2002-09-24 11:11:17 +00:00
49b2c72373
Refactored the tests to only use the Checker interface
2002-09-24 07:06:25 +00:00
e3134ab9b1
added reminder
2002-09-24 06:47:35 +00:00
b84b3fd04a
Implemented a new version of Checker for that uses the Checks. The intent is
...
to be able reuse the existing checker.
OT: Due to ISP problems, I am unable to receive email at the moment.
2002-09-24 06:34:11 +00:00
fe6e0fd423
changed param name to match checkstyle naming rules
2002-09-23 05:57:48 +00:00
85db5df9c1
check for redundant modifier
2002-09-23 05:56:05 +00:00
daf94e4e8e
WhitespaceAround PLUS and MINUS
2002-09-22 14:00:32 +00:00
Oliver Burn
Lars Kühne