b671e6bb1c
Removed some duplicate code, as I also feel the pain. I like the patch, but
...
I question using the Java14 lexer/recognizer first. Is this because most of
the time it will succeed (especially with 1.4 source:-). Be great if a
comment could be added to the code.
2002-03-14 10:20:46 +00:00
e2ec464f27
added support for jdk 1.4 assert statements
...
grammar changes inspired by John Pybus on the antlr-interest mailing list,
see http://groups.yahoo.com/group/antlr-interest/message/4968
the changes to Checker.java are not very clean, but I don't see a better
solution unless the ANTLR api is improved (compilationUnit() should be an
abstract member of Parser, error reporting should be pluggable)
2002-03-14 06:19:09 +00:00
6b51ac1580
added tests for Configuration serialization
2002-03-06 06:08:00 +00:00
ec1e3e8349
fix for bug #522282 , "Cache not invalidated upon param. change"
...
- all classes that contribute to Configuration are now Serializable
- use in-memory serialization to compute a hashcode of the Configuration
- store the hashcode in the cache file
- compare cached hashcode with current hashcode and invalidate cache accordingly
2002-03-05 20:53:04 +00:00
1a596b6827
Renamed anttasks.properties to checkstyletask.properties. A much clearer name.
2002-02-25 12:15:07 +00:00
47383398f8
Implemented checking for right curly checking '}'. This was much easier that
...
for the left. Just need to do the documentation now.
2002-02-23 06:16:55 +00:00
d3af93d07b
explicitly set tab width to 1 column
...
fixes RFE #520410 (support latest ANTLR versions)
2002-02-23 00:37:53 +00:00
07a9baacf9
Remove a global variable hack.
2002-02-22 04:21:14 +00:00
59ce3f31d7
Added support for brace checking on the keywords try, catch, finally, static.
...
What are not covered deliberately are labels and instance initializers.
2002-02-22 04:12:04 +00:00
41e2089574
Added support for - for, do, else, synchronized
2002-02-22 03:37:41 +00:00
f4860ef3b4
Implemented brace checking for "if" and "while"
2002-02-22 03:11:36 +00:00
9943aefac7
Added support for setting the brace option for others + new tests. Now
...
check location of '{' on switch statements.
2002-02-21 23:37:59 +00:00
fd24216f46
Now have '{' checking for methods and types. Also put in place the logic to
...
be able to check the others.
2002-02-21 22:43:55 +00:00
c85ec6f26a
Merged the Streamable interface into the AuditListener interface. Having them
...
separate served no real purpose at the moment, except to complicate the
implementation.
2002-02-20 23:19:08 +00:00
339a7f5475
Fixed a checkstyle error
2002-02-20 23:09:01 +00:00
e10faf3315
First cut at doing left curly checking for methods. This is definitely a work
...
in progress that will change a lot as I add checking for other constructs. I
always tend to evolve to the general solution. :-)
2002-02-20 23:08:21 +00:00
1fd18cde7b
Now support setting the left curly placement option for methods. I am
...
implementing this example first, before doing it for types, statics, arrays,
anon inners, etc.
2002-02-20 02:52:27 +00:00
14d5ead27a
First cut at an options class for placement of left curly braces
2002-02-19 22:54:47 +00:00
048d0cdaf4
Changed the error reporting format for the modifier order check. In using the
...
feature, I found that it was very helpful to know which modifier to correct.
2002-02-19 22:52:49 +00:00
22885be800
Fixed checkstyle error
2002-02-19 22:39:35 +00:00
5e4b582734
Fixed the Javadoc comment. Not sure if the old style will create valid
...
output.
2002-02-18 00:37:04 +00:00
b174220a66
Made Defn public so it can be reference outside the package
2002-02-16 22:13:59 +00:00
faf76530d8
RFE #514033 , check order of modifiers (implementation, test, and documentation)
2002-02-15 06:47:51 +00:00
c9db9f82e2
Just some small refactoring
2002-02-11 05:38:09 +00:00
913028d7f2
Implementation, docs and test for RFE 438478, ignore multiple lines in header.
...
This change is compatible for command line, Ant, and API.
The API compatibility resulted in some deprecated methods in Configuration,
you can remove them if you think that API compatibility is not as
important as clean code.
2002-02-10 18:29:10 +00:00
db84febeb5
Update the tests and documentation for checking whitespace around periods.
...
#493383
2002-02-09 13:18:30 +00:00
241c48750b
Added a method to verify that a dot is correctly surrounded by whitespace.
2002-02-09 12:00:32 +00:00
7fa84f981c
Made Checkstyle more "ant friendly" but having a anttasks.properties file.
...
This allows declaritions of the taskdef in ant 1.4+ as:
<taskdef resource="anttasks.properties">
<classpath refid="run.classpath"/>
</taskdef>
Also, in a moment of madness, I re-indented the build.xml file to 4 spaces.
2002-02-09 11:03:56 +00:00
a1dda4f264
Reordered the logic for ignoring lines.
2002-02-08 00:42:21 +00:00
1ca4d43ce8
<picky>Made mConfig final</picky>
2002-02-08 00:35:39 +00:00
c7e7af8f7d
added test for new feature 'headerfile regular expression support', rfe #499259
...
moved creation of Configuration to setUp() to ensure that
each test is run with a well known Configuration that is not
influenced by other tests.
2002-02-07 20:39:51 +00:00
6fc674d4bf
new feature 'headerfile regular expression support, rfe #499259'
2002-02-07 20:34:11 +00:00
fdd9ae8297
Incorporate patch from Andrew Lang to support having javadoc with the format:
...
/**
* @param aTwo
* This is a multiline piece of javadoc
**/
Also changes the wording of "is not proceeded with whitespace" to
"is not followed by whitespace". This makes things a tad clearer.
2002-02-07 05:25:30 +00:00
d4f1261a61
Refactored the MethodSignature class to contain all the information. Also added
...
helper methods.
2002-02-06 23:15:05 +00:00
ea01eaaa85
Just tweaked the style a bit to be consistent with else where. I kept the
...
braces on a new line though. ;-)
2002-02-06 21:55:08 +00:00
6df3e84393
Changed a comment to C++ style
2002-02-06 05:49:22 +00:00
9be48298c3
Fixed checkstyle errors
2002-02-06 05:37:26 +00:00
46667e3599
Added tests for allowProtected (old feature without tests), allowPackage, requirePackageHtml, methodPattern, localVarPattern
2002-02-05 20:40:50 +00:00
c617457933
Implementation for RFEs 466756, 500378, 504964, 510441
...
Details:
466756 - Check for package.html:
- new parameter requirePackageHtml, default is false
500378 - Check names of methods + local variables
- new parameters methodPattern and localVarPattern,
default is ^[a-z][a-zA-Z0-9]*$
504964 - no default access
510441 - allowprotect should incl. packageprivate (requests the same feature)
- new parameter allowPackage, default is false
Sorry that I did not split this into separate patches, I had this in
my local tree as is and it would require too much work to split it. I
think the changes are easy enough to review three feature
implementations in one go.
2002-02-05 20:22:02 +00:00
b779f3c1da
Updated to the LGPL and version 2.0.
2002-02-04 12:44:04 +00:00
a5abed5101
Changed direct reference to getProject()
2002-01-28 22:15:08 +00:00
8e6328559e
fix bug #508010 , documentation and code are inconsistent
2002-01-24 18:34:47 +00:00
2b6c9c654a
Added warning not to use this class outside of this package.
2002-01-23 12:42:01 +00:00
15c7162ea4
Refactored Checker to not take a PrintStream. All errors are not logged to
...
standard output.
2002-01-23 12:28:49 +00:00
45120a140e
must be public, used as param in public method of Configuration
2002-01-22 05:23:25 +00:00
f755213c9e
tightened the scope
2002-01-22 01:05:22 +00:00
d4e7792f24
Made public so can be used outside the package
2002-01-21 11:54:27 +00:00
2fdc69f6a9
include author email address, make class package visible instead of public
2002-01-20 08:49:03 +00:00
5a9a68e619
removed hashmarks from @see tags, they resulted in errors during javadoc generation
2002-01-20 08:27:55 +00:00
f0d7921279
Added a default constructor to XMLLogger so it can be used by the ANT task.
...
Also updated build.xml to use the plain logger.
2002-01-15 23:51:49 +00:00
Oliver Burn
Lars Kühne