Commit Graph

2592 Commits

Author SHA1 Message Date
Michal Kordas ca1c33e311 Clean up open streams, issue #778
All violations of Fildbugs rule [OBL: Method may fail to clean up stream or resource](http://findbugs.sourceforge.net/bugDescriptions.html#OBL_UNSATISFIED_OBLIGATION) are fixed.
2015-03-15 15:17:43 -07:00
Michal Kordas a135b0952a Fix non-compiling input for CustomImportOrder check
There are no classes directly under `com.google.common` package - such import was illegal.
2015-03-15 15:11:38 -07:00
Michal Kordas a281cc95c4 Capitalize names of pages in Extending Checkstyle section on website 2015-03-15 15:10:06 -07:00
Michal Kordas 08ede2c529 Fix letter casing of IntelliJ on website 2015-03-15 15:10:06 -07:00
Michal Kordas bf235506eb Remove unused private field, issue #744
All violations of PMD rule [UnusedPrivateField](http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/unusedcode.html#UnusedPrivateField) are fixed.
2015-03-15 15:07:02 -07:00
alexkravin 1c15b6a36b Moved all methods from checkstyle.api.utils to checkstyle.utils, issue #661 2015-03-15 14:22:16 -07:00
Michal Kordas 9c4cd707e3 Add test to verify that all checks are present on website, issue #783 2015-03-15 14:17:03 -07:00
Michał Kordas e48d403d10 Remove element name from selector in CSS
Fix according to CSSLint [Disallow overqualified elements](https://github.com/CSSLint/csslint/wiki/Disallow-overqualified-elements) rule.
2015-03-15 13:54:58 -07:00
Michał Kordas 3c9a593570 Remove units for zero values in CSS
Fix according to CSSLint [Disallow units for zero values](https://github.com/CSSLint/csslint/wiki/Disallow-units-for-zero-values) rule.
2015-03-15 13:54:07 -07:00
alexkravin ca3ffb73ab Added support of logging severity for all audit events, issue #67 2015-03-14 23:32:11 -07:00
Michal Kordas e6776af1f3 Declare comparator class as Serializable to fix Findbugs violation, issue #778
All violations of Fildbugs rule [Se: Comparator doesn't implement Serializable](http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE) are fixed.
2015-03-14 22:42:12 -07:00
Michal Kordas 63f81cc0f1 Add OverloadMethodsDeclarationOrder to Available Checks page, issue #784 2015-03-14 17:17:29 -07:00
Roman Ivanov 49ec106b53 google+ was created 2015-03-14 17:03:22 -07:00
Michal Kordas 95cb607909 Make inner classes static when possible, issue #778
All violations of Fildbugs rule [SIC: Should be a static inner class](http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC) are fixed.
2015-03-14 15:23:02 -07:00
Michal Kordas 5a96ddf4c9 Fix not working link to Netbeans page, issue #751 2015-03-14 14:58:51 -07:00
Michal Kordas ebf13c373e Remove unused private method, issue #744
All violations of PMD rule [UnusedPrivateMethod](http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/unusedcode.html#UnusedPrivateMethod) are fixed.
2015-03-14 14:57:21 -07:00
Michal Kordas 98a9266a80 Combine nested if statements, issue #744
All violations of PMD rule [CollapsibleIfStatements](http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/basic.html#CollapsibleIfStatements) are fixed.
2015-03-14 14:56:19 -07:00
Roman Ivanov ccaa2811d0 minor changes for index.html 2015-03-13 20:12:29 -04:00
Roman Ivanov 8ef8813243 logo64 was updated for web site header, #649 2015-03-13 20:08:22 -04:00
Roman Ivanov 091531c3fc first version of header for web site, #649 2015-03-13 19:49:32 -04:00
Roman Ivanov 07a7c54d95 fix for linkcheck violation, depth-first algorithm link 2015-03-13 10:51:46 -07:00
alexkravin fe6158d410 Final Local Variable Check, extended acceptable tokens 2015-03-13 00:07:16 +04:00
alexkravin 2adf091447 Fixed problem with links in contributing.html 2015-03-12 11:55:01 -07:00
Bhavik Patel bca42a91b4 Coverage Improvement on FinalLocalVariableCheck 2015-03-12 23:23:40 +05:30
Michal Kordas 44e274bfba Remove unnecessary semicolons to fix PMD violations, issue #744
All violations of rule [EmptyStatementNotInLoop](http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/empty.html#EmptyStatementNotInLoop) are fixed. Empty statements sometimes were used to trick Checkstyle to allow empty blocks. While generally empty blocks are bad practice, there are too many of them in Checkstyle code to fix them in scope of this commit. Instead, [EmplyBlock](http://checkstyle.sourceforge.net/config_blocks.html#EmptyBlock) setting was changed to allow empty block when there is comment inside it for Checkstyle codebase.
2015-03-11 15:40:55 -07:00
ychulovskyy 5f2116bd26 Updated release notes 2015-03-11 21:29:38 +01:00
Michal Kordas 1bd30555ea Remove useless parentheses to fix PMD violations, issue #744
Parentheses are considered unnecessary if the evaluation order of an expression remains unchanged if the parentheses are removed.
2015-03-10 22:36:38 +01:00
liscju b9f232ffe0 Fix bug with multiple imports, part of issue #706 2015-03-10 12:58:34 -07:00
alexkravin 2a587d5274 Extended guide for newbies, issue #606 2015-03-10 08:33:59 -07:00
Michal Kordas 8019f1f4b7 Fix typo in violation message of ModifierOrder check, issue #740 2015-03-10 08:04:28 -07:00
Michal Kordas dc146b088b Remove block marker comments from code 2015-03-10 07:47:19 -07:00
Michal Kordas 89005ddf6d Replace calls to equals() on enums with identity comparison
This replacement is safe because two enum constants are equal only when they have the same identity.
2015-03-10 07:46:22 -07:00
Michal Kordas fde9678a2f Fix invalid link in release notes for Checkstyle 6.3, issue #730 2015-03-09 23:31:37 -07:00
Michal Kordas 5746547b11 Fix reference to JLS in PackageAnnotation docs, issue #674 2015-03-09 23:27:47 -07:00
Michal Kordas 49a23751eb Remove obsolete double spaces 2015-03-09 23:26:22 -07:00
Michal Kordas aef1f36b5a Fix HiddenField ignoreSetter propery not working for one letter fields, issue #730 2015-03-09 23:22:16 -07:00
Michal Kordas ba5555995f Fix code example in HiddenField docs, issue #729 2015-03-09 23:19:15 -07:00
alexkravin b436b3cd98 Need Braces Check, one-line statements option, issue #300 2015-03-07 17:23:26 -08:00
alexkravin 5f68bb50fd Visibility Modifier Check, ignore annotated fields 2015-03-07 17:14:51 -08:00
liscju 244eb9d0a9 Fix bugs with multiple fields, part of issue #706 2015-03-06 07:41:21 -08:00
Bhavik Patel 93a33df5bd fix for FinalLocalVariableCheck - FOR_EACH_CLAUSE variable is not reported. issue #20 2015-03-06 11:09:58 +05:30
Roman Ivanov cf3c535a33 final fix for, remove tag version from all javadocs, #718 2015-03-05 17:25:00 -08:00
Roman Ivanov f53116d471 This reverts commit baf08b9cf8. 2015-03-05 17:22:23 -08:00
Roman Ivanov fe607ecab5 partial fix for remove tag version from all javadocs, #718 2015-03-05 17:02:17 -08:00
Roman Ivanov baf08b9cf8 partial fix for remove tag version from all javadocs, #718 2015-03-05 16:59:47 -08:00
Roman Ivanov 397c361c3f partial fix for remove tag version from all javadocs, #718 2015-03-05 16:56:29 -08:00
Roman Ivanov 9ea39c8431 partial fix for remove tag version from all javadocs, #718 2015-03-05 16:52:57 -08:00
Roman Ivanov 9bbb2de987 partial fix for remove tag version from all javadocs, #718 2015-03-05 16:51:52 -08:00
Roman Ivanov f782869339 partial fix for remove tag version from all javadocs, #718 2015-03-05 16:47:56 -08:00
Roman Ivanov 571f0f33d5 update for documentation for path.separator , #712 2015-03-04 14:54:26 -08:00