Commit Graph

294 Commits

Author SHA1 Message Date
Oliver Burn d077a402da Added a lot more checks for name format. Also endeavouring to get Checkstyle
passing Javadoc again before it gets out of control.
2002-09-27 06:41:28 +00:00
Oliver Burn d7142fd15f Implemented the parameter name check. Oh so easy. :-) 2002-09-25 13:43:06 +00:00
Oliver Burn 03c8a0a7ee Refactoring the way the Checker is configured. Not happy with the current
approach - it was hack. Changing to be that the Configuration will eventually
contain the CheckConfiguration objects.

Also adding support setting the properties on created checks. I am adding this
using the Jakarta Commons library as it makes it very easy.

Oh - I am now back online - no thanks to Sprint blocking my ISP for a couple
of days. I may have lost a couple of emails. :-(
2002-09-25 12:24:50 +00:00
Lars Kühne 9fdee8a722 Started converting the header check.
Oliver, this checkin is mainly to keep you informed what I am doing so
that we avoid duplicate work. Please email me once your ISP starts working
again (do you have an alternate email address or a webmail account?)
2002-09-25 05:35:21 +00:00
Oliver Burn 563f76592d Moved across the check for upper case ell 2002-09-24 11:46:34 +00:00
Oliver Burn e77f0c5c6e cleaned up some imports 2002-09-24 11:11:17 +00:00
Oliver Burn 49b2c72373 Refactored the tests to only use the Checker interface 2002-09-24 07:06:25 +00:00
Oliver Burn e3134ab9b1 added reminder 2002-09-24 06:47:35 +00:00
Oliver Burn b84b3fd04a Implemented a new version of Checker for that uses the Checks. The intent is
to be able reuse the existing checker.

OT: Due to ISP problems, I am unable to receive email at the moment.
2002-09-24 06:34:11 +00:00
Lars Kühne fe6e0fd423 changed param name to match checkstyle naming rules 2002-09-23 05:57:48 +00:00
Lars Kühne 85db5df9c1 check for redundant modifier 2002-09-23 05:56:05 +00:00
Lars Kühne daf94e4e8e WhitespaceAround PLUS and MINUS 2002-09-22 14:00:32 +00:00
Lars Kühne 8313819dcb WhitespaceAround deals with 'return;' 2002-09-22 13:29:57 +00:00
Lars Kühne 0fdfc2f360 intruduced AbstractCheckTestCase to provide common functionality for
all tests for Checks

use Java14 grammar in TreeWalker to be able to parse InputWhitespace.java

improved WhitespaceAroundCheck and added test
2002-09-22 12:27:55 +00:00
Lars Kühne e4434ebe00 added new Java 1.4 grammar 2002-09-22 12:21:39 +00:00
Oliver Burn 78bc37d673 Fixed bug in Check 2002-09-21 14:04:16 +00:00
Oliver Burn 7e570084e6 Nearly for the first test to run. Having problems with loading resource
bundles.
2002-09-21 13:49:01 +00:00
Oliver Burn 03f8352479 Got the unit tests to pass again. They highlighted a bug in the recent
changes, and once again prove they are worth the effort. ;-)
2002-09-19 09:07:57 +00:00
Oliver Burn 1b7d45aed3 Got the unit test to pass 2002-09-19 08:54:43 +00:00
Oliver Burn 40c826f820 changed so that the class loader can be specified. 2002-09-19 00:34:35 +00:00
Oliver Burn 4ef220d914 fixed the problem of line/column numbers not being in the AST. 2002-09-18 23:33:17 +00:00
Oliver Burn bd79d6897e need to eventually fix the checkstyle errors 2002-09-18 23:22:51 +00:00
Lars Kühne 4880b50a3a improved resource bundle handling:
- plugins can use their own bundle (location determined automatically)
- return the message key if ResourceBundle is not available
- added log helper methods in Check.java
2002-09-18 05:08:34 +00:00
Oliver Burn 18ce1a9f66 fixed bug with handling surrounding whitespace with the Scope option. 2002-09-17 23:13:56 +00:00
Oliver Burn 672b27dd55 Moved all the Localization stuff into the api directory. The plan is reused
the localisation support in the checks.
2002-09-17 12:33:30 +00:00
Lars Kühne ffb17cde0f some javadoc and TODO comments 2002-09-16 05:08:11 +00:00
Lars Kühne 47bec440d9 initial implementation of CommentManager, calling report methods from the grammar will be next 2002-09-15 18:27:45 +00:00
Lars Kühne 1d528505f9 ... and make sure they can be compiled 2002-09-15 16:55:59 +00:00
Lars Kühne 15b4a0f888 initial checkin of check implementations 2002-09-15 16:35:37 +00:00
Oliver Burn 19257b2cdb Added the tree walker (with all the bugs hopefully marked with TODO:
comments). Currently keeping the old grammars around so we can checkstyle the
new checkstyle will old version. Kind of a version of boot strapping. :-)
2002-09-15 12:44:17 +00:00
Oliver Burn c266dfbc64 Added the new 1.3 grammar 2002-09-15 12:09:19 +00:00
Oliver Burn 5b1564d282 first cut 2002-09-15 11:46:30 +00:00
Oliver Burn 446193579f first cut 2002-09-15 11:31:55 +00:00
Oliver Burn d905adf77e the start of an interesting adventure 2002-09-15 11:07:01 +00:00
Lars Kühne 3fecb73fb3 incorporte patch 607481 from Ville Skyttä to enforce wrap on operator at EOL 2002-09-13 05:43:47 +00:00
Oliver Burn 92ea4cfb51 Backed out the BCEL based checking for unused class member variables. 2002-09-10 10:57:09 +00:00
Lars Kühne dfd870600d added test for package name
fixed TODO check (got lost during recent refactoring)
2002-09-08 12:30:56 +00:00
Lars Kühne 01d0f17ca7 Basic implementation of RFE #597787 (check package name).
Configuration, tests and docs still missing
2002-09-08 08:44:00 +00:00
Oliver Burn 9ef57a9502 Renamed to CHECK_UNUSED_FIELDS_PROP to allow for CHECK_UNUSED_METHODS_PROP in
the future. Not this release.
2002-09-08 07:50:02 +00:00
Oliver Burn 7f06106f4e Yahoo! Implemented checking for unused private fields. Just need to document
the new feature. It is off by default as the class path must be set up. Can
use the same technique for private methods.
2002-09-08 07:31:37 +00:00
Oliver Burn 49eb0e934e Yet another refactor to have the ANT task support a nested <property>
element. This let me remove the ugly have I put in to support relative
paths. Got the idea from Vincet Massol. Bug 605141.
2002-09-07 01:36:40 +00:00
Oliver Burn fdc564f6b2 Cleaned up visibility 2002-09-05 02:52:47 +00:00
Oliver Burn aff5047c9e Patch to make loading of relative file paths work. Basically duplicating the
work that ANT used to do. There had to be some pain in the refactoring. ;-)
2002-09-05 02:46:40 +00:00
Oliver Burn 2df5874fc8 Improved the error handling 2002-09-04 14:33:07 +00:00
Oliver Burn 62354b2ad9 Major refactor to make Configuration only be configured through properties 2002-09-04 13:50:23 +00:00
Oliver Burn 7335df239d Major refactor to make Configuration only be configured through properties 2002-09-04 13:38:51 +00:00
Oliver Burn 98d883bb3b Major refactor of the CheckerTest to configure using properties. 2002-09-04 13:28:53 +00:00
Oliver Burn 54948c48df Moved test inputs files to another directory so that Eclipse does not give
lots of error messages. Another reason that IDEA is nicer :-)
2002-09-02 12:09:51 +00:00
Oliver Burn 31e98a9230 Made more tolerant of an empty property for the header file. 2002-08-28 01:41:32 +00:00
Oliver Burn f45a53a37f Fixed dependance on JDK 1.4 (shame on me! :-) 2002-08-27 04:21:38 +00:00