Commit Graph

233 Commits

Author SHA1 Message Date
Michal Kordas d92c4c19ca Add more rulesets to PMD configuration, issue #744 2015-03-30 13:30:02 -07:00
Michal Kordas 26e72b35ca Disable Findbugs for 'grammars' package, issue #778
Package `com.puppycrawl.tools.checkstyle.grammars` contains only autogenerated code, so it should be excluded from Findbugs analysis.
2015-03-29 18:33:56 +02:00
Michał Kordas 9db050a5ff Update Maven Compiler Plugin to 3.3, issue #867 2015-03-28 15:24:53 -07:00
Michał Kordas 97447d9cb9 Update FindBugs Maven Plugin to 3.0.1, issue #865 2015-03-28 23:00:41 +01:00
Roman Ivanov afda7d0632 [maven-release-plugin] prepare for next development iteration 2015-03-28 11:07:24 -07:00
Roman Ivanov 983a77a3ca [maven-release-plugin] prepare release checkstyle-6.5 2015-03-28 11:07:23 -07:00
Roman Ivanov b20532ed18 pmd:check is assigned to verify phase of build, issue #744 2015-03-27 18:27:32 -04:00
Damian Szczepanik ebd4afdebe Deleted cache from Utils class + unified setters with patterns
Issue #845
2015-03-27 22:39:02 +01:00
Roman Ivanov 09ea9591e2 unused profiles are removed from POM : release, release-sign-artifacts 2015-03-26 15:47:29 -07:00
Roman Ivanov a924f59914 pmd report should always be generated even it is empty 2015-03-26 15:43:15 -07:00
Michal Kordas b771841de7 Remove deprecated getLines() methods from Utils, issue #854 2015-03-26 22:15:10 +01:00
Michal Kordas 8a24026433 Add unit tests for class base name util to improve coverage 2015-03-26 20:36:15 +01:00
Michal Kordas 06865630aa Use Guava Closeables to manage closing exceptions
>While it's not safe in the general case to ignore exceptions that are thrown when closing an I/O resource, it should generally be safe in the case of a resource that's being used only for reading, such as a Reader. Unlike with writable resources, there's no chance that a failure that occurs when closing the reader indicates a meaningful problem such as a failure to flush all bytes to the underlying resource.

`Reader` and `InputStream` instances are closed using `Closeables.closeQuietly()`, while `RandomAccessFile` is closed with `Closeables.close()` that throws `IOException` and needs to be handled.

From Javadoc:
>```java
public static void close(@Nullable
         Closeable closeable,
         boolean swallowIOException)
                  throws IOException
```
>Closes a Closeable, with control over whether an IOException may be thrown. This is primarily useful in a finally block, where a thrown exception needs to be logged but not propagated (otherwise the original exception will be lost).
If swallowIOException is true then we never throw IOException but merely log it.

>Example:
```java
   public void useStreamNicely() throws IOException {
     SomeStream stream = new SomeStream("foo");
     boolean threw = true;
     try {
       // ... code which does something with the stream ...
       threw = false;
     } finally {
       // If an exception occurs, rethrow it only if threw==false:
       Closeables.close(stream, threw);
     }
   }
```

Moreover, `Closeables.close()` and  `Flushables.flush()` are used to flush and close `OutputStream`.
2015-03-26 20:35:17 +01:00
Michal Kordas fb8c630359 Update org.apache.ant:ant-nodeps to 1.8.1, issue #790 2015-03-25 07:51:47 -07:00
Damian Szczepanik 1dacd5303b Merged catch blocks into one where possible
Pull #825
2015-03-24 14:48:26 -07:00
Michal Kordas 5b4a81a4e1 Invoke private constructors to increase coverage, issue #840 2015-03-24 06:25:58 -07:00
Michal Kordas 17a8f553a2 Update wagon-ssh to 2.8, issue #790 2015-03-24 06:20:35 -07:00
Roman Ivanov dc3111cb1a tidy plugin is disabled, as it conflicting with linkcheck plugin, issue #821 and #751 2015-03-21 23:25:02 -07:00
Michal Kordas 23e8b1b43f Disable additional invocation of site plugin, issue #821
By default property [forceSite](https://maven.apache.org/plugins/maven-linkcheck-plugin/linkcheck-mojo.html#forceSite) is `true` and Linkcheck plugin unnecessarily tries to invoke `mvn site` to freshly generate all resources needed for link checking. Not all plugins are ready to support such invocation in different context, e.g. tidy-maven-plugin. Without this additional invocation everything works fine and site generation is faster.
2015-03-21 21:47:22 -07:00
Michal Kordas fd1fb82acb Remove duplicated Linkcheck plugin declaration, issue #751 2015-03-21 21:47:22 -07:00
Damian Szczepanik 1c8180d74f Added Utils.isPatternValid method to hide try-catch blocks when parsing is used only for validation
Pull #835
2015-03-21 15:38:13 -07:00
Damian Szczepanik 91d979ef8e Reduce complexity in indentation/HandlerFactory class by grouping catch blocks
Pull #833
2015-03-21 15:35:38 -07:00
Michal Kordas 9d3d08837a Use Cobertura instead of JaCoCo for Coveralls, fixes #806
Changes done according to [coveralls-maven-plugin guide](https://github.com/trautonen/coveralls-maven-plugin#cobertura). Profile `travis` was deleted, as it is unnecessary when Cobertura is used.
2015-03-21 08:46:43 -07:00
Michał Kordas 59d1b6ad1f Update Maven Javadoc Plugin to 2.10.2, issue #816 2015-03-19 07:02:31 +01:00
Roman Ivanov b70fd02228 travis do not like connection from linkcheck, codehouse is going to die we need to wait for site plugin to remove link to it 2015-03-18 14:02:43 -07:00
Damian Szczepanik a8a721f278 Updated all links to sun.com reference to oracle site
Issue #711
2015-03-18 12:07:18 -07:00
Roman Ivanov 946d7efb30 compilation problem in Eclispe 4.4 was resolved 2015-03-18 10:56:20 -07:00
Michal Kordas bffde7e817 Introduce tidy-maven-plugin to enforce POM canonical order, issue #809
Done to enforce [POM Code Convention](http://maven.apache.org/developers/conventions/code.html#POM_Code_Convention) and fail the build on style violation.
2015-03-17 21:56:53 +01:00
Michal Kordas d9432f0d7c POM cleanup and reformatting, issue #809 2015-03-17 21:54:15 +01:00
Michal Kordas 0f4c7fd9ae Rewrite POM using canonical ordering, issue #809
Done according to [POM Code Convention](http://maven.apache.org/developers/conventions/code.html#POM_Code_Convention).
2015-03-17 09:32:12 -07:00
alexkravin 5bd22fd613 Import Order Check, added option allows alphabetical grouping order in static group, issue #12 2015-03-16 22:44:30 -07:00
Roman Ivanov 2650bf757b jacoco-maven-plugin upadted to 0.7.4.201502262128, #787 2015-03-16 22:36:47 -07:00
Michal Kordas 6bee0d1b29 Update Maven Surefire Plugin to 2.18.1 for Travis profile, issue #787
Common property with version was extracted to ensure that versions are in sync.
2015-03-16 22:34:03 -07:00
Michal Kordas 4ec8ddc405 Add maven-project-info-reports-plugin to POM, fixes issue #776 2015-03-15 14:29:24 -07:00
alexkravin 1c15b6a36b Moved all methods from checkstyle.api.utils to checkstyle.utils, issue #661 2015-03-15 14:22:16 -07:00
Michal Kordas 62969a0f9a Add JDepend to Quality reports 2015-03-15 14:10:33 -07:00
Michal Kordas 5c58de9804 Add link to Github on Project Team page, issue #742 2015-03-15 09:08:50 +01:00
Roman Ivanov efa27bbfbe fix from @mkordas (Michał Kordas), Remove duplicate cobertura-maven-plugin declaration 2015-03-14 23:13:14 -07:00
Roman Ivanov aa783dd141 cobertura config: lines with 100, were removed, as we enforce 100 for all files, regexp should contain only items bellow 100 2015-03-14 23:03:22 -07:00
Michal Kordas 2ed2408d45 Add link to Sonar to project reports 2015-03-14 22:40:43 -07:00
Roman Ivanov 5cd9806d4b founder is marked as retired 2015-03-13 20:16:12 -04:00
Roman Ivanov 2db2aaa0aa coverate is upgraded to 100 for all new files, java8 have different coverage, #722 2015-03-13 16:24:49 -04:00
Roman Ivanov 14b9681140 coverate is upgraded to 100 for all new files, #722 2015-03-13 16:04:29 -04:00
Roman Ivanov dd914fc5f3 Revert "coverate is upgraded to 100 for all new files, #722"
This reverts commit 4eb552e41e.
2015-03-12 12:50:05 -07:00
Roman Ivanov 4eb552e41e coverate is upgraded to 100 for all new files, #722 2015-03-12 11:54:37 -07:00
Bhavik Patel bca42a91b4 Coverage Improvement on FinalLocalVariableCheck 2015-03-12 23:23:40 +05:30
Bhavik Patel 852cf5fcab Automate Code Coverage Validation 2015-03-12 21:27:05 +05:30
Roman Ivanov f9519cde09 post message for announce 2015-03-11 23:37:45 -07:00
Glenn Hollingsworth ae79835b2b Issue #743, add post field for mailing list 2015-03-11 23:34:36 -07:00
Michal Kordas ec81e16015 Update Apache Ant to 1.9.4, issue #736 2015-03-11 09:47:37 -07:00