Commit Graph

261 Commits

Author SHA1 Message Date
Roman Ivanov ffd8797221 Resolved warnings during '-all.jar' generation. Issue #756 2015-04-28 14:46:35 -07:00
Roman Ivanov 2ad2c3e9ba snapshot repository was added to ease testing, updates for taglist configs and changes for links in comments 2015-04-27 16:58:00 -07:00
Roman Ivanov 018227c1c0 [maven-release-plugin] prepare for next development iteration 2015-04-26 15:47:26 -07:00
Roman Ivanov e01a55ae8f [maven-release-plugin] prepare release checkstyle-6.6 2015-04-26 15:27:21 -07:00
Roman Ivanov a0b357c760 Michał Kordas was added to prominent contributor list 2015-04-26 09:36:19 -07:00
Michal Kordas b29ca6b5f6 Fix and suppress PMD violations from ShortClassName rule, issue #982 2015-04-24 23:09:13 +02:00
Roman Ivanov e380ac8df9 fix for build failure, casued by simple moving synchronized from method to block 2015-04-23 19:55:18 -04:00
Roman Ivanov e0cff00235 weird link was removed 2015-04-22 15:47:34 -07:00
Michał Kordas aebf3b3274 Update Maven Javadoc Plugin to 2.10.3, issue #939 2015-04-17 07:17:17 +02:00
Michal Kordas f984c15b7c Move PMD configuration to separate file, issue #744 2015-04-16 12:35:24 -07:00
liscju ffde404dba Introduce new handler SynchronizedHandler for checking identation. Fixes Issue #580 2015-04-16 11:34:11 -07:00
Michal Kordas 8dbfd35435 Fix PMD violations from 'sunsecure' ruleset, issue #874 2015-04-16 07:07:41 -07:00
Michal Kordas 1c42e3eeb9 Fix PMD violations from 'strings' ruleset, issue #873 2015-04-15 17:56:07 +02:00
Roman Ivanov a1ad6dbd26 all findbugs validations are activated. final fix for issue #912 2015-04-13 17:23:30 -07:00
Michal Kordas 63b127c70d Add tests to increase coverage after changes, issue #871 2015-04-13 14:43:00 -07:00
Michal Kordas ee518dfe86 Fix PMD violations from 'logging-jakarta' ruleset, issue #871 2015-04-13 14:43:00 -07:00
Roman Ivanov efc6142fb0 fix for build problems at JavadocNodeImpl 2015-04-13 10:37:52 -07:00
Michal Kordas d9415ac10c Fix PMD violation from 'migrating' ruleset, issue #869 2015-04-10 10:21:23 -07:00
Roman Ivanov c8049f9125 cobertura-maven-plugin was revered 2.7 -> 2.6 2015-04-09 16:56:01 -07:00
Roman Ivanov 580b7ba8a2 fix accordng to detected outdated versions - https://www.versioneye.com/user/projects/55264178c4b71d7001000002#tab-dependencies 2015-04-09 16:19:44 -07:00
Michal Kordas fc0d10e8f4 Fix PMD violations from 'braces' ruleset, issue #876 2015-04-09 16:10:31 -07:00
Roman Ivanov 65e15b32db Findbugs with default configuration is enforced, some violations were added to exclude with reason in comment. Issue #778 2015-04-08 23:33:35 -07:00
Michal Kordas 95fc97c6d8 Fix PMD violations from 'typeresolution' ruleset, issue #875 2015-04-08 21:11:54 +02:00
Roman Ivanov 8f047f2ebd future plan for new validations. Issue #778 2015-04-07 15:56:05 -04:00
Roman Ivanov 0cc1f87aa5 PMD report is not empty on web site. Issue #902 2015-04-06 22:20:13 -07:00
Michal Kordas bff7a1d5af Update Apache Commons Lang to 3.4, issue #899 2015-04-06 22:54:40 +02:00
Roman Ivanov 914bf53cd0 resolving PMD issues with braces, removing dead code conditions that are impossible to test, coverage become 100% 2015-04-03 00:25:32 -07:00
Michal Kordas 3a20dbe8ed Use use Java 7 instead of custom logic for relative paths, issue #857 2015-03-31 11:25:03 -07:00
Michal Kordas d92c4c19ca Add more rulesets to PMD configuration, issue #744 2015-03-30 13:30:02 -07:00
Michal Kordas 26e72b35ca Disable Findbugs for 'grammars' package, issue #778
Package `com.puppycrawl.tools.checkstyle.grammars` contains only autogenerated code, so it should be excluded from Findbugs analysis.
2015-03-29 18:33:56 +02:00
Michał Kordas 9db050a5ff Update Maven Compiler Plugin to 3.3, issue #867 2015-03-28 15:24:53 -07:00
Michał Kordas 97447d9cb9 Update FindBugs Maven Plugin to 3.0.1, issue #865 2015-03-28 23:00:41 +01:00
Roman Ivanov afda7d0632 [maven-release-plugin] prepare for next development iteration 2015-03-28 11:07:24 -07:00
Roman Ivanov 983a77a3ca [maven-release-plugin] prepare release checkstyle-6.5 2015-03-28 11:07:23 -07:00
Roman Ivanov b20532ed18 pmd:check is assigned to verify phase of build, issue #744 2015-03-27 18:27:32 -04:00
Damian Szczepanik ebd4afdebe Deleted cache from Utils class + unified setters with patterns
Issue #845
2015-03-27 22:39:02 +01:00
Roman Ivanov 09ea9591e2 unused profiles are removed from POM : release, release-sign-artifacts 2015-03-26 15:47:29 -07:00
Roman Ivanov a924f59914 pmd report should always be generated even it is empty 2015-03-26 15:43:15 -07:00
Michal Kordas b771841de7 Remove deprecated getLines() methods from Utils, issue #854 2015-03-26 22:15:10 +01:00
Michal Kordas 8a24026433 Add unit tests for class base name util to improve coverage 2015-03-26 20:36:15 +01:00
Michal Kordas 06865630aa Use Guava Closeables to manage closing exceptions
>While it's not safe in the general case to ignore exceptions that are thrown when closing an I/O resource, it should generally be safe in the case of a resource that's being used only for reading, such as a Reader. Unlike with writable resources, there's no chance that a failure that occurs when closing the reader indicates a meaningful problem such as a failure to flush all bytes to the underlying resource.

`Reader` and `InputStream` instances are closed using `Closeables.closeQuietly()`, while `RandomAccessFile` is closed with `Closeables.close()` that throws `IOException` and needs to be handled.

From Javadoc:
>```java
public static void close(@Nullable
         Closeable closeable,
         boolean swallowIOException)
                  throws IOException
```
>Closes a Closeable, with control over whether an IOException may be thrown. This is primarily useful in a finally block, where a thrown exception needs to be logged but not propagated (otherwise the original exception will be lost).
If swallowIOException is true then we never throw IOException but merely log it.

>Example:
```java
   public void useStreamNicely() throws IOException {
     SomeStream stream = new SomeStream("foo");
     boolean threw = true;
     try {
       // ... code which does something with the stream ...
       threw = false;
     } finally {
       // If an exception occurs, rethrow it only if threw==false:
       Closeables.close(stream, threw);
     }
   }
```

Moreover, `Closeables.close()` and  `Flushables.flush()` are used to flush and close `OutputStream`.
2015-03-26 20:35:17 +01:00
Michal Kordas fb8c630359 Update org.apache.ant:ant-nodeps to 1.8.1, issue #790 2015-03-25 07:51:47 -07:00
Damian Szczepanik 1dacd5303b Merged catch blocks into one where possible
Pull #825
2015-03-24 14:48:26 -07:00
Michal Kordas 5b4a81a4e1 Invoke private constructors to increase coverage, issue #840 2015-03-24 06:25:58 -07:00
Michal Kordas 17a8f553a2 Update wagon-ssh to 2.8, issue #790 2015-03-24 06:20:35 -07:00
Roman Ivanov dc3111cb1a tidy plugin is disabled, as it conflicting with linkcheck plugin, issue #821 and #751 2015-03-21 23:25:02 -07:00
Michal Kordas 23e8b1b43f Disable additional invocation of site plugin, issue #821
By default property [forceSite](https://maven.apache.org/plugins/maven-linkcheck-plugin/linkcheck-mojo.html#forceSite) is `true` and Linkcheck plugin unnecessarily tries to invoke `mvn site` to freshly generate all resources needed for link checking. Not all plugins are ready to support such invocation in different context, e.g. tidy-maven-plugin. Without this additional invocation everything works fine and site generation is faster.
2015-03-21 21:47:22 -07:00
Michal Kordas fd1fb82acb Remove duplicated Linkcheck plugin declaration, issue #751 2015-03-21 21:47:22 -07:00
Damian Szczepanik 1c8180d74f Added Utils.isPatternValid method to hide try-catch blocks when parsing is used only for validation
Pull #835
2015-03-21 15:38:13 -07:00
Damian Szczepanik 91d979ef8e Reduce complexity in indentation/HandlerFactory class by grouping catch blocks
Pull #833
2015-03-21 15:35:38 -07:00