474e266acd
Turn off the operator wrapping test until I can provide an option to
...
turn just it off.
2002-05-28 21:50:24 +00:00
da940af362
Implementation, tests and docs for generalization of instantiation check. Users can now specify a list of classes that are not allowed to be instantiated.
...
This also fixes Bug 556317, Boolean instantiation, as now a config option is provided and the check for java.lang.Boolean is turned off by default
2002-05-28 20:23:00 +00:00
34770c3eaa
Implemented checking that lines are broken on operators (except the assignment
...
ones). Still need to update the docs
2002-05-28 13:39:43 +00:00
615219883b
Support for the CatchBlock option. The code is a bit ugly, but it works.
2002-05-26 12:58:30 +00:00
39a7271a2a
Added a toString() for debugging
2002-05-26 12:57:17 +00:00
3f6653f424
Fixed tests to handle CatchOption
2002-05-26 12:55:29 +00:00
3d0256c50f
Fixed compilation errors
2002-05-26 12:54:55 +00:00
6f7fec94ee
fixed missing javadoc
2002-05-20 10:53:23 +00:00
ef5716560b
RFE #557544 , load properties from file on cmdline
2002-05-19 07:38:58 +00:00
032b3801aa
fixed checkstyle error (empty exception handler). Do we need a framework for passing internal errors to the outside world, instead of just printing them? I'm not sure how useful printing is if you're not on the command line...
2002-05-15 05:02:46 +00:00
4425afa0c2
- #516255 , find empty exception handlers. Maybe we should add some
...
"OK if commented" option, but I don't see how to do that in the grammar.
- initial support for #550205 , find instantiations of Boolean. This is not
configurable yet, and we should generalize it to find instantiation of
arbitrary types. Docs are also still missing, will write them after
generalization.
2002-05-15 04:34:59 +00:00
7b849d58d5
Implemented a factory to create RE objects. Also improved error handling. This
...
may improve performance?
2002-05-14 04:41:16 +00:00
fca8c91804
Request 504275: detect to-do comments
2002-05-13 12:52:55 +00:00
65989e76a4
Request 555262: Include column number in the XML output
2002-05-13 01:48:41 +00:00
fea8a2b4d7
added test class for low level tests of the Utils methods
2002-05-05 11:42:39 +00:00
347badbc09
added tests for tab expansion
2002-05-05 11:40:48 +00:00
f6c9d83def
simulate tab expansion in line length and error column calculations, includes fix for bug #524671
2002-05-05 11:39:13 +00:00
83a1c2d3b3
added column number to tab check
2002-05-01 08:31:27 +00:00
ff08629ef8
save task options in Runnables to make sure that task options
...
always overwrite the options in the properties file, independent of
the order in which the attributes are reported by ANT or the XML parser.
2002-05-01 07:40:41 +00:00
8f8879df46
Fixed bug with the parser falling back when failing on assert
...
statements. Found with problems with imports.
2002-04-30 10:56:49 +00:00
43c3cc7486
Fixed bug with handling padding around ()'s.
2002-04-30 10:54:08 +00:00
4d8f0c8066
Updated to make the error for a modifier that is out of order, have the column
...
number of the offending modifier, not the first modifier.
2002-04-29 04:09:10 +00:00
2d315277b6
Fixed Checkstyle errors. Important to make sure that Checkstyle passes with no
...
errors, as I get asked if "Checkstyle Checkstyle's" all the time. :-)
2002-04-29 04:07:08 +00:00
2abb08a812
integrated patch 531230, 'add properties file functionality', provided by Warner Onstine
2002-04-28 12:52:34 +00:00
659e6ec7aa
Added more support for column numbers.
2002-04-25 12:00:11 +00:00
a1cecb5e06
Added more support for column numbers.
2002-04-25 10:36:47 +00:00
dc764f3b6a
Added column numbers for checks on variable formats.
2002-04-25 09:35:49 +00:00
3d8c8ae213
Oh the pain! Just added column numbers for checks for whitespace. Updating the
...
unit tests was not fun.
2002-04-25 09:04:42 +00:00
552b917ddb
Support column numbers for ()'s.
2002-04-25 08:06:07 +00:00
1edf43ab32
Support column numbers for {}'s.
2002-04-25 07:50:34 +00:00
4d0adc9dee
Support column numbers for method names.
2002-04-25 07:18:12 +00:00
6970485b88
Started to add support for including the column number in the output. It
...
really rocks - I wish I had done it from the start!
Strangely, although I am starting to use IDEA a lot for code development, I
still use Emacs for fixing checkstyle errors.
2002-04-25 07:03:40 +00:00
2279ec2a48
Removed a hack of using toString() on AuditEvent in the default logger.
2002-04-25 05:30:37 +00:00
3ded17ac3d
Changed support for parenthesises padding to take an option, rather that being
...
a boolean of whether to ignore or not. This will allow the adding of more
styles in the future. Good idea Lars! :-)
2002-04-24 14:36:27 +00:00
cbb5f228d8
Removed unused code.
2002-04-24 14:33:47 +00:00
083a7d432a
Added option to disable checking for padding of parenthesis. As asked for by
...
Lars. Eventually should have an option to allow different styles - rather the
current "Sun way" or the "highway.
2002-04-22 10:41:10 +00:00
6b016753d1
Fixed a copy & paste error.
2002-04-22 09:51:01 +00:00
f1dc5b5778
Trying to get into the recommended style from Sun.
2002-04-22 09:02:22 +00:00
91a4d48af7
fix for bug 540384, multiple throws tags for the same exception should be OK
2002-04-22 05:23:50 +00:00
206ff56be6
added test for rfe 537107, "public" in interface method
...
moved test input for "order of modifiers" to InputModifiers
to keep InputSimple simple
2002-04-21 21:06:42 +00:00
caf539ded2
Implementation + docs for rfe 537107, "public" in interface methods
2002-04-21 21:02:57 +00:00
e200d9bf3d
545128: implemented "-r" recursive option and improved the argument handling
2002-04-17 11:59:52 +00:00
a1de100581
Reworked the logic to give a better error reporting.
2002-04-17 11:57:32 +00:00
44950d1ee4
Fixed #544985 to handle Javadoc on variable declarations that span several lines
2002-04-17 11:56:24 +00:00
1b8483fc82
execute Checker.destroy() at the end of each test
2002-04-17 05:12:24 +00:00
d6785794bf
added trailing whitespace to enhance code coverage for Util.lengthMinusTrailingWhitespace()
2002-04-17 04:58:48 +00:00
a9f84b3767
execute Scope.getInstance() to enhance code coverage
2002-04-17 04:52:55 +00:00
e3588963d0
fixed typo in comment
2002-04-17 04:50:52 +00:00
00447a8fe3
added check for illegal imports
2002-04-17 04:43:55 +00:00
d3aa5da76d
added test for regexp-disabling of line-length checks
2002-04-13 08:33:41 +00:00
62e2b65b9e
Implementation for RFE #524650 , regexp-disable line-length checking
2002-04-13 08:30:01 +00:00
ed3e6a2428
Fixed bug where static variable checks were not taking into account the flags
...
to allow protected and package levels.
2002-04-12 12:23:14 +00:00
49314771b6
Fixed bug that allowed constant declarations to contain "__".
2002-04-07 09:16:43 +00:00
da5d8c09d2
Fixed checkstyle errors.
2002-04-04 13:48:48 +00:00
46f7cfd92a
Updated for new checks for whitespace around ()'s.
2002-04-04 13:46:44 +00:00
2b8786f133
Added checking for whitespace around ()'s. Currently checks for the format
...
of blah(p1, p2) and complains over blah( p1, p2 ).
2002-04-04 13:46:07 +00:00
0e0ca2bddf
added failureProperty to ant task (RFE 534038)
2002-03-23 17:03:15 +00:00
190c0e5ca6
Fixed bug introduced during cleanup of duplicate code:
...
Reader cannot be reused by fallback lexer, it would
never see the characters that have been consumed before
the RecognitionException in the first parsing attempt.
Also added comment why the JDK 1.4 grammar is tried first.
2002-03-19 20:26:02 +00:00
08c03a7a57
added test for grammar fallback in Checker (assert as identifier)
2002-03-19 20:19:51 +00:00
dd476d3368
fix for bug 528358, was introduced in revision 1.17
2002-03-19 19:35:09 +00:00
2a7c9dd831
added whitespace checks to assert statement
2002-03-19 06:16:22 +00:00
b671e6bb1c
Removed some duplicate code, as I also feel the pain. I like the patch, but
...
I question using the Java14 lexer/recognizer first. Is this because most of
the time it will succeed (especially with 1.4 source:-). Be great if a
comment could be added to the code.
2002-03-14 10:20:46 +00:00
e2ec464f27
added support for jdk 1.4 assert statements
...
grammar changes inspired by John Pybus on the antlr-interest mailing list,
see http://groups.yahoo.com/group/antlr-interest/message/4968
the changes to Checker.java are not very clean, but I don't see a better
solution unless the ANTLR api is improved (compilationUnit() should be an
abstract member of Parser, error reporting should be pluggable)
2002-03-14 06:19:09 +00:00
6b51ac1580
added tests for Configuration serialization
2002-03-06 06:08:00 +00:00
ec1e3e8349
fix for bug #522282 , "Cache not invalidated upon param. change"
...
- all classes that contribute to Configuration are now Serializable
- use in-memory serialization to compute a hashcode of the Configuration
- store the hashcode in the cache file
- compare cached hashcode with current hashcode and invalidate cache accordingly
2002-03-05 20:53:04 +00:00
1a596b6827
Renamed anttasks.properties to checkstyletask.properties. A much clearer name.
2002-02-25 12:15:07 +00:00
47383398f8
Implemented checking for right curly checking '}'. This was much easier that
...
for the left. Just need to do the documentation now.
2002-02-23 06:16:55 +00:00
d3af93d07b
explicitly set tab width to 1 column
...
fixes RFE #520410 (support latest ANTLR versions)
2002-02-23 00:37:53 +00:00
07a9baacf9
Remove a global variable hack.
2002-02-22 04:21:14 +00:00
59ce3f31d7
Added support for brace checking on the keywords try, catch, finally, static.
...
What are not covered deliberately are labels and instance initializers.
2002-02-22 04:12:04 +00:00
41e2089574
Added support for - for, do, else, synchronized
2002-02-22 03:37:41 +00:00
f4860ef3b4
Implemented brace checking for "if" and "while"
2002-02-22 03:11:36 +00:00
9943aefac7
Added support for setting the brace option for others + new tests. Now
...
check location of '{' on switch statements.
2002-02-21 23:37:59 +00:00
fd24216f46
Now have '{' checking for methods and types. Also put in place the logic to
...
be able to check the others.
2002-02-21 22:43:55 +00:00
c85ec6f26a
Merged the Streamable interface into the AuditListener interface. Having them
...
separate served no real purpose at the moment, except to complicate the
implementation.
2002-02-20 23:19:08 +00:00
339a7f5475
Fixed a checkstyle error
2002-02-20 23:09:01 +00:00
e10faf3315
First cut at doing left curly checking for methods. This is definitely a work
...
in progress that will change a lot as I add checking for other constructs. I
always tend to evolve to the general solution. :-)
2002-02-20 23:08:21 +00:00
1fd18cde7b
Now support setting the left curly placement option for methods. I am
...
implementing this example first, before doing it for types, statics, arrays,
anon inners, etc.
2002-02-20 02:52:27 +00:00
14d5ead27a
First cut at an options class for placement of left curly braces
2002-02-19 22:54:47 +00:00
048d0cdaf4
Changed the error reporting format for the modifier order check. In using the
...
feature, I found that it was very helpful to know which modifier to correct.
2002-02-19 22:52:49 +00:00
22885be800
Fixed checkstyle error
2002-02-19 22:39:35 +00:00
5e4b582734
Fixed the Javadoc comment. Not sure if the old style will create valid
...
output.
2002-02-18 00:37:04 +00:00
b174220a66
Made Defn public so it can be reference outside the package
2002-02-16 22:13:59 +00:00
faf76530d8
RFE #514033 , check order of modifiers (implementation, test, and documentation)
2002-02-15 06:47:51 +00:00
c9db9f82e2
Just some small refactoring
2002-02-11 05:38:09 +00:00
913028d7f2
Implementation, docs and test for RFE 438478, ignore multiple lines in header.
...
This change is compatible for command line, Ant, and API.
The API compatibility resulted in some deprecated methods in Configuration,
you can remove them if you think that API compatibility is not as
important as clean code.
2002-02-10 18:29:10 +00:00
db84febeb5
Update the tests and documentation for checking whitespace around periods.
...
#493383
2002-02-09 13:18:30 +00:00
241c48750b
Added a method to verify that a dot is correctly surrounded by whitespace.
2002-02-09 12:00:32 +00:00
7fa84f981c
Made Checkstyle more "ant friendly" but having a anttasks.properties file.
...
This allows declaritions of the taskdef in ant 1.4+ as:
<taskdef resource="anttasks.properties">
<classpath refid="run.classpath"/>
</taskdef>
Also, in a moment of madness, I re-indented the build.xml file to 4 spaces.
2002-02-09 11:03:56 +00:00
a1dda4f264
Reordered the logic for ignoring lines.
2002-02-08 00:42:21 +00:00
1ca4d43ce8
<picky>Made mConfig final</picky>
2002-02-08 00:35:39 +00:00
c7e7af8f7d
added test for new feature 'headerfile regular expression support', rfe #499259
...
moved creation of Configuration to setUp() to ensure that
each test is run with a well known Configuration that is not
influenced by other tests.
2002-02-07 20:39:51 +00:00
6fc674d4bf
new feature 'headerfile regular expression support, rfe #499259'
2002-02-07 20:34:11 +00:00
fdd9ae8297
Incorporate patch from Andrew Lang to support having javadoc with the format:
...
/**
* @param aTwo
* This is a multiline piece of javadoc
**/
Also changes the wording of "is not proceeded with whitespace" to
"is not followed by whitespace". This makes things a tad clearer.
2002-02-07 05:25:30 +00:00
d4f1261a61
Refactored the MethodSignature class to contain all the information. Also added
...
helper methods.
2002-02-06 23:15:05 +00:00
ea01eaaa85
Just tweaked the style a bit to be consistent with else where. I kept the
...
braces on a new line though. ;-)
2002-02-06 21:55:08 +00:00
6df3e84393
Changed a comment to C++ style
2002-02-06 05:49:22 +00:00
9be48298c3
Fixed checkstyle errors
2002-02-06 05:37:26 +00:00
46667e3599
Added tests for allowProtected (old feature without tests), allowPackage, requirePackageHtml, methodPattern, localVarPattern
2002-02-05 20:40:50 +00:00
c617457933
Implementation for RFEs 466756, 500378, 504964, 510441
...
Details:
466756 - Check for package.html:
- new parameter requirePackageHtml, default is false
500378 - Check names of methods + local variables
- new parameters methodPattern and localVarPattern,
default is ^[a-z][a-zA-Z0-9]*$
504964 - no default access
510441 - allowprotect should incl. packageprivate (requests the same feature)
- new parameter allowPackage, default is false
Sorry that I did not split this into separate patches, I had this in
my local tree as is and it would require too much work to split it. I
think the changes are easy enough to review three feature
implementations in one go.
2002-02-05 20:22:02 +00:00
b779f3c1da
Updated to the LGPL and version 2.0.
2002-02-04 12:44:04 +00:00
a5abed5101
Changed direct reference to getProject()
2002-01-28 22:15:08 +00:00
8e6328559e
fix bug #508010 , documentation and code are inconsistent
2002-01-24 18:34:47 +00:00
2b6c9c654a
Added warning not to use this class outside of this package.
2002-01-23 12:42:01 +00:00
15c7162ea4
Refactored Checker to not take a PrintStream. All errors are not logged to
...
standard output.
2002-01-23 12:28:49 +00:00
45120a140e
must be public, used as param in public method of Configuration
2002-01-22 05:23:25 +00:00
f755213c9e
tightened the scope
2002-01-22 01:05:22 +00:00
d4e7792f24
Made public so can be used outside the package
2002-01-21 11:54:27 +00:00
2fdc69f6a9
include author email address, make class package visible instead of public
2002-01-20 08:49:03 +00:00
5a9a68e619
removed hashmarks from @see tags, they resulted in errors during javadoc generation
2002-01-20 08:27:55 +00:00
f0d7921279
Added a default constructor to XMLLogger so it can be used by the ANT task.
...
Also updated build.xml to use the plain logger.
2002-01-15 23:51:49 +00:00
2727473656
Changed the defaults for member/static/parameter regexps to match the Sun coding
...
standard. The intent of this change is to make it easier for people to use
checkstyle out-of-the-box to check the Sun coding standard.
2002-01-15 12:54:03 +00:00
d7de3bef0b
Added tests to WS around DIV and MOD. All multiplicative expressions are now covered.
2002-01-15 06:04:46 +00:00
3af1c99a0c
Removed support for assert keyword. It breaks the parser on legal java
...
prior to JDK 1.4.
2002-01-14 05:07:22 +00:00
cb0fdf5428
Fixed a bug with JavaDoc checking in class/instance initialisers.
2002-01-14 04:33:15 +00:00
8d6fa332a9
Re-factored VerifierImpl to be called Verifier. The original intention of
...
the interface was to allow different verifiers to be swapped in. Considering
how much work would be required to create a verifier from scratch, people
are more likely to just want to extend VerifierImpl.
2002-01-14 02:56:15 +00:00
f8ea4c69a2
Removed all evidence of the java.tree.g file.
2002-01-14 01:33:42 +00:00
1104baffa4
Moved the final tests out of java.tree.g. Yahoo!
2002-01-14 01:18:50 +00:00
5ab5020a27
Moved all the checking for {}'s into java.g.
2002-01-14 00:26:43 +00:00
8d1cba0676
Moved more tests into java.g and improved some tests.
2002-01-13 07:52:23 +00:00
3335cdeb4d
Moved the reference checking to java.g
2002-01-13 06:34:38 +00:00
a54d892da1
removed unused method reportIdentifier()
2002-01-13 05:02:06 +00:00
1c35230164
large refactoring of moving checking into java.g (from java.tree.g). Solved
...
all the hard problems - only some easy checks to migrate
2002-01-11 23:58:08 +00:00
bd7cfcb3e5
Refactoring: removed unused methods reportStartMethodBlock() and
...
reportEndMethodBlock()
2002-01-11 13:45:54 +00:00
171df8e6e1
added a toString() method to help debugging
2002-01-11 13:42:55 +00:00
b7157a9946
moved with tests into java.g
2002-01-11 12:26:23 +00:00
16d7e573b0
Moved the checking for ws around "if"s to java.g. Also refactored
...
calls to verifyWSAfterEnd() to use verifyWSAfterBegin() where
appropriate.
2002-01-11 11:56:55 +00:00
3188792cad
Now have two methods for checking if ws around some text. One takes the column
...
where the text starts, and the other where the text ends. Needed because the
parser is different places either gives the start or the end.
2002-01-11 11:49:57 +00:00
e3c3cdcea3
tightened up checking the STAR in multiplicativeExpression. Possible source of
...
a NPE reported by Lars.
2002-01-11 10:47:02 +00:00
d16d3f310d
<ignore>removed trailing whitespace</ignore>
2002-01-11 10:46:03 +00:00
75e9d8486e
support jdk 1.4 assert statements, rfe 500122
2002-01-10 06:18:41 +00:00
047f8cef4b
Started migrating the whitespace tests from java.tree.g to java.g
2002-01-09 15:06:03 +00:00
0b7bf27706
Now support ignoring whether whitespace is after a type cast. As requested by
...
Lars.
2002-01-08 04:18:02 +00:00
c8756ab481
fix bug 499072, inner classes require author tag
2002-01-06 15:27:44 +00:00
9982fc546a
javadoc checkscope tests
2002-01-06 12:53:48 +00:00
17d3b314bb
javadoc checkscope implementation
2002-01-06 12:48:59 +00:00
7d82fd670a
Added support to check that commas ';' in "for" statements are followed by
...
whitespace (ala the Sun coding standard).
2002-01-06 11:06:07 +00:00
b7f1d0d1b7
Added support to check that commas ',' are followed by whitespace (ala the Sun
...
coding standard). This mainly involved refactoring the code I just wrote for
checking casts.
2002-01-06 10:31:32 +00:00
edf2c95634
Made Checker & Configuration public so they can be used outside the package.
...
A requested feature to that Checkstyle can be integrated into IDE's like
NetBeans, JBuilder.
2002-01-06 07:40:36 +00:00
d87ea06ebb
Added support for checking the file length does not exceed a specified max.
2002-01-06 07:08:20 +00:00
637bf620e5
Support testing for the max method and constructor lengths
2002-01-06 06:40:19 +00:00
0957b67c1d
Support setting the max method and constructor lengths
2002-01-06 06:30:29 +00:00
efcb63fd74
Added support to check that casts are followed by whitespace, as recommended
...
in the Sun coding standard. Can be turned off with all other whitespace checks.
May want to specifically be able to turn off this feature.
2002-01-05 13:18:22 +00:00
ad29236445
Included patch to check for whitespace around return statements.
2001-12-11 06:34:45 +00:00
518c2079d0
fixed (maybe?) a parse error
2001-12-10 02:22:25 +00:00
4fade39e72
patch for ignoring whitespace between Javadoc and declarations
2001-12-03 00:42:42 +00:00
82de45f06f
Incorporate changes made to the ANTLR Java grammar
2001-11-26 12:25:45 +00:00
9a905be3a0
patch for checking more whitespace
2001-11-26 11:25:21 +00:00
7b4b37602e
improved the tests
2001-11-03 10:40:15 +00:00
fc3bd86681
cosmetic fixed
2001-11-02 12:38:09 +00:00
517e2450ca
patch to ignore all javadoc and line length
2001-10-31 20:58:37 +00:00
85a53ccdaf
making the default logger much more silent
2001-10-31 20:10:25 +00:00
fb830fc73e
fix checkstyle errors
2001-10-31 13:32:41 +00:00
f8a69b0780
fix typos
2001-10-31 13:16:47 +00:00
403a3f70a3
patch to control ANT stopping the build on violations
2001-10-31 13:06:28 +00:00
030798a11d
incorporate performance patch
2001-10-31 12:42:19 +00:00
1d21af32b9
first cut
2001-08-30 16:21:20 +00:00
0e3fe56436
started to incorporate logging events
2001-08-30 16:13:24 +00:00
f34eba11cb
improved technique to locate files
2001-08-30 13:09:57 +00:00
a6df885ae1
included patch to be able to run unit tests from any directory.
2001-08-17 06:40:33 +00:00
c4d036af76
removed debug statement
2001-08-17 03:18:14 +00:00
6c304950f6
added support for caching
2001-08-05 14:12:57 +00:00
b3373646ee
added support for yes,on,true for boolean properties
2001-08-05 07:41:59 +00:00
d3f39e6b87
Added support for public member patterns.
2001-08-05 06:41:59 +00:00
fa128598e1
start of changes for detecting unused variables
2001-08-05 05:18:58 +00:00
b06dd9801e
updated for the IgnoreBraces property
2001-07-02 06:42:29 +00:00
be6d271ac3
added support for IgnoreBraces property
2001-07-02 06:23:24 +00:00
ba46163e7c
Added support for IgnoreWhitespace property.
2001-06-29 14:31:36 +00:00
9c56d57656
Implemented logic to detect package imports from the package itself.
2001-06-29 12:31:00 +00:00
69138e4022
refactored to use the new Configuration class.
2001-06-29 07:21:40 +00:00
3ded7a1155
refactoring to use a configuration object
2001-06-28 23:30:38 +00:00
20caaeb148
improved list
2001-06-28 13:12:12 +00:00
f0f7f3e762
changed for release 1.2
2001-06-28 13:10:22 +00:00
0fd69594a4
first cut
2001-06-22 13:24:24 +00:00
Oliver Burn
Lars Kühne