Checks whether files end with a line separator.
Rationale: Any source files and text files in general should end with a line separator, especially when using source control management systems such as CVS. CVS will even print a warning when it encounters a file that doesn't end with a line separator.
| name | description | type | default value |
|---|---|---|---|
| lineSeparator | type of line separator | One of "system" (system default), "crlf" (Windows-style), "cr" (Mac-style) and "lf" (Unix-style) | "system" |
| fileExtensions | file type extension of the files to check. | String Set | all files |
To configure the check:
To configure the check to always use Unix-style line separators:
To configure the check to work only on Java, XML and Python files:
com.puppycrawl.tools.checkstyle.checks
A check for TODO: comments. Actually
it is a generic regular
expression matcher on Java comments. To check for other
patterns in Java comments, set the format property.
| name | description | type | default value |
|---|---|---|---|
| format | Pattern to match comments against | regular expression | TODO: |
Using TODO: comments is a great way
to keep track of tasks that need to be done. Having them
reported by Checkstyle makes it very hard to forget about
them.
To configure the check:
To configure the check for comments that contain WARNING:
com.puppycrawl.tools.checkstyle.checks
A FileSetCheck that ensures the correct translation of code by checking property files for consistency regarding their keys. Two property files describing one and the same context are consistent if they contain the same keys.
Consider the following properties file in the same directory:
The Translation check will find the typo in the German hello
key, the missing ok key in the default resource file and the
missing cancel key in the German resource file:
| name | description | type | default value |
|---|---|---|---|
| fileExtensions |
file type extension to identify translation files. Setting
this property is typically only required if your
translation files are preprocessed and the original files
do not have the extension .properties
|
String Set | properties |
| basenameSeparator | Allows setting file names separator | String | _ |
To configure the check for files with '_' name separator:
To configure the check for files with user-set name separator:
com.puppycrawl.tools.checkstyle.checks
Checks for uncommented main() methods.
Rationale: A main() method is often used for debugging purposes. When debugging is finished, developers often forget to remove the method, which changes the API and increases the size of the resulting class or JAR file. With the exception of the real program entry points, all main() methods should be removed or commented out of the sources.
| name | description | type | default value |
|---|---|---|---|
| excludedClasses | Pattern for qualified names of classes which are allowed to have a main method. | regular expression | ^$ |
To configure the check:
To configure the check to allow the main method for all classes
with "Main" name:
com.puppycrawl.tools.checkstyle.checks
Checks that long constants are defined with an upper ell. That
is ' L' and not 'l'. This is in accordance with the Java
Language Specification,
Section 3.10.1.
The capital L looks a lot like 1.
To configure the check:
com.puppycrawl.tools.checkstyle.checks
Checks the style of array type definitions. Some like Java style:
public static void main(String[] args) and some like
C style: public static void main(String args[])
| name | description | type | default value |
|---|---|---|---|
| javaStyle | Controls whether to enforce Java style (true) or C style (false). | Boolean | true |
To configure the check to enforce Java style:
To configure the check to enforce C style:
com.puppycrawl.tools.checkstyle.checks
Check that parameters for methods, constructors, and catch blocks are final. Interface and abstract methods are not checked: the final keyword does not make sense for interface and abstract method parameters as there is no code that could modify the parameter.
Rationale: Changing the value of parameters during the execution of the method's algorithm can be confusing and should be avoided. A great way to let the Java compiler prevent this coding style is to declare parameters final.
| name | description | type | default value |
|---|---|---|---|
| tokens | blocks to check | subset of tokens METHOD_DEF, CTOR_DEF, LITERAL_CATCH | METHOD_DEF, CTOR_DEF |
| ignorePrimitiveTypes | ignore primitive types as parameters | Boolean | false |
To configure the check to enforce final parameters for methods and constructors:
To configure the check to enforce final parameters only for constructors:
To configure the check to allow ignoring primitive datatypes as parameters:
com.puppycrawl.tools.checkstyle.checks
Checks for restricted tokens beneath other tokens.
WARNING: This is a very powerful and flexible check, but, at the same time, it is low-level and very implementation-dependent because its results depend on the grammar we use to build abstract syntax trees. Thus we recommend using other checks when they provide the desired functionality. Essentially, this check just works on the level of an abstract syntax tree and knows nothing about language structures.
| name | description | type | default value |
|---|---|---|---|
| tokens | token types to check | subset of tokens declared in TokenTypes | empty set |
| limitedTokens | set of tokens with limited occurrences as descendants | subset of tokens declared in TokenTypes | empty set |
| minimumDepth | the minimum depth for descendant counts | Integer | 0 |
| maximumDepth | the maximum depth for descendant counts | Integer | java.lang.Integer.MAX_VALUE |
| minimumNumber | a minimum count for descendants | Integer | 0 |
| maximumNumber | a maximum count for descendants | Integer | java.lang.Integer.MAX_VALUE |
| sumTokenCounts | whether the number of tokens found should be calculated from the sum of the individual token counts | Boolean | false |
| minimumMessage | error message when the minimum count is not reached | String | "descendant.token.min" |
| maximumMessage | error message when the maximum count is exceeded | String | "descendant.token.max" |
Comparing this with null (i.e. this ==
null and this != null):
String literal equality check:
Switch with no default:
Assert statement may have side effects (formatted for browser display):
The initialiser in for performs no setup (where a while statement could be used instead):
The condition in for performs no check:
A switch within a switch:
A return statement from within a catch or finally block:
A try statement within a catch or finally block:
Too many cases within a switch:
Too many local variables within a method:
Too many returns from within a method:
Too many fields within an interface:
Limits the number of exceptions a method can throw:
Limits the number of expressions in a method:
Disallows empty statements:
Too many fields within a class:
com.puppycrawl.tools.checkstyle.checks
Checks correct indentation of Java code.
The idea behind this is that while pretty printers are sometimes convenient for bulk reformats of legacy code, they often either aren't configurable enough or just can't anticipate how format should be done. Sometimes this is personal preference, other times it is practical experience. In any case, this check should just ensure that a minimal set of indentation rules is followed.
| name | description | type | default value |
|---|---|---|---|
| basicOffset | how many spaces to use for new indentation level | Integer | 4 |
| braceAdjustment | how far braces should be indented when on the next line | Integer | 0 |
| caseIndent | how much to indent a case label | Integer | 4 |
| throwsIndent | how far a throws clause should be indented when on next line | Integer | 4 |
| arrayInitIndent | how much to indent an array initialisation when on next line | Integer | 4 |
| lineWrappingIndentation | how far continuation line should be indented when line-wrapping is present | Integer | 4 |
| forceStrictCondition | force strict condition in line wrapping case. If value is true, line wrap indent have to be same as lineWrappingIndentation parameter | Boolean | false |
To configure the check:
To configure the check to enforce the indentation style recommended by Oracle:
To configure the Check to enforce strict condition in line-wrapping validation.
Such config doesn't allow next cases:
But if forceStrictCondition = false, this code is valid:
com.puppycrawl.tools.checkstyle.checks.indentation
The check to ensure that requires that comments be the only thing on
a line. For the case of // comments that means that the only thing
that should precede it is whitespace. It doesn't check comments if
they do not end a line; for example, it accepts the following:
Thread.sleep( 10 <some comment here> ); Format
property is intended to deal with the "} // while" example.
Rationale: Steve McConnel in Code Complete suggests that endline comments are a bad practice. An end line comment would be one that is on the same line as actual code. For example:
Quoting Code Complete for the justification:
McConnel's comments on being hard to maintain when the size of the line changes are even more important in the age of automated refactorings.
| name | description | type | default value |
|---|---|---|---|
| format | pattern for strings allowed before the comment | regular expression | ^[\\s\\}\\);]*$ |
| legalComment | pattern for text allowed in trailing comments. (This pattern will not be applied to multiline comments and the text of the comment will be trimmed before matching.) | regular expression | (not set) |
To configure the check:
To configure the check so it enforces only comment on a line:
com.puppycrawl.tools.checkstyle.checks.indentation
A check that makes sure that a specified pattern exists, exists less than a set number of times, or does not exist in the file.
This check combines all the functionality provided by RegexpHeader except supplying the regular expression from a file.
It differs from them in that it works in multiline mode. Its regular expression can span multiple lines and it checks this against the whole file at once. The others work in singleline mode. Their single or multiple regular expressions can only span one line. They check each of these against each line in the file in turn.
Note: Because of the different mode of operation there may be some changes in the regular expressions used to achieve a particular end.
In multiline mode...
^ means the beginning of a line, as opposed to beginning of the input.\A.$ means the end of a line, as opposed to the end of the input.\Z.Note: Not all regular expression engines are created equal. Some provide extra functions that others do not and some elements of the syntax may vary. This check makes use of the java.util.regex package; please check its documentation for details of how to construct a regular expression to achieve a particular goal.
Note: When entering a regular expression as a parameter in the XML config file you must also take into account the XML rules. e.g. if you want to match a < symbol you need to enter <. The regular expression should be entered on one line.
| name | description | type | default value |
|---|---|---|---|
| format | pattern | regular expression | $^ (empty) |
| message | message which is used to notify about violations, if empty then the default (hard-coded) message is used. | String | ""(empty) |
| illegalPattern | Controls whether the pattern is required or illegal. | Boolean | false |
| duplicateLimit | Controls whether to check for duplicates of a required pattern, any negative value means no checking for duplicates, any positive value is used as the maximum number of allowed duplicates, if the limit is exceeded errors will be logged. | Integer | -1 |
| errorLimit | Controls the maximum number of errors before the check will abort. | Integer | 100 |
| ignoreComments | Controls whether to ignore matches found within comments. | Boolean | false |
The following examples are mainly copied from the other 3 checks mentioned above, to show how the same results can be achieved using this check in place of them.
To use like Required Regexp check:
An example of how to configure the check to make sure a copyright statement is included in the file:
The statement.
The check.
Your statement may be multiline.
Then the check would be.
Note: To search for parentheses () in a regular expression you must escape them like \(\). This is required by the regexp engine, otherwise it will think they are special instruction characters.
And to make sure it appears only once:
It can also be useful to attach a meaningful message to the check:
To use like illegal regexp check:
An example of how to configure the check to make sure there are no
calls to System.out.println:
You may want to make the above check ignore comments, like this:
An example of how to configure the check to find trailing whitespace at the end of a line:
An example of how to configure the check to find case-insensitive occurrences of "debug":
Note: The (?i) at the beginning of the regular expression tells the regexp engine to ignore the case.
There is also a feature to limit the number of errors reported. When the limit is reached the check aborts with a message reporting that the limit has been reached. The default limit setting is 100, but this can be change as shown in the following example.
To use like RegexpHeader :
To configure the check to verify that each file starts with the following multiline header.
Note the following:
A more complex example. Note how the import and javadoc multilines are handled, there can be any number of them.
More examples:
The next 2 examples deal with the following example Java source file:
This checks for the presence of the header, the first 16 lines.
Note the following:
This checks for the presence of a copyright notice within the class javadoc, lines 24 to 37.
Note: To search for things that mean something in XML, like < you need to escape them like <. This is required so the XML parser does not act on them, but instead passes the correct character to the regexp engine.
com.puppycrawl.tools.checkstyle.checks
Checks that the outer type name and the file name match. For example,
the class Foo must be in a file named
Foo.java.
None.
To configure the check:
com.puppycrawl.tools.checkstyle.checks
Checks properties files for duplicated properties.
Rationale: Multiple property keys usually appear after merge or rebase of several branches. While there are no errors in runtime, there can be a confusion due to having different values for the duplicated properties.
| name | description | type | default value |
|---|---|---|---|
| fileExtensions | file type extension of the files to check. | String Set | properties |
To configure the check:
com.puppycrawl.tools.checkstyle.checks
Restrict using Unicode escapes (e.g. \u221e). It is possible to allow using escapes for non-printable(control) characters. Also, this check can be configured to allow using escapes if trail comment is present. By the option it is possible to allow using escapes if literal contains only them.
| name | description | type | default value |
|---|---|---|---|
| allowEscapesForControlCharacters | Allow use escapes for non-printable(control) characters. | Boolean | false |
| allowByTailComment | Allow use escapes if trail comment is present. | Boolean | false |
| allowIfAllCharactersEscaped | Allow if all characters in literal are escaped. | Boolean | false |
| allowNonPrintableEscapes | Allow non-printable escapes. | Boolean | false |
Examples of using Unicode:
An example of how to configure the check is:
An example of non-printable(control) characters.
An example of how to configure the check to allow using escapes for non-printable(control) characters:
Example of using escapes with trail comment:
An example of how to configure the check to allow using escapes if trail comment is present:
Example of using escapes if literal contains only them:
An example of how to configure the check to allow escapes if literal contains only them:
An example of how to configure the check to allow non-printable escapes:
com.puppycrawl.tools.checkstyle.checks
Checks properties file for a duplicated properties.
Rationale: Multiple property keys usually appears after merge or rebase of several branches. While there is no errors in runtime, there can be a confusion on having different values for the duplicated properties.
| name | description | type | default value |
|---|---|---|---|
| fileExtensions | file type extension of the files to check. | String Set | properties |
To configure the check:
com.puppycrawl.tools.checkstyle.checks