TouchInstinct
/
html-webpack-plugin
301
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add test for loader errors and fix other broken tests. 

test.html used the old blueimp template syntax; but because `inject` was
switched to `true` the tests still passed.
This commit is contained in:
Kees Kluskens 2015-09-07 22:05:56 +02:00 committed by Jan Nicklas
parent 0ede95051b
commit 2c028a95c0
3 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
spec/HtmlWebpackPluginSpec.js
View File

@ -3,8 +3,7 @@ var path = require('path');
var fs = require('fs');
var webpack = require('webpack');
var rm_rf = require('rimraf');
var CommonsChunkPlugin = require("webpack/lib/optimize/CommonsChunkPlugin");
var AppCachePlugin = require('appcache-webpack-plugin');
var CommonsChunkPlugin = require('webpack/lib/optimize/CommonsChunkPlugin');
var HtmlWebpackPlugin = require('../index.js');
var OUTPUT_DIR = path.join(__dirname, '../dist');
@ -86,12 +85,29 @@ describe('HtmlWebpackPlugin', function() {
},
plugins: [new HtmlWebpackPlugin({
inject: false,
template: 'underscore-template-loader!' + path.join(__dirname, 'fixtures/underscore.html')
template: 'underscore-template-loader!' + path.join(__dirname, 'fixtures/test.html')
})]
},
['<script src="app_bundle.js', 'Some unique text'], null, done);
});
it('should pass through loader errors', function(done) {
testHtmlPlugin({
entry: {
app: path.join(__dirname, 'fixtures/index.js')
},
output: {
path: OUTPUT_DIR,
filename: '[name]_bundle.js'
},
plugins: [new HtmlWebpackPlugin({
inject: false,
template: path.join(__dirname, 'fixtures/invalid.html')
})]
},
['HtmlWebpackPlugin ReferenceError: foo is not defined'], null, done, true);
});
it('uses a custom loader from webpacks config', function(done) {
testHtmlPlugin({
entry: {
@ -108,7 +124,7 @@ describe('HtmlWebpackPlugin', function() {
},
plugins: [new HtmlWebpackPlugin({
inject: false,
template: path.join(__dirname, 'fixtures/underscore.html')
template: path.join(__dirname, 'fixtures/test.html')
})]
},
['<script src="app_bundle.js', 'Some unique text'], null, done);
@ -140,7 +156,10 @@ describe('HtmlWebpackPlugin', function() {
path: OUTPUT_DIR,
filename: '[name]_bundle.js'
},
plugins: [new HtmlWebpackPlugin({template: path.join(__dirname, 'fixtures/test.html')})]
plugins: [new HtmlWebpackPlugin({
template: path.join(__dirname, 'fixtures/test.html'),
inject: false
})]
},
['<script src="app_bundle.js', 'Some unique text'], null, done);
});
@ -258,7 +277,7 @@ describe('HtmlWebpackPlugin', function() {
},
plugins: [new HtmlWebpackPlugin({
templateContent: function() {
return fs.readFileSync(path.join(__dirname, 'fixtures/test.html'), 'utf8');
return fs.readFileSync(path.join(__dirname, 'fixtures/plain.html'), 'utf8');
}
})]
},
@ -577,6 +596,7 @@ describe('HtmlWebpackPlugin', function() {
});
it('adds a manifest', function(done) {
var AppCachePlugin = require('appcache-webpack-plugin');
testHtmlPlugin({
entry: path.join(__dirname, 'fixtures/index.js'),
output: {
@ -591,6 +611,7 @@ describe('HtmlWebpackPlugin', function() {
});
it('does not add a manifest if already present', function(done) {
var AppCachePlugin = require('appcache-webpack-plugin');
testHtmlPlugin({
entry: path.join(__dirname, 'fixtures/index.js'),
output: {

2
spec/fixtures/underscore.html → spec/fixtures/invalid.html vendored
View File

@ -6,6 +6,6 @@
</head>
<body>
<p>Some unique text</p>
<script src="<%=htmlWebpackPlugin.files.chunks.app.entry%>"></script>
<script src="<%=foo.bar%>"></script>
</body>
</html>

2
spec/fixtures/test.html vendored
View File

@ -6,6 +6,6 @@
</head>
<body>
<p>Some unique text</p>
<script src="{%=o.htmlWebpackPlugin.files.chunks.app.entry%}"></script>
<script src="<%=htmlWebpackPlugin.files.chunks.app.entry%>"></script>
</body>
</html>