From 18d981efaa46e05bdb33c3c27ddc82c221892afd Mon Sep 17 00:00:00 2001 From: tsschmidt Date: Wed, 23 Jan 2019 10:24:01 -0800 Subject: [PATCH] Refactor --- .../validation/Cas30ServiceTicketValidator.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas30ServiceTicketValidator.java b/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas30ServiceTicketValidator.java index 160c0ab..023c5f3 100644 --- a/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas30ServiceTicketValidator.java +++ b/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas30ServiceTicketValidator.java @@ -20,6 +20,7 @@ package org.jasig.cas.client.validation; import org.jasig.cas.client.util.XmlUtils; import org.w3c.dom.Document; +import org.w3c.dom.NamedNodeMap; import org.w3c.dom.Node; import org.w3c.dom.NodeList; @@ -58,12 +59,13 @@ public class Cas30ServiceTicketValidator extends Cas20ServiceTicketValidator { NodeList attributeList = document.getElementsByTagName("cas:attribute"); for (int i = 0; i < attributeList.getLength(); i++) { - final Node attribute = attributeList.item(i); - if (attribute.getAttributes().getLength() > 0) { - attributes.put(attribute.getAttributes().getNamedItem("name").getNodeValue(), - attribute.getAttributes().getNamedItem("value").getNodeValue()); + final Node casAttributeNode = attributeList.item(i); + final NamedNodeMap casAttributes = casAttributeNode.getAttributes(); + if (casAttributes.getLength() > 0) { + attributes.put(casAttributes.getNamedItem("name").getNodeValue(), + casAttributes.getNamedItem("value").getNodeValue()); } else { - attributes.put(attribute.getLocalName(), attribute.getNodeValue()); + attributes.put(casAttributeNode.getLocalName(), casAttributeNode.getNodeValue()); } }