TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #100 Respond to code review feedback.

This commit is contained in:
Marvin S. Addison 2015-04-20 10:34:28 -04:00
parent 8038e69fc0
commit 2362d6ac17
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cas-client-core/src/main/java/org/jasig/cas/client/util/IOUtils.java
View File

@ -10,7 +10,7 @@ import java.nio.charset.Charset;
* @author Marvin S. Addison
* @since 3.3.4
*/
public class IOUtils {
public final class IOUtils {
/** UTF-8 character set. */
public static final Charset UTF8 = Charset.forName("UTF-8");

4
cas-client-core/src/main/java/org/jasig/cas/client/util/ThreadLocalXPathExpression.java
View File

@ -16,10 +16,10 @@ import javax.xml.xpath.*;
public class ThreadLocalXPathExpression extends ThreadLocal<XPathExpression> implements XPathExpression {
/** XPath expression */
private String expression;
private final String expression;
/** Namespace context. */
private NamespaceContext context;
private final NamespaceContext context;
/**
* Creates a new instance from an XPath expression and namespace context.

1
cas-client-support-saml/src/main/java/org/jasig/cas/client/validation/Saml11TicketValidator.java
View File

@ -197,7 +197,6 @@ public final class Saml11TicketValidator extends AbstractUrlBasedTicketValidator
conn = this.getURLConnectionFactory().buildHttpURLConnection(validationUrl.openConnection());
conn.setRequestMethod("POST");
conn.setRequestProperty("Content-Type", "text/xml");
conn.setRequestProperty("Content-Type", "text/xml");
conn.setRequestProperty("Content-Length", Integer.toString(request.length()));
conn.setRequestProperty("SOAPAction", "http://www.oasis-open.org/committees/security");
conn.setUseCaches(false);