TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CASC-28 

added UrlEncoder to url construction.
This commit is contained in:
Scott Battaglia 2007-02-08 16:39:23 +00:00
parent 2527aef900
commit 506620a61e
2 changed files with 63 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cas-client-core/src/main/java/org/jasig/cas/client/validation/Saml10TicketValidator.java
View File

@ -20,6 +20,7 @@ import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.net.URLEncoder;
/**
* @author Scott Battaglia
@ -45,7 +46,12 @@ public class Saml10TicketValidator extends AbstractUrlBasedTicketValidator {
protected String constructURL(final String ticketId, final Service service) {
return getCasServerUrl() + "/samlValidate?SAMLart=" + ticketId + "&TARGET=" + getEncodedService(service);
try {
final String encodedTicket = URLEncoder.encode(ticketId, "UTF-8");
return getCasServerUrl() + "/samlValidate?SAMLart=" + encodedTicket + "&TARGET=" + getEncodedService(service);
} catch (final Exception e) {
return getCasServerUrl() + "/samlValidate?SAMLart=" + ticketId + "&TARGET=" + getEncodedService(service);
}
}
protected Assertion parseResponse(final String response) throws ValidationException {

56
cas-client-core/src/test/java/org/jasig/cas/client/validation/SamlTicketValidatorTests.java Normal file
View File

@ -0,0 +1,56 @@
/*
* Copyright 2006 The JA-SIG Collaborative. All rights reserved. See license
* distributed with this file and available online at
* http://www.ja-sig.org/products/cas/overview/license/index.html
*/
package org.jasig.cas.client.validation;
import junit.framework.TestCase;
import org.jasig.cas.web.view.Saml10SuccessResponseView;
import org.jasig.cas.authentication.Authentication;
import org.jasig.cas.authentication.ImmutableAuthentication;
import org.jasig.cas.authentication.principal.SimplePrincipal;
import org.jasig.cas.authentication.principal.SimpleService;
import org.jasig.cas.validation.ImmutableAssertionImpl;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
import org.apache.commons.httpclient.HttpClient;
import java.util.Map;
import java.util.HashMap;
import java.util.List;
import java.util.ArrayList;
/**
* Test cases for the {@link org.jasig.cas.client.validation.Saml10TicketValidator}.
*
* @author Scott Battaglia
* @version $Revision: 11737 $ $Date: 2006-10-03 09:14:02 -0400 (Tue, 03 Oct 2006) $
* @since 3.1
*/
public class SamlTicketValidatorTests extends TestCase {
final Saml10TicketValidator validator = new Saml10TicketValidator("https://cas.rutgers.edu", new HttpClient());
/*
public void testValidationWithTicketIdWithPlus() throws Exception {
final Saml10SuccessResponseView view = new Saml10SuccessResponseView();
final MockHttpServletRequest request = new MockHttpServletRequest();
final MockHttpServletResponse response = new MockHttpServletResponse();
final Map model = new HashMap();
final Authentication authentication = new ImmutableAuthentication(new SimplePrincipal("test"));
final List authentications = new ArrayList();
authentications.add(authentication);
final ImmutableAssertionImpl assertion = new ImmutableAssertionImpl(authentications, new SimpleService("test"), true);
model.put("assertion", assertion);
request.addParameter("SAMLArt", "AAIYG64MrQ2+793pMM8J0sRjXf6uG2h0dHBzOi8vbG9jYWxob3N0Ojg0NDM=");
view.setIssuer("https://cas.rutgers.edu");
view.render(model, request, response);
final String content = response.getContentAsString();
Assertion assertionResponse = validator.parseResponse(content);
assertEquals("test", assertionResponse.getPrincipal().getId());
} */
}