From c4c3223140ff4e3fc3e5011647119f0c6d12cfe7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20LELEU?= Date: Mon, 7 Apr 2014 18:54:40 +0200 Subject: [PATCH] CASC-220: Support front channel SLO logout Update after new Misagh's comments --- .../org/jasig/cas/client/session/SingleSignOutHandler.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java b/cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java index 8026ed1..c93d9b3 100644 --- a/cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java +++ b/cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java @@ -214,7 +214,7 @@ public final class SingleSignOutHandler { return false; } else { - logger.trace("Ignoring URI {}", request.getRequestURI()); + logger.trace("Ignoring URI for logout: {}", request.getRequestURI()); return true; } } @@ -264,7 +264,7 @@ public final class SingleSignOutHandler { // decode the bytes into a String return new String(result, 0, resultLength, "UTF-8"); - } catch (Exception e) { + } catch (final Exception e) { logger.error("Unable to decompress logout message", e); throw new RuntimeException(e); } finally { @@ -282,7 +282,7 @@ public final class SingleSignOutHandler { private void destroySession(final HttpServletRequest request) { final String logoutMessage; // front channel logout -> the message needs to be base64 decoded + decompressed - if ("GET".equals(request.getMethod())) { + if (isFrontChannelLogoutRequest(request)) { logoutMessage = uncompressLogoutMessage(CommonUtils.safeGetParameter(request, this.frontLogoutParameterName)); } else {