TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop using "matches" terminology

This commit is contained in:
Matt Drees 2018-07-24 16:07:44 -06:00
parent 40dcc8b34a
commit c5d1b1ef84
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java
View File

@ -173,7 +173,7 @@ public final class SingleSignOutHandler {
private boolean isLogoutRequest(final HttpServletRequest request) {
if ("POST".equalsIgnoreCase(request.getMethod())) {
return !isMultipartRequest(request)
&& pathMatches(request)
&& pathEligibleForLogout(request)
&& CommonUtils.isNotBlank(CommonUtils.safeGetParameter(request, this.logoutParameterName,
this.safeParameters));
}
@ -184,7 +184,7 @@ public final class SingleSignOutHandler {
return false;
}
private boolean pathMatches(HttpServletRequest request) {
private boolean pathEligibleForLogout(HttpServletRequest request) {
return logoutPath == null || logoutPath.equals(getPath(request));
}

4
cas-client-core/src/test/java/org/jasig/cas/client/session/SingleSignOutHandlerTests.java
View File

@ -122,7 +122,7 @@ public final class SingleSignOutHandlerTests {
}
@Test
public void backChannelLogoutDoesDoesNotRunIfLogoutPathDoesNotMatch() {
public void backChannelLogoutDoesNotRunIfPathIsNotEligibleForLogout() {
handler.setLogoutPath("/logout");
request.setServletPath("/not-a-logout");
final MockHttpSession session = doBackChannelLogout();
@ -131,7 +131,7 @@ public final class SingleSignOutHandlerTests {
}
@Test
public void backChannelLogoutRunsWhenLogoutPathDoesMatch() {
public void backChannelLogoutRunsIfPathEqualsLogoutPath() {
handler.setLogoutPath("/logout");
request.setServletPath("/logout");
final MockHttpSession session = doBackChannelLogout();