diff --git a/cas-client-integration-atlassian/src/main/java/org/jasig/cas/client/integration/atlassian/ConfluenceCasAuthenticator.java b/cas-client-integration-atlassian/src/main/java/org/jasig/cas/client/integration/atlassian/ConfluenceCasAuthenticator.java index e8abef8..15a5801 100644 --- a/cas-client-integration-atlassian/src/main/java/org/jasig/cas/client/integration/atlassian/ConfluenceCasAuthenticator.java +++ b/cas-client-integration-atlassian/src/main/java/org/jasig/cas/client/integration/atlassian/ConfluenceCasAuthenticator.java @@ -60,19 +60,22 @@ public final class ConfluenceCasAuthenticator extends ConfluenceAuthenticator { final Assertion assertion = (Assertion) session.getAttribute(AbstractCasFilter.CONST_CAS_ASSERTION); if (assertion != null) { - final Principal p = getUser(assertion.getPrincipal().getName()); + final String username = assertion.getPrincipal().getName(); + final Principal user = getUser(username); - // user doesn't exist - if (p == null) { + // user doesn't exist + if (user == null) { LOGGER.error("Could not determine principal for [{}]", assertion.getPrincipal().getName()); + getElevatedSecurityGuard().onFailedLoginAttempt(request, username); return null; } - LOGGER.debug("Logging in [{}] from CAS.", p.getName()); + LOGGER.debug("Logging in [{}] from CAS.", username); - session.setAttribute(LOGGED_IN_KEY, p); + getElevatedSecurityGuard().onSuccessfulLoginAttempt(request, username); + session.setAttribute(LOGGED_IN_KEY, user); session.setAttribute(LOGGED_OUT_KEY, null); - return p; + return user; } return super.getUser(request, response);