TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Respond to code review feedback. 

1. Call HttpServletRequest#logout() on SLO callback since it is available.
2. Use final for local variables where possible.
This commit is contained in:
Marvin S. Addison 2013-10-28 15:58:40 -04:00
parent f7343e5cb2
commit e494ac5cf6
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cas-client-core/src/main/java/org/jasig/cas/client/jaas/CasLoginModule.java
View File

@ -448,7 +448,7 @@ public class CasLoginModule implements LoginModule {
// Remove cache entry if assertion caching is enabled
if (this.cacheAssertions) {
for (TicketCredential ticket : this.subject.getPrivateCredentials(TicketCredential.class)) {
for (final TicketCredential ticket : this.subject.getPrivateCredentials(TicketCredential.class)) {
logger.debug("Removing cached assertion for {}", ticket);
ASSERTION_CACHE.remove(ticket);
}

6
cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutHandler.java
View File

@ -20,6 +20,8 @@ package org.jasig.cas.client.session;
import java.util.Arrays;
import java.util.List;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpSession;
import org.jasig.cas.client.util.CommonUtils;
@ -173,7 +175,9 @@ public final class SingleSignOutHandler {
try {
session.invalidate();
// TODO: Add request.logout() upon bump to Servlet 3.0 API dependency
request.logout();
} catch (final ServletException e) {
logger.debug("Error performing request.logout.");
} catch (final IllegalStateException e) {
logger.debug("Error invalidating session.", e);
}