From ec87c31ecdedfaafa64861bcfa3071cb1441b37e Mon Sep 17 00:00:00 2001 From: Scott Battaglia Date: Sat, 12 Feb 2011 18:29:41 +0000 Subject: [PATCH] NOJIRA switch to stringbuilder since we're on Java 5 --- .../src/main/java/org/jasig/cas/client/util/XmlUtils.java | 6 +++--- .../cas/client/validation/Cas20ServiceTicketValidator.java | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/cas-client-core/src/main/java/org/jasig/cas/client/util/XmlUtils.java b/cas-client-core/src/main/java/org/jasig/cas/client/util/XmlUtils.java index e7bd7ea..5496001 100644 --- a/cas-client-core/src/main/java/org/jasig/cas/client/util/XmlUtils.java +++ b/cas-client-core/src/main/java/org/jasig/cas/client/util/XmlUtils.java @@ -128,7 +128,7 @@ public final class XmlUtils { public static String getTextForElement(final String xmlAsString, final String element) { final XMLReader reader = getXmlReader(); - final StringBuffer buffer = new StringBuffer(); + final StringBuilder builder = new StringBuilder(); final DefaultHandler handler = new DefaultHandler() { @@ -152,7 +152,7 @@ public final class XmlUtils { public void characters(char[] ch, int start, int length) throws SAXException { if (this.foundElement) { - buffer.append(ch, start, length); + builder.append(ch, start, length); } } }; @@ -167,6 +167,6 @@ public final class XmlUtils { return null; } - return buffer.toString(); + return builder.toString(); } } diff --git a/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas20ServiceTicketValidator.java b/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas20ServiceTicketValidator.java index 987091e..a51e27a 100644 --- a/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas20ServiceTicketValidator.java +++ b/cas-client-core/src/main/java/org/jasig/cas/client/validation/Cas20ServiceTicketValidator.java @@ -87,8 +87,7 @@ public class Cas20ServiceTicketValidator extends AbstractCasProtocolUrlBasedTick } final String principal = XmlUtils.getTextForElement(response, "user"); - final String proxyGrantingTicketIou = XmlUtils.getTextForElement( - response, "proxyGrantingTicket"); + final String proxyGrantingTicketIou = XmlUtils.getTextForElement(response, "proxyGrantingTicket"); final String proxyGrantingTicket = this.proxyGrantingTicketStorage != null ? this.proxyGrantingTicketStorage.retrieve(proxyGrantingTicketIou) : null; if (CommonUtils.isEmpty(principal)) {