TouchInstinct
/
java-cas-client
303
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #152 Fix multiple ticket validation attempt.

This commit is contained in:
Marvin S. Addison 2016-02-12 15:34:19 -05:00
parent 971d4b4854
commit f09ee1c0e7
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
cas-client-integration-jetty/src/main/java/org/jasig/cas/client/jetty/CasAuthenticator.java
View File

@ -162,22 +162,18 @@ public class CasAuthenticator extends AbstractLifeCycle implements Authenticator
return Authentication.UNAUTHENTICATED;
}
String ticket;
for (final Protocol protocol : Protocol.values()) {
ticket = request.getParameter(protocol.getArtifactParameterName());
if (ticket != null) {
try {
logger.debug("Attempting to validate {}", ticket);
final Assertion assertion = ticketValidator.validate(ticket, serviceUrl(request, response));
logger.debug("Successfully authenticated {}", assertion.getPrincipal());
authentication = new CasAuthentication(this, ticket, assertion);
cacheAuthentication(request, authentication);
} catch (Exception e) {
throw new ServerAuthException("CAS ticket validation failed", e);
}
final String ticket = extractTicket(request);
if (ticket != null) {
try {
logger.debug("Attempting to validate {}", ticket);
final Assertion assertion = ticketValidator.validate(ticket, serviceUrl(request, response));
logger.debug("Successfully authenticated {}", assertion.getPrincipal());
authentication = new CasAuthentication(this, ticket, assertion);
cacheAuthentication(request, authentication);
} catch (Exception e) {
throw new ServerAuthException("CAS ticket validation failed", e);
}
}
if (authentication != null) {
return authentication;
}
@ -251,4 +247,14 @@ public class CasAuthenticator extends AbstractLifeCycle implements Authenticator
}
}
private String extractTicket(final HttpServletRequest request) {
String ticket;
for (final Protocol protocol : Protocol.values()) {
ticket = request.getParameter(protocol.getArtifactParameterName());
if (ticket != null) {
return ticket;
}
}
return null;
}
}