Commit Graph

383 Commits

Author SHA1 Message Date
Misagh Moayyed 745fda6113 Minor code adjustments to CommonUtils to use String.isEmpty() 2016-09-07 15:38:46 +04:30
Misagh Moayyed 9b71825e1a Let config keys log the name 2016-09-07 15:31:39 +04:30
Marvin S. Addison 2e27e09f3b Log proxy ticket returned from /proxy protocol endpoint. 2016-09-01 13:22:01 -04:00
Olivier Jaquemet b4d9570bdc Fix #177 Every other request incorrectly gatewayed
- ensure behavior of gateway is predictable (reentrant)
2016-08-09 10:27:27 +02:00
Marvin S. Addison 53dbb48882 Issue #152 Jetty container-based authn. 2016-02-11 14:53:14 -05:00
Scott 346374ebc8 CASC-127 Remove Commons Codec Dependency
Problem: We rely on Commons Codec for some simple Base64 decoding/encoding, most of which is available in Java 1.6+
Solution: Set minimum version to Java 1.6 and rely on provided methods.

QA Notes: Unit tests pass
2015-11-18 21:58:06 -05:00
Scott 8067714256 Added missing license headers. 2015-09-13 00:11:09 -04:00
Scott 85b0454e8d Merge pull request #133 from battags/131
Issue #131 - ConfigurationStrategyName does not Properly Resolve Cust…
2015-09-10 09:27:08 -04:00
Scott 2eb132c0b4 Issue #131 - ConfigurationStrategyName does not Properly Resolve Custom classes
Problem: The assignable check was reversed, always resulting in a false return value.
Solution: Add test to confirm failure and then swap check.  Unit tests pass.
2015-09-09 23:30:53 -04:00
Misagh Moayyed ab105cdcfa initialize service parameter names once, statically 2015-08-19 08:51:28 -07:00
Misagh Moayyed 1f3a745ec8 overload constructServiceUrl to keep backward compatibility 2015-08-19 02:28:20 -07:00
Misagh Moayyed 618a99a245 URIBuilder test cases 2015-08-12 12:36:50 -07:00
Xu Huisheng 69bba0c21a When serverName contains schema, the URIBuilder will throw an UnsupportedOperationException while adding a parameter. 2015-08-04 18:20:31 +08:00
Scott 76ba57a541 Added missing license headers 2015-07-21 22:19:00 -04:00
Scott 0a7ffac846 Merge pull request #66 from Unicon/CASC-210
CASC-210: Added support for having regex expressions in the proxy (chaining) list.
2015-07-07 17:10:05 -04:00
Scott c8e50905bb Merge pull request #116 from Unicon/remove-lang
removed commons-lang dependency
2015-07-03 11:27:00 -04:00
Scott eaee34b361 Merge pull request #105 from mmoayyed/removing-service-param
Added uri builder to construct query params
2015-07-03 11:13:31 -04:00
John Gasper f98e776869 casc-210: Merge branch 'master' of https://github.com/jasig/java-cas-client into CASC-210
Resolved Conflicts:
	cas-client-core/src/main/java/org/jasig/cas/client/validation/ProxyList.java
2015-06-16 12:09:37 -07:00
Misagh Moayyed e1e12a5f3f removed since tags 2015-06-10 20:09:15 -07:00
Misagh Moayyed 8c77fc4eaf removed commons-lang dep 2015-06-10 20:04:12 -07:00
Scott 607d53a2aa Merge pull request #113 from Unicon/commons-lang3
Upgrade to commons-lang3
2015-06-08 22:56:07 -04:00
Misagh Moayyed 70b8aa8032 Merge pull request #112 from Unicon/depc-const
Deprecated unused DISABLE_XML_SCHEMA_VALIDATION
2015-06-07 20:48:35 -07:00
Misagh Moayyed 853450a8a6 added additional logs to proxy validation 2015-06-07 17:05:47 -07:00
Misagh Moayyed f1ac21943d upgrade to commons-lang3 v3.4 2015-06-07 13:24:12 -07:00
Misagh Moayyed c6c106c375 deprecated unused const 2015-06-07 13:18:19 -07:00
Misagh Moayyed 0a6ce18150 updated param building 2015-06-05 15:17:04 -07:00
Misagh Moayyed f68281d0e4 added uri builder to construct query params 2015-05-13 03:44:13 -07:00
Marvin S. Addison 863038605f Merge pull request #101 from Jasig/no-opensaml
Remove OpenSAML and consolidate SAML components in support module
2015-05-12 09:29:02 -04:00
Marvin S. Addison f5b2275913 Issue #100 Bump minor version due to refactoring. 2015-05-11 12:09:00 -04:00
Marvin S. Addison 1edef62ecb Issue #100 Isolate JodaTime to SAML module. 2015-05-11 12:01:48 -04:00
Marvin S. Addison 7c58629958 Issue 100 Restore configuration key for backward compatibility. 2015-05-04 16:10:56 -04:00
Marvin S. Addison 6e261e7251 Issue #100 Respond to code review feedback. 2015-04-20 10:34:28 -04:00
Scott 0652f4ee23 Merge pull request #93 from leleuj/CASC-217
CASC-217: Update the ticket validators to point to the new endpoint
2015-04-20 06:54:48 -04:00
Marvin S. Addison d8980535b7 Move SAML components into separate module. 2015-04-14 16:19:12 -04:00
Marvin S. Addison dd0818b84f Fix @since version. 2015-02-20 10:35:05 -05:00
Marvin S. Addison 4527671568 Sensible XPath processing optimizations. 2015-02-20 10:26:01 -05:00
Marvin S. Addison e998985732 SAML validation with XPath instead of OpenSAML. 2015-02-20 09:18:05 -05:00
Scott 6f7fe61780 Merge pull request #97 from battags/CASC-239
CASC-239 Saml11AuthenticationFilter Constructor was Private instead of Public
2015-01-25 19:11:28 -05:00
Scott db3610123f CASC-239 Saml11AuthenticationFilter Constructor was Private instead of Public. 2015-01-24 23:58:51 -05:00
Marvin S. Addison 4aef368057 CASC-237 Make OpenSAML bootstrap conditional. 2015-01-17 11:25:03 -05:00
LELEU Jerome bec0e6bb2e Issue-91: Introduce system properties configuration option
First commit
2015-01-05 17:19:40 +01:00
LELEU Jerome 2a98556daa CASC-217: Update the ticket validators to point to the new endpoint
First commit
2015-01-05 15:55:33 +01:00
Scott ec92d97518 Added license headers 2014-12-22 23:55:23 -05:00
Scott 34458db530 Merge branch 'master' into CASC-231 2014-12-22 23:54:46 -05:00
Scott 39f0f29dd9 CASC-200 Introduce Properties File Configuration Option
Problem: We can configure via JNDI, WebXML (or both) but not by properties file.
Solution: Introduce a method to use property files.
2014-12-07 14:14:08 -05:00
Scott d1da02f457 CASC-231 HttpsURLConnectonFactory is Not Serializable
Problem: THe HttpsURLConnectionFactory is not serializable, causing problems for clients that must serialize
the principal (which depends on a ProxyRetriever).

Solution: Make the HttpsURLConnectionFactory serializable.

QA Notes: added unit test to confirm serialize-deserialize
2014-12-07 13:32:14 -05:00
Scott d7ca6a098e Merge pull request #87 from battags/CASC-233
CASC-233 ErrorRedirectFilter Can throw Null Pointer Exception
2014-12-07 12:13:27 -05:00
Scott a780e39ab9 Merge branch 'master' into CASC-200-rebasefail
Conflicts:
	cas-client-core/src/main/java/org/jasig/cas/client/session/SingleSignOutFilter.java
2014-12-07 12:11:42 -05:00
Scott Battaglia bef2a88603 Updated try/catch loop to log when a class is not found. 2014-11-30 17:09:09 -05:00
Scott Battaglia 3af5683dc1 Addressed formatting feedback as well as reserved keywords. 2014-11-26 22:58:12 -05:00
Scott Battaglia 5109132df3 Per feedback, scoped catch block to Exception instead of Throwable 2014-11-26 22:31:01 -05:00
Scott Battaglia 51a9192792 CASC-233 ErrorRedirectFilter Can throw Null Pointer Exception
Problem: the ErrorRedirectFilter assumes there is a root cause and will null pointer if there is not.
Solution: Only use the root cause if there is one, otherwise use the original exception.

QA Notes: Added unit test to confirm non-root cause error.
2014-11-20 16:29:29 -05:00
Scott Battaglia c7e66d7df2 Unused reference to Mockito 2014-11-20 16:03:19 -05:00
Scott Battaglia 17f887595f Added missing javadoc for Protocol enumeration 2014-11-20 15:58:52 -05:00
Scott Battaglia 324b0919b6 Added additional keys that were new from the single signout refactor. 2014-11-20 15:31:31 -05:00
Scott Battaglia 461cdcd8fc CASC-200 Create a ConfigurationStrategy to allow for pluggable configurations.
Problem: The lookup strategy for configuration is hard-coded into the filter, making it impossible to replace or expand.
Solution: Pull the strategies into their own classees and make it configurable.  Default to the previous strategy.

QA Notes: The current unit tests work.  New unit tests for the configuration will have to be added once the design is approved.
2014-11-20 15:30:38 -05:00
Scott 117f32006f Merge pull request #79 from battags/CASC-229
CASC-229 Make Front Channel SSO Optional so that backwards compatibility...
2014-08-13 10:13:45 -04:00
Scott db53818de7 Merge pull request #80 from battags/CASC-230
CASC-230 Call HttpServletRequest#logout() via Reflection to Improve Back...
2014-08-13 10:13:28 -04:00
Scott Battaglia b34c4e104f Updated code to abstract the reflection logic a bit more behind a strategy interface. 2014-08-11 23:04:24 -04:00
Scott Battaglia a0f8845ecf CASC-230 Call HttpServletRequest#logout() via Reflection to Improve Backwards Compatibility with Spring Security 2014-08-11 22:50:23 -04:00
Scott Battaglia b18dbfe0a9 CASC-229 Make Front Channel SSO Optional so that backwards compatibility is maintained.
Problem: Spring Security adopters will fail to be able to drop in a new version of CAS Client for Java if this feature is enabled by default/required.
Solution: Force a fail-safe optional mode if the value is not provided.
2014-08-11 22:36:27 -04:00
Scott Battaglia 42ce676ef0 CASC-225 Restore Removed Constructor for Backwards Compatibility
Problem: We removed the two string constructor which breaks Spring Security compatibility.
Solution: Add it back as deprecated so that Spring Security can upgrade.
2014-08-11 22:09:27 -04:00
Scott Battaglia d191ac8ee6 Added missing license header. 2014-08-03 00:03:25 -04:00
Scott Battaglia 61a92c0e7f CASC-224 Replace URL with String to remain compatible with Spring Security 2014-07-20 20:31:35 -04:00
Scott Battaglia 9de2be91a2 CASC-228 URL Encode Paramaters Passed to Server via Validate
Problem: We currently don't pass encoded values to the server, possibly resolving in parsing/extraction errors.
Solution: URL Encode all values instead of just the service url.

QA Notes: Added unit test.
2014-06-24 18:44:45 -04:00
Scott 566c8690c8 Merge pull request #72 from battags/CASC-223
CASC-223 Backwards Compatibility for Initializing Sign Out Handler in Filter
2014-05-22 22:03:26 -04:00
Scott Battaglia a44b4c1229 Removed no-longer valid test. 2014-05-06 23:17:32 -04:00
Scott Battaglia a4e984e4ea Synchronize the init method in case we have multiple concurrent requests at the same time. 2014-05-06 22:53:05 -04:00
Scott Battaglia 2c9090155a CASC-223 SingleSignOutFilter requires init method to be called which changes the contract with previous versions
Problem: Some clients such as Spring Security configure the filter via Spring configuration, meaning the handler's init method
is not called vai the Filter#init method.

Solution: For now, have an atomic boolean to determine if init was called or not and call it if necessary as part of the flow.
2014-05-06 22:35:55 -04:00
Scott Battaglia b4fbf23361 CASC-224 Public API Method Removed without Deprecation
Problem: Previous versions of the CAS Client remove a public API method without sufficient deprecation time resulting in
problems for clients who want to upgrade.

Solution: Add Method back and mark it as deprecated.
2014-05-06 22:12:59 -04:00
John Gasper c61dea96bf Formatting clean-up 2014-04-15 12:56:46 -07:00
John Gasper 99763ab2b6 Using Misagh's PatternMatcherStrategy to optimize proxy chain checks 2014-04-14 08:45:21 -07:00
John Gasper 7ac4c7afb7 Merge branch 'master' of https://github.com/jasig/java-cas-client into CASC-210 2014-04-11 15:17:29 -07:00
LELEU Jérôme 4e7bf66d68 Merge pull request #68 from leleuj/CASC-220
CASC-220: Support front channel SLO logout
2014-04-09 08:10:42 +02:00
Jérôme LELEU c4c3223140 CASC-220: Support front channel SLO logout
Update after new Misagh's comments
2014-04-07 18:54:40 +02:00
LELEU Jerome 4a0e960c32 CASC-220: Support front channel SLO logout
Updates after Marvin's code review
2014-04-01 16:46:19 +02:00
Jérôme LELEU 7069a4f6fb CASC-220: Support front channel SLO logout
Update after Scott's code review
2014-03-27 21:02:30 +01:00
Jérôme LELEU 6aa2379268 CASC-220: Support front channel SLO logout
Updates after Misagh's code review
2014-03-21 14:10:33 +01:00
Scott Battaglia 72766daac5 Added in missing license header. 2014-03-18 19:26:45 -04:00
unknown 9714053f07 Merge remote-tracking branch 'upstream/master' into CASC-220 2014-03-18 08:16:29 +01:00
Misagh Moayyed 286105266f Merge pull request #67 from battags/CASC-214
CASC-214 Improve Service Url Construction to Add Non-Standard Ports
2014-03-17 09:15:29 -07:00
Misagh Moayyed ed4802f943 CASC-219: added final 2014-03-17 00:18:56 -07:00
LELEU Jerome 9b33321cc2 CASC-220: Support front channel SLO logout
specific front logout parameter + Tomcat valves update
2014-03-14 10:52:42 +01:00
LELEU Jerome 47f825871e CASC-220: Support front channel SLO logout
First commit
2014-03-13 19:03:41 +01:00
Misagh Moayyed d2b93a237f CASC-219: added exact-matcher strategy 2014-03-13 08:26:22 -07:00
Misagh Moayyed 0a8fd79a44 CASC-219: changed exact to contains 2014-03-13 03:20:39 -07:00
Misagh Moayyed 00ee9e378d CASC-219: renamed matcher class to match behavior 2014-03-12 07:37:59 -07:00
Misagh Moayyed 248643cf30 CASC-219: switched warn to error, fixed typo and this refs 2014-03-11 08:46:00 -07:00
Misagh Moayyed dfb3629dc2 CASC-219: updated internal map to be a static ref instead 2014-03-11 07:11:53 -07:00
Misagh Moayyed 511bce2471 CASC-219: allowed extensions for ignoring urls 2014-03-11 05:04:59 -07:00
Misagh Moayyed 3773fc9e54 CASC-219: updated javadocs and added map to keep track of pattern matchers 2014-03-11 04:24:27 -07:00
Misagh Moayyed b97d03d126 CASC-219: Cleaned up formatting issues 2014-03-10 05:22:44 -07:00
Scott Battaglia a4df6582ee Removed debug statements used to confirm private methods worked. 2014-03-09 23:18:14 -04:00
Scott Battaglia 75584a2c33 CASC-214 Improve Service Url Construction to Add Non-Standard Ports if Missing from Configuration
Problem: sometimes the port is missing from the configuration.  This generates the wrong service url.
Solution: Add the server port if the server configuration does not have one.
QA Notes: Added unit tests to confirm behavior (and old unit tests still pass)
2014-03-09 23:13:04 -04:00
John Gasper 0ef575ae84 Refactored the match logic and cache the regex patterns. 2014-03-07 16:11:00 -08:00
Misagh Moayyed 71b366cbf3 CASC-219: Provide support for certain urls to be excluded from CAS filters. 2014-03-07 11:17:14 -07:00
Misagh Moayyed b9ac92cf25 CASC-219: Provide support for certain urls to be excluded from CAS filters. 2014-03-07 01:52:50 -07:00
John Gasper 887da3bffd no message 2014-03-05 10:54:34 -08:00
John Gasper 90ccc41db3 Minor corrections. 2014-03-05 10:45:35 -08:00
John Gasper 80ff9857f0 Added support for having regex expressions in the proxy (chaining) list. 2014-03-05 10:17:59 -08:00