Commit Graph

60 Commits

Author SHA1 Message Date
Diego Sanchez da05cb2a09 Relax MessageModelProtocol and MessageViewModelProtocol requirements.
MessageModelProtocol should not require setter for status property.
MessageViewModelProtocol should not require messageModel property.

Both are convenience shortcuts for DemoChatApp and should be removed since they are not used by ChattoAdditions framework.
2016-02-18 12:37:50 +00:00
Diego Sánchez 7df96b0122 Merge pull request #39 from diegosanchezr/dev
Exposes ChatItemCompanion
2016-02-16 17:28:32 +00:00
Diego Sanchez 3d371a8113 Exposes chatItemCompanionCollection 2016-02-09 16:15:55 +00:00
Diego Sanchez bdb01e4a40 Allows data source to trigger updates with concrete context. Basically this allows to trigger some updates with a non-animated reloadData while others will be animated (performBatchUpdates) 2016-02-09 16:13:43 +00:00
Diego Sánchez e7e58ae8a1 Merge pull request #36 from diegosanchezr/dev
Allows a datasource to return different chatItem instances for same message id
2016-02-08 18:26:17 +00:00
Diego Sanchez 4086d458e3 Allows a datasource to return different chatItem instances when it updates.
Previously, due to the mapping between chatItem instance and presenter, a new presenter would be created. This fixes:
1) That new presenter will have invalid itemVisibility property (would cause a crash when long pressing a text cell)
2) If a new chatItem instance is returned by the dataSource for a previous existing message, but the previous chatItem is leaked, then the presenter would leak too (and it might try to update its cell, as in downloading an image)

This introduces ChatItemCompanion, a structure which attaches a ChatItem with its presenter and decoration attributes. This solves 1) and 2). Still new instances of presenters will be created for new instances of chatItems --> Presenters should avoid keeping any state in its internal storage.
2016-02-08 17:55:23 +00:00
Diego Sánchez 91ce42211c Merge pull request #35 from diegosanchezr/dev
Relaxes generic constraints in Presenters
2016-02-03 14:48:00 +00:00
Diego Sanchez 8d76d5f30d Updates readme 2016-02-03 13:41:50 +00:00
Diego Sanchez 99e30d85d4 Makes PhotoMessageViewModelDefaultBuilder generic so it can build view models from different concrete models 2016-02-03 13:36:23 +00:00
Diego Sanchez a040604f05 Makes TextMessageViewModelDefaultBuilder generic so it can build view models from different concrete models 2016-02-03 13:36:23 +00:00
Diego Sanchez d46bdb214c Relaxes generic constraints so presenters can be reused with different models 2016-02-03 13:06:03 +00:00
Diego Sánchez 6c27548425 Merge pull request #33 from diegosanchezr/dev
Updates with master
2016-02-02 18:11:13 +00:00
Diego Sanchez 1c1ae439dd Merge remote-tracking branch 'upstream/master' into dev 2016-02-02 17:37:23 +00:00
Diego Sánchez cbe74fcffa Merge pull request #32 from diegosanchezr/master
Renames BMACircle* -> Circle*
2016-02-02 17:32:34 +00:00
Diego Sanchez fb1c3ad04a Renames BMACircle* -> Circle* 2016-02-02 17:19:44 +00:00
Diego Sánchez 35ad7c2b19 Merge pull request #31 from diegosanchezr/dev
Renames ChatViewController -> BaseChatViewController
2016-02-01 15:03:53 +00:00
Diego Sanchez a8933a3791 Renames ChatViewController -> BaseChatViewController 2016-02-01 14:57:06 +00:00
Diego Sánchez 99b6d7ec5e Merge pull request #29 from diegosanchezr/master
Fixes scrollToBottom when typing very fast
2016-02-01 11:43:04 +00:00
Diego Sanchez 148b64c996 Fixes scrollToBottom when typing very fast. Also fixes floating point rounding issue (it was showing on iPhone 6+) 2016-02-01 11:20:19 +00:00
Diego Sánchez 2cdbdc9063 Merge pull request #24 from diegosanchezr/master
Removes deprecated '++/--'. Fixes linter issues.
2016-01-27 22:57:03 +00:00
Diego Sanchez a0a071afa8 Fixes linter warnings and updates some rules. Also removes deprecated '++' and '--' 2016-01-27 22:04:32 +00:00
Diego Sánchez 1178258e56 Merge pull request #22 from diegosanchezr/master
Workaround for automaticallyAdjustsScrollViewInsets bug on iOS 9.0.x
2016-01-23 23:11:36 +00:00
Diego Sanchez d3ed032f31 Fixes defaultContentInsets casing 2016-01-23 22:43:46 +00:00
Diego Sanchez cad19d0c2e Workaround for automaticallyAdjustsScrollViewInsets bug on iOS 9.0.x 2016-01-23 22:35:42 +00:00
Diego Sánchez 370c925104 Merge pull request #19 from diegosanchezr/master
Run ChattoApp tests and bump to Xcode 7.2
2016-01-14 20:09:08 +00:00
Diego Sanchez 2f1755b25e Run tests on iOS 9.2 2016-01-14 20:02:14 +00:00
Diego Sánchez 44f017eac7 Moves Carthage section up in readme 2016-01-14 19:57:06 +00:00
Diego Sanchez e650508527 Uses Xcode 7.2 in travis builds 2016-01-14 19:46:36 +00:00
Diego Sanchez 3083370549 Reverts change in .travis.yml so ChatoApp is built again 2016-01-14 19:45:48 +00:00
Diego Sánchez fa4d839478 Merge pull request #18 from nrako/carthage
Add support for Carthage
2016-01-14 19:40:01 +00:00
nrako fc3fb10891 Fixe Travis build by using root xcworkspace 2016-01-14 20:31:34 +01:00
nrako ef03af8f16 Adds Chatto support 2016-01-14 17:08:31 +01:00
nrako 8bbdb18d2e Links Chatto.framework into ChattoAdditions 2016-01-14 16:29:14 +01:00
nrako b068d18bab Move shared schemes in Workspace
required by carthage
2016-01-14 11:49:25 +01:00
nrako a200fa413c Adds Xcode Workspace
required by carthage, carthage wants a single point of entry
(workspace) to exports multiple shared scheme in separate projects
2016-01-14 11:34:13 +01:00
Diego Sánchez fef8a20482 Merge pull request #11 from zwang/master
resolve compile warning about variable never read
2015-12-18 00:47:56 +01:00
Zhao Wang 0b554deb12 resolve compile warning about variable never read 2015-12-17 15:38:42 -08:00
Diego Sánchez f870d5b30f Merge pull request #10 from zwang/master
remove redundant "self" in a method
2015-12-18 00:34:25 +01:00
Zhao Wang 47d8c2f1a7 remove redundant "self" 2015-12-17 15:14:12 -08:00
Diego Sánchez 7e4ede7d19 Merge pull request #7 from zwang/master 2015-12-12 17:08:37 +00:00
Zhao Wang f9ecb0ef6a Merge pull request #1 from badoo/master
Merge from badoo/chatto
2015-12-12 08:20:47 -08:00
Diego Sánchez 4a8e525915 Merge pull request #8 from diegosanchezr/master
Tentative fix for flaky code coverage report
2015-12-12 15:23:31 +00:00
Diego Sanchez 171729525b Tentative fix for flaky code coverage report 2015-12-12 15:12:15 +00:00
Zhao Wang 84052f3b8d Add "default" case for "switch" block to eliminate Xcode warnings
Xcode is complaining enumerations values not handled.
2015-12-11 22:37:00 -08:00
Rafael López Diez 32920729ce Merge pull request #4 from AntonPalich/Article_Link
Added link to the article
2015-12-07 13:36:03 +00:00
Anton Schukin f2b4afbed8 Added link to the article 2015-12-07 12:45:00 +00:00
Diego Sánchez 85d290ddcb Merge pull request #3 from diegosanchezr/master
Runs tests on iPhone 6, iOS 9.
2015-12-01 00:07:58 +00:00
Diego Sanchez fb43157ff9 Runs tests on iPhone 6, iOS 9.1 2015-11-30 23:58:48 +00:00
Diego Sánchez 14378e5098 Merge pull request #2 from diegosanchezr/master
Typos in readme and makes travis build ChattoApp
2015-11-30 23:54:04 +00:00
Diego Sanchez 7b01ea2aeb Runs tests on iPhone 6, iOS 9.1 2015-11-30 23:43:17 +00:00