Commit Graph

1164 Commits

Author SHA1 Message Date
Unrud 9d2743d797 Test authorization 2016-09-01 06:15:31 +02:00
Guillaume Ayoub e25373fa85 Merge pull request #501 from Unrud/httperrors
HTTP error messages
2016-08-31 14:49:19 +02:00
Guillaume Ayoub 8d92b371e4 Merge pull request #502 from Unrud/patch-40
Plain text for GET / instead of malformed HTML
2016-08-31 14:42:59 +02:00
Guillaume Ayoub db681da08e Merge pull request #500 from Unrud/loginuser
Map logins to internal users in Auth module
2016-08-31 14:40:08 +02:00
Unrud f875bcd892 Plain text for GET / instead of malformed HTML
It's basically the same in browsers and looks nicer in tools that don't support HTML rendering (like curl).
2016-08-31 02:01:18 +02:00
Unrud ff2b8f6e5c Use NOT_FOUND instead of GONE
Thunderbird doesn't recognize the status code correctly and shows an synchronization error.
2016-08-31 01:54:31 +02:00
Unrud 1ea9b1dca9 Return error for GET requests on directories
Radicale doesn't support directory listings.
2016-08-31 00:45:14 +02:00
Unrud 4ac2e68f5c Add HTTP error messages
Browsers just show a blank page if an error occurs. You have to open the developer tools to see the HTTP status code. E.g. a user wants to download a calendar in the browser and the URL is wrong.

Some tools like curl don't show any indication of an error.
2016-08-31 00:41:08 +02:00
Unrud 689e5c9dd5 Map logins to internal users in Auth module
This makes it possible to implement #349 as a Auth module. Another use case would be to encode usernames that contain characters unsupported by the file system.
2016-08-30 23:13:33 +02:00
Guillaume Ayoub 5f46cc24bd Merge pull request #497 from Unrud/patch-38
Add thread id to log
2016-08-30 19:16:54 +02:00
Guillaume Ayoub 3c32df3d9a Merge pull request #496 from Unrud/patch-37
Remove empty line in log
2016-08-30 19:16:19 +02:00
Unrud b2f11a7c18 Add thread id to log
Make log messages from parallel request allocable.
2016-08-30 14:06:34 +02:00
Unrud e782808a14 Remove empty line in log
Separating requests by an empty line doesn't work any longer with parallel (overlapping) requests.
2016-08-30 14:04:16 +02:00
Guillaume Ayoub 5d9485d660 Merge pull request #495 from untitaker/trailing-slash-fix
Don't return `<item>/` for events
2016-08-29 21:31:25 +02:00
Markus Unterwaditzer 90e4655a44 Don't return `<item>/` for events 2016-08-29 17:29:46 +02:00
Guillaume Ayoub 947c57312c Fix a variable name
Fix #494
2016-08-29 12:09:17 +02:00
Guillaume Ayoub 34ad1b9073 Remove useless import 2016-08-29 12:07:58 +02:00
Guillaume Ayoub fd1742fcea Fix typo 2016-08-29 12:07:30 +02:00
Guillaume Ayoub a25374000b Merge branch 'Unrud-remupdate' 2016-08-26 22:50:45 +02:00
Guillaume Ayoub 9e78454da2 Merge branch 'remupdate' of https://github.com/Unrud/Radicale into Unrud-remupdate 2016-08-26 22:50:26 +02:00
Guillaume Ayoub a3dcfaacd6 Merge pull request #491 from Unrud/uploadall
Optimize upload of whole collections
2016-08-26 22:34:46 +02:00
Guillaume Ayoub ac61b18237 Merge pull request #490 from Unrud/hook
Move hook into storage.Collection
2016-08-26 15:58:42 +02:00
Guillaume Ayoub 0e646cdae4 Merge branch 'Unrud-logging' 2016-08-25 11:52:12 +02:00
Guillaume Ayoub bae6374e37 Merge pull request #489 from Unrud/utf8
Try to decode URLs with utf-8 (Fixes #486)
2016-08-25 11:46:15 +02:00
Unrud c5342d36d5 Remove BaseCollection.update
I don't think that this can be used for optimizations.

It's useless in the filesystem backend, SQL has REPLACE and I doubt that there is much use in any other storage mechanism.
2016-08-25 06:37:12 +02:00
Unrud ea63f461a8 Rename upload_all to upload_all_nonatomic 2016-08-25 06:03:13 +02:00
Unrud 30d287ce00 Write files nonatomic in upload_all
It's only used in temporary collections.
2016-08-25 06:03:13 +02:00
Unrud e31ea57883 Use upload_all for addressbook 2016-08-25 06:03:13 +02:00
Unrud bc0f8b0a47 Remove duplicate code 2016-08-25 06:03:13 +02:00
Unrud c57307c585 Rename collections to vobject_items
Like the parameter name of upload_all
2016-08-25 05:52:26 +02:00
Unrud 6045ad97fe Move upload_all from BaseCollection to Collection
This is not used anywhere outside of Collection and probably never will be as WebDAV doesn't support bulk uploads.
2016-08-25 05:47:31 +02:00
Unrud 10786cbad8 Move hook into storage.Collection
The hook is only valid for filesystem storage, it's meaningless for other backends like databases.
2016-08-25 05:40:46 +02:00
Unrud 8db580abce Try to decode URLs with utf-8 (Fixes #486) 2016-08-25 05:30:46 +02:00
Unrud e40e46e164 Don't disable existing loggers
The logger is retrieved before configure_from_file is called and gets disabled, the same happens when the logging configuration is reloaded.
2016-08-25 05:24:29 +02:00
Unrud de8c2f0909 Fix SIGHUP handler
The function handler_generator seems useless and the return statement is missing.
2016-08-25 05:24:29 +02:00
Unrud 3b71ab960e Log exceptions (Fixes #447)
Exceptions were just written to stderr but not into logs.
2016-08-25 05:24:24 +02:00
Unrud c091399f5e Write log to stderr
Be consistent with python's default behavior and play nice with CGI.
2016-08-25 05:19:38 +02:00
Unrud 14515cfe27 Fix logger configuration
Apply patch from #485
2016-08-25 04:29:02 +02:00
Guillaume Ayoub 79bfa9c1d3 Merge pull request #482 from Unrud/smallimprovements
Some small cosmetic improvements for xmlutils
2016-08-24 18:11:06 +02:00
Guillaume Ayoub c532948348 Merge pull request #487 from Unrud/filter
Fix empty filter
2016-08-24 18:10:03 +02:00
Unrud f9cabfb20b Test empty filter
Test for d1dbd1df54
2016-08-24 17:52:39 +02:00
Unrud d1dbd1df54 Fix empty filter
DAVdroid sends <CARD:filter />, which causes an exception.
2016-08-24 17:45:10 +02:00
Unrud 469efbb032 Cosmetics 2016-08-13 04:52:51 +02:00
Unrud 453a8ba636 Fix "fix this" in xmlutils 2016-08-13 04:51:42 +02:00
Unrud ecd0a16214 Remove unused variable path 2016-08-13 04:48:59 +02:00
Unrud 1c6e626979 Simplify name_from_path and add error check 2016-08-13 04:47:35 +02:00
Guillaume Ayoub 3b29a56c81 Merge pull request #480 from Unrud/currentuserprincipal
Ask for authentication if current-user-principal is requested
2016-08-13 04:25:55 +02:00
Guillaume Ayoub c9ac3114af Merge pull request #481 from Unrud/patch-35
Revert 1ffc171
2016-08-13 04:22:13 +02:00
Unrud c29fd1ca61 Check that item is a collection 2016-08-13 00:19:14 +02:00
Unrud cf4a6ef749 Revert 1ffc171f35
Maybe I misunderstand the RFC, but this properties are related to a principal collection. DAVdroid without preemptive authentication doesn't like this and tries to create calendars and addressbooks in /.
2016-08-13 00:17:50 +02:00