some annotation rules added

This commit is contained in:
Gavriil Sitnikov 2016-06-11 18:07:32 +03:00
parent 68b50a3156
commit 2bd7e1e967
2 changed files with 22 additions and 8 deletions

View File

@ -20,6 +20,7 @@
package ru.touchin.roboswag.components.navigation;
import android.os.Bundle;
import android.support.annotation.CallSuper;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.annotation.StringRes;
@ -74,7 +75,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* @return Returns activity.
*/
@NonNull
public TActivity getActivity() {
public final TActivity getActivity() {
return activity;
}
@ -84,7 +85,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* @return Returns fragment.
*/
@NonNull
public TFragment getFragment() {
public final TFragment getFragment() {
return fragment;
}
@ -95,7 +96,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* @return Returns view.
*/
@NonNull
public ViewGroup getContainer() {
public final ViewGroup getContainer() {
return container;
}
@ -104,7 +105,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
*
* @return True if it is destroyed.
*/
public boolean isDestroyed() {
public final boolean isDestroyed() {
return destroyed;
}
@ -141,19 +142,19 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
@NonNull
@Override
public <T> Subscription bind(@NonNull final Observable<T> observable, @NonNull final Action1<T> onNextAction) {
public final <T> Subscription bind(@NonNull final Observable<T> observable, @NonNull final Action1<T> onNextAction) {
return baseUiBindable.bind(observable, onNextAction);
}
@NonNull
@Override
public <T> Observable<T> untilStop(@NonNull final Observable<T> observable) {
public final <T> Observable<T> untilStop(@NonNull final Observable<T> observable) {
return baseUiBindable.untilStop(observable);
}
@NonNull
@Override
public <T> Observable<T> untilDestroy(@NonNull final Observable<T> observable) {
public final <T> Observable<T> untilDestroy(@NonNull final Observable<T> observable) {
return baseUiBindable.untilDestroy(observable);
}
@ -161,6 +162,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* Calls right after construction of {@link ViewController}.
* Happens at {@link ViewControllerFragment#onActivityCreated(View, ViewControllerActivity, Bundle)}.
*/
@CallSuper
public void onCreate() {
baseUiBindable.onCreate();
}
@ -169,6 +171,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* Calls when {@link ViewController} have started.
* Happens at {@link ViewControllerFragment#onStart(View, ViewControllerActivity)}.
*/
@CallSuper
public void onStart() {
baseUiBindable.onStart();
}
@ -178,6 +181,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* Happens at {@link ViewControllerFragment#onSaveInstanceState(Bundle)}.
* Try not to use such method for saving state but use {@link ViewControllerFragment#getState()} from {@link #getFragment()}.
*/
@CallSuper
public void onSaveInstanceState(@NonNull final Bundle savedInstanceState) {
// do nothing
}
@ -186,6 +190,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* Calls when {@link ViewController} have stopped.
* Happens at {@link ViewControllerFragment#onStop(View, ViewControllerActivity)}.
*/
@CallSuper
public void onStop() {
baseUiBindable.onStop();
}
@ -194,6 +199,7 @@ public class ViewController<TActivity extends ViewControllerActivity<?>,
* Calls when {@link ViewController} have destroyed.
* Happens usually at {@link ViewControllerFragment#onDestroyView(View)}. In some cases at {@link ViewControllerFragment#onDestroy()}.
*/
@CallSuper
public void onDestroy() {
baseUiBindable.onDestroy();
destroyed = true;

View File

@ -20,6 +20,7 @@
package ru.touchin.roboswag.components.navigation.fragments;
import android.os.Bundle;
import android.support.annotation.CallSuper;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v4.app.Fragment;
@ -57,7 +58,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
*/
@SuppressWarnings("unchecked")
@Nullable
protected TActivity getBaseActivity() {
protected final TActivity getBaseActivity() {
if (getActivity() == null) {
return null;
}
@ -79,6 +80,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
}
@Override
@CallSuper
public void onFragmentStarted(@NonNull final Fragment fragment) {
//do nothing
}
@ -101,6 +103,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
* @param activity Activity which fragment attached to.
* @param savedInstanceState If the fragment is being re-created from a previous saved state, this is the state.
*/
@CallSuper
public void onActivityCreated(@NonNull final View view, @NonNull final TActivity activity, @Nullable final Bundle savedInstanceState) {
//do nothing
}
@ -126,6 +129,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
* @param view Instantiated view.
* @param activity Activity which fragment attached to.
*/
@CallSuper
protected void onStart(@NonNull final View view, @NonNull final TActivity activity) {
if (getParentFragment() instanceof OnFragmentStartedListener) {
((OnFragmentStartedListener) getParentFragment()).onFragmentStarted(this);
@ -147,6 +151,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
* @param view Instantiated view.
* @param activity Activity which fragment attached to.
*/
@CallSuper
protected void onResume(@NonNull final View view, @NonNull final TActivity activity) {
//do nothing
}
@ -164,6 +169,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
* @param view Instantiated view.
* @param activity Activity which fragment attached to.
*/
@CallSuper
protected void onPause(@NonNull final View view, @NonNull final TActivity activity) {
//do nothing
}
@ -181,6 +187,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
* @param view Instantiated view.
* @param activity Activity which fragment attached to.
*/
@CallSuper
protected void onStop(@NonNull final View view, @NonNull final TActivity activity) {
//do nothing
}
@ -201,6 +208,7 @@ public abstract class ViewFragment<TActivity extends AppCompatActivity> extends
*
* @param view Instantiated view.
*/
@CallSuper
protected void onDestroyView(@NonNull final View view) {
//do nothing
}