TouchInstinct
/
checkstyle
311
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change name of private method conflicting with superclass method. #1555 

Fixes `MethodOverridesPrivateMethod` inspection violations.

Description:
>Reports instance methods having the same name as a private method of a superclass. Such methods may result in confusing semantics, particularly if the private method is ever made publicly visible.
This commit is contained in:
Michal Kordas 2015-08-12 23:16:56 +02:00 committed by Roman Ivanov
parent 9a58272093
commit 26ffb0af87
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java
View File

@ -68,7 +68,7 @@ public class ArrayInitHandler extends BlockParentHandler {
@Override
protected IndentLevel curlyLevel() {
final IndentLevel level = new IndentLevel(getLevel(), getBraceAdjustment());
level.addAcceptedIndent(level.getLastIndentLevel() + getLineWrappingIndent());
level.addAcceptedIndent(level.getLastIndentLevel() + getLineWrappingIndentation());
return level;
}
@ -104,7 +104,7 @@ public class ArrayInitHandler extends BlockParentHandler {
getNextFirstNonblankOnLineAfter(firstLine, lcurlyPos);
if (firstChildPos >= 0) {
expectedIndent.addAcceptedIndent(firstChildPos);
expectedIndent.addAcceptedIndent(lcurlyPos + getLineWrappingIndent());
expectedIndent.addAcceptedIndent(lcurlyPos + getLineWrappingIndentation());
}
return expectedIndent;
}
@ -134,7 +134,7 @@ public class ArrayInitHandler extends BlockParentHandler {
* @return value of lineWrappingIndentation property
* of {@code IndentationCheck}
*/
private int getLineWrappingIndent() {
private int getLineWrappingIndentation() {
return getIndentCheck().getLineWrappingIndentation();
}
}

4
src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ObjectBlockHandler.java
View File

@ -93,7 +93,7 @@ public class ObjectBlockHandler extends BlockParentHandler {
final DetailAST rcurly = getRCurly();
final int rcurlyPos = expandedTabsColumnNo(rcurly);
final IndentLevel level = curlyLevel();
level.addAcceptedIndent(level.getFirstIndentLevel() + getLineWrappingIndent());
level.addAcceptedIndent(level.getFirstIndentLevel() + getLineWrappingIndentation());
if (!level.accept(rcurlyPos) && startsLine(rcurly)) {
logError(rcurly, "rcurly", rcurlyPos, curlyLevel());
@ -105,7 +105,7 @@ public class ObjectBlockHandler extends BlockParentHandler {
* @return value of lineWrappingIndentation property
* of {@code IndentationCheck}
*/
private int getLineWrappingIndent() {
private int getLineWrappingIndentation() {
return getIndentCheck().getLineWrappingIndentation();
}
}