TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove dead code from JavadocType check. #1308

This commit is contained in:
Michal Kordas 2015-07-24 18:06:03 +02:00 committed by Roman Ivanov
parent ccb3b8a5a9
commit 365ff682db
2 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pom.xml
View File

@ -1144,7 +1144,6 @@
<regex><pattern>.*.checks.javadoc.JavadocMethodCheck</pattern><branchRate>91</branchRate><lineRate>98</lineRate></regex>
<regex><pattern>.*.checks.javadoc.JavadocParagraphCheck</pattern><branchRate>92</branchRate><lineRate>100</lineRate></regex>
<regex><pattern>.*.checks.javadoc.JavadocStyleCheck</pattern><branchRate>89</branchRate><lineRate>98</lineRate></regex>
<regex><pattern>.*.checks.javadoc.JavadocTypeCheck</pattern><branchRate>95</branchRate><lineRate>93</lineRate></regex>
<regex><pattern>.*.checks.javadoc.JavadocUtils</pattern><branchRate>94</branchRate><lineRate>100</lineRate></regex>
<regex><pattern>.*.checks.javadoc.TagParser</pattern><branchRate>92</branchRate><lineRate>98</lineRate></regex>
<regex><pattern>.*.checks.javadoc.WriteTagCheck</pattern><branchRate>100</branchRate><lineRate>91</lineRate></regex>

29
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java
View File

@ -295,7 +295,6 @@ public class JavadocTypeCheck
for (int i = tags.size() - 1; i >= 0; i--) {
final JavadocTag tag = tags.get(i);
if (tag.isParamTag()
&& tag.getArg1() != null
&& tag.getArg1().indexOf("<" + typeParamName + ">") == 0) {
found = true;
}
@ -319,28 +318,14 @@ public class JavadocTypeCheck
final JavadocTag tag = tags.get(i);
if (tag.isParamTag()) {
if (tag.getArg1() != null) {
final Matcher matcher = pattern.matcher(tag.getArg1());
String typeParamName = null;
if (matcher.matches()) {
typeParamName = matcher.group(1).trim();
if (!typeParamNames.contains(typeParamName)) {
log(tag.getLineNo(), tag.getColumnNo(),
UNUSED_TAG,
JavadocTagInfo.PARAM.getText(),
"<" + typeParamName + ">");
}
}
else {
log(tag.getLineNo(), tag.getColumnNo(),
UNUSED_TAG_GENERAL);
}
}
else {
final Matcher matcher = pattern.matcher(tag.getArg1());
matcher.find();
final String typeParamName = matcher.group(1).trim();
if (!typeParamNames.contains(typeParamName)) {
log(tag.getLineNo(), tag.getColumnNo(),
UNUSED_TAG_GENERAL);
UNUSED_TAG,
JavadocTagInfo.PARAM.getText(),
"<" + typeParamName + ">");
}
}
}