Added "source" attribute to "error" element of XMLLogger output.

This commit is contained in:
Rick Giles 2003-05-10 10:59:20 +00:00
parent b5203fd519
commit 61e6ce5ee7
3 changed files with 20 additions and 6 deletions

View File

@ -122,6 +122,11 @@
<li class="body">One more option for JavadocMethodCheck
(allowThrowsTagsForSubclasses, request 540383)</li>
<li class="body">Added sourceName property to AuditEvent
and LocalizedMessage; and &quot;source&quot; attribute
to &quot;error&quot; element of XMLLogger output
(request 686336).</li>
</ul>
<p class="body">

View File

@ -117,8 +117,11 @@ public class XMLLogger
mWriter.print(" severity=\""
+ aEvt.getSeverityLevel().getName()
+ "\"");
mWriter.println(" message=\""
mWriter.print(" message=\""
+ encode(aEvt.getMessage())
+ "\"");
mWriter.println(" source=\""
+ encode(aEvt.getSourceName())
+ "\"/>");
}
}

View File

@ -9,6 +9,7 @@ import java.io.PrintWriter;
import java.util.ArrayList;
import com.puppycrawl.tools.checkstyle.api.LocalizedMessage;
import com.puppycrawl.tools.checkstyle.api.SeverityLevel;
import junit.framework.TestCase;
@ -121,18 +122,23 @@ public class XMLLoggerTest extends TestCase
verifyLines(expectedLines);
}
public void testAddError()
throws IOException
{
public void testAddError() throws IOException {
final XMLLogger logger = new XMLLogger(outStream, true);
logger.auditStarted(null);
final LocalizedMessage message =
new LocalizedMessage( 1, 1, "messages.properties", "key", null);
new LocalizedMessage(
1,
1,
"messages.properties",
"key",
null,
SeverityLevel.ERROR,
"aSource");
final AuditEvent ev = new AuditEvent(this, "Test.java", message);
logger.addError(ev);
logger.auditFinished(null);
final String[] expectedLines =
{"<error line=\"1\" column=\"1\" severity=\"error\" message=\"key\"/>"};
{"<error line=\"1\" column=\"1\" severity=\"error\" message=\"key\" source=\"aSource\"/>"};
verifyLines(expectedLines);
}