Issue #2080: Add missing assertions to utils tests

Fixes some `TestMethodWithoutAssertion` inspection violations.

Description:
>Reports test methods of JUnit test case classes that do not contain any assertions. Such methods indicate either incomplete or weak test cases.
This commit is contained in:
Michal Kordas 2015-09-04 22:15:54 +02:00 committed by Roman Ivanov
parent 7a873e1333
commit 6839ac4fd8
3 changed files with 18 additions and 8 deletions

View File

@ -20,6 +20,7 @@
package com.puppycrawl.tools.checkstyle.utils;
import static com.puppycrawl.tools.checkstyle.TestUtils.assertUtilsClassHasPrivateConstructor;
import static org.junit.Assert.assertEquals;
import org.junit.Assert;
import org.junit.Test;
@ -35,8 +36,9 @@ public class CheckUtilsTest {
}
@Test
public void testParseDouble() throws Exception {
CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN);
public void testParseDoubleWithIncorrectToken() throws Exception {
double parsedDouble = CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN);
assertEquals(0.0, parsedDouble, 0.0);
}
@Test

View File

@ -170,14 +170,12 @@ public class CommonUtilsTest {
@Test
public void testClose() {
TestCloseable closeable = new TestCloseable();
CommonUtils.close(null);
CommonUtils.close(closeable);
CommonUtils.close(new Closeable() {
@Override
public void close() {
}
});
assertTrue(closeable.closed);
}
@Test(expected = IllegalStateException.class)
@ -190,4 +188,13 @@ public class CommonUtilsTest {
}
});
}
private static class TestCloseable implements Closeable {
private boolean closed;
@Override
public void close() {
closed = true;
}
}
}

View File

@ -51,6 +51,7 @@ public class TokenUtilsTest {
try {
TokenUtils.getIntFromField(field, 0);
fail();
}
catch (IllegalStateException expected) {
// expected