TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

re-ordered tests for efficiency

This commit is contained in:
Rick Giles 2003-06-26 17:51:11 +00:00
parent e03dd7a0a0
commit 9eb27f99a3
1 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/checkstyle/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheck.java
View File

@ -143,29 +143,25 @@ public class CovariantEqualsCheck
public void visitToken(DetailAST aAST)
{
if (aAST.getType() == TokenTypes.METHOD_DEF) {
final DetailAST definer = getDefiner(aAST);
final int type = definer.getType();
if ((type == TokenTypes.CLASS_DEF)
|| (type == TokenTypes.LITERAL_NEW))
{
if (isEqualsMethod(aAST) && !ScopeUtils.inInterfaceBlock(aAST)) {
final DetailAST definer = getDefiner(aAST);
if (mClassStack.isEmpty()) {
mClassStack.add(new ClassAttributes(definer));
}
final ClassAttributes attrs =
(ClassAttributes) mClassStack.getLast();
ClassAttributes attrs =
(ClassAttributes) mClassStack.getLast();
final DetailAST currentRoot = attrs.getRootAST();
if (definer != currentRoot) {
mClassStack.add(new ClassAttributes(definer));
final ClassAttributes definerAttrs =
new ClassAttributes(definer);
mClassStack.add(definerAttrs);
attrs = definerAttrs;
}
if (!ScopeUtils.inInterfaceBlock(aAST)
&& isEqualsMethod(aAST))
{
if (hasObjectParameter(aAST)) {
attrs.setHasEqualsObject();
}
else {
attrs.addEqualsNode(aAST);
}
if (hasObjectParameter(aAST)) {
attrs.setHasEqualsObject();
}
else {
attrs.addEqualsNode(aAST);
}
}
}