TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Visibility Modifier Check, updated option setter, issue #710

This commit is contained in:
alexkravin 2015-03-04 00:09:17 +04:00 committed by Roman Ivanov
parent a2f74423b6
commit de4485a22b
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheck.java
View File

@ -293,7 +293,7 @@ public class VisibilityModifierCheck
* Set the list of immutable classes types names.
* @param classNames array of immutable types short names.
*/
public void setImmutableClassNames(String[] classNames)
public void setImmutableClassCanonicalNames(String[] classNames)
{
immutableClassCanonicalNames = Arrays.asList(classNames);
}

9
src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java
View File

@ -113,7 +113,7 @@ public class VisibilityModifierCheckTest
{
final DefaultConfiguration checkConfig =
createCheckConfig(VisibilityModifierCheck.class);
checkConfig.addAttribute("immutableClassNames", "java.util.List,"
checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.List,"
+ "com.google.common.collect.ImmutableSet");
final String[] expected = {
"14:35: " + getCheckMessage(MSG_KEY, "notes"),
@ -133,7 +133,7 @@ public class VisibilityModifierCheckTest
{
final DefaultConfiguration checkConfig =
createCheckConfig(VisibilityModifierCheck.class);
checkConfig.addAttribute("immutableClassNames",
checkConfig.addAttribute("immutableClassCanonicalNames",
"com.puppycrawl.tools.checkstyle.coding.GregorianCalendar,"
+ "com.puppycrawl.tools.checkstyle.InetSocketAddress");
final String[] expected = {
@ -162,7 +162,7 @@ public class VisibilityModifierCheckTest
{
final DefaultConfiguration checkConfig =
createCheckConfig(VisibilityModifierCheck.class);
checkConfig.addAttribute("immutableClassNames", "java.util.Arrays");
checkConfig.addAttribute("immutableClassCanonicalNames", "java.util.Arrays");
final String[] expected = {
};
verify(checkConfig, getPath("InputImmutableStarImport.java"), expected);
@ -173,7 +173,8 @@ public class VisibilityModifierCheckTest
{
final DefaultConfiguration checkConfig =
createCheckConfig(VisibilityModifierCheck.class);
checkConfig.addAttribute("immutableClassNames", "com.google.common.collect.ImmutableSet");
checkConfig.addAttribute("immutableClassCanonicalNames",
"com.google.common.collect.ImmutableSet");
final String[] expected = {
};
verify(checkConfig, getPath("InputImmutableStarImport2.java"), expected);