TouchInstinct
/
checkstyle
306
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use Collections.addAll() instead of adding elements individually 

As per javadoc, `Collections.addAll()` may be significantly faster than adding elements individually using a for loop.
This commit is contained in:
Michal Kordas 2015-02-08 21:02:28 +01:00 committed by Roman Ivanov
parent e9f49b799b
commit dfc803a1cc
5 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/com/puppycrawl/tools/checkstyle/api/Check.java
View File

@ -18,6 +18,7 @@
////////////////////////////////////////////////////////////////////////////////
package com.puppycrawl.tools.checkstyle.api;
import java.util.Collections;
import java.util.Set;
import com.google.common.collect.Sets;
@ -98,9 +99,7 @@ public abstract class Check extends AbstractViolationReporter
*/
public final void setTokens(String[] strRep)
{
for (final String s : strRep) {
tokens.add(s);
}
Collections.addAll(tokens, strRep);
}
/**

6
src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheck.java
View File

@ -23,6 +23,8 @@ import com.puppycrawl.tools.checkstyle.api.AnnotationUtility;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.FullIdent;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
import java.util.Collections;
import java.util.Set;
/**
@ -139,9 +141,7 @@ public final class IllegalThrowsCheck extends AbstractIllegalCheck
public void setIgnoredMethodNames(String[] methodNames)
{
ignoredMethodNames.clear();
for (String element : methodNames) {
ignoredMethodNames.add(element);
}
Collections.addAll(ignoredMethodNames, methodNames);
}
/**

13
src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheck.java
View File

@ -26,6 +26,7 @@ import com.puppycrawl.tools.checkstyle.checks.AbstractFormatCheck;
import com.puppycrawl.tools.checkstyle.checks.CheckUtils;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Set;
@ -397,9 +398,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck
public void setIllegalClassNames(String[] classNames)
{
illegalClassNames.clear();
for (String name : classNames) {
illegalClassNames.add(name);
}
Collections.addAll(illegalClassNames, classNames);
}
/**
@ -419,9 +418,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck
public void setIgnoredMethodNames(String[] methodNames)
{
ignoredMethodNames.clear();
for (String element : methodNames) {
ignoredMethodNames.add(element);
}
Collections.addAll(ignoredMethodNames, methodNames);
}
/**
@ -441,9 +438,7 @@ public final class IllegalTypeCheck extends AbstractFormatCheck
public void setLegalAbstractClassNames(String[] classNames)
{
legalAbstractClassNames.clear();
for (String element : classNames) {
legalAbstractClassNames.add(element);
}
Collections.addAll(legalAbstractClassNames, classNames);
}
/**

5
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java
View File

@ -20,6 +20,7 @@ package com.puppycrawl.tools.checkstyle.checks.javadoc;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
@ -111,9 +112,7 @@ public class AtclauseOrderCheck extends AbstractJavadocCheck
public void setTagOrder(String order)
{
final List<String> customOrder = new ArrayList<String>();
for (String type : order.split(", ")) {
customOrder.add(type);
}
Collections.addAll(customOrder, order.split(", "));
tagOrder = customOrder;
}

5
src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java
View File

@ -36,6 +36,7 @@ import com.puppycrawl.tools.checkstyle.checks.CheckUtils;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.ListIterator;
@ -186,9 +187,7 @@ public class JavadocMethodCheck extends AbstractTypeAwareCheck
public void setAllowedAnnotations(String userAnnotations)
{
final List<String> annotations = new ArrayList<String>();
for (String annotation : userAnnotations.split(", ")) {
annotations.add(annotation);
}
Collections.addAll(annotations, userAnnotations.split(", "));
allowedAnnotations = annotations;
}