TouchInstinct
/
checkstyle
307
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue #1555: Add locale to lower case conversion 

Fixes `StringToUpperWithoutLocale` inspection violations introduced in recent commits.

Description:
>Reports any call of toUpperCase() or toLowerCase() on String objects which do not specify a java.util.Locale. Such calls are usually incorrect in an internationalized environment.
This commit is contained in:
Michal Kordas 2015-09-03 22:08:07 +02:00 committed by Roman Ivanov
parent 9ce956473b
commit ee7d6e9df3
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java
View File

@ -20,6 +20,7 @@
package com.puppycrawl.tools.checkstyle.checks;
import static com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck.MSG_KEY_NO_NEWLINE_EOF;
import static java.util.Locale.ENGLISH;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.powermock.api.mockito.PowerMockito.mock;
@ -188,7 +189,7 @@ public class NewlineAtEndOfFileCheckTest
}
catch (InvocationTargetException ex) {
assertTrue(ex.getCause() instanceof IOException);
if (System.getProperty("os.name").toLowerCase().startsWith("windows")) {
if (System.getProperty("os.name").toLowerCase(ENGLISH).startsWith("windows")) {
assertEquals(ex.getCause().getMessage(), "Unable to read 2 bytes, got 0");
}
else {