Commit Graph

4263 Commits

Author SHA1 Message Date
Michal Kordas 0dc308ff69 Remove unnecessary 'return' statement. #1538 2015-08-02 18:48:58 -07:00
Michal Kordas bf64651a0d Remove redundant if statement. #1538 2015-08-02 18:48:58 -07:00
Michal Kordas 49404dbd70 Replace for loop with simpler while statement. #1538 2015-08-02 18:48:58 -07:00
Michal Kordas 6fd60de0a4 Remove confusing else branches. #1538 2015-08-02 18:48:58 -07:00
Michal Kordas 693e8820d5 Remove fully qualified class names which can be shortened. #1538 2015-08-02 18:48:57 -07:00
Michal Kordas 940eb6509f Remove unnecessary uses of the super qualifier. #1538
A super qualifier is unnecessary when the field or method of the super class is not overridden in the calling class.
2015-08-02 18:48:57 -07:00
Michal Kordas 5c9e55ae70 Use .isEmpty() method instead of comparisons to 0. #1538 2015-08-02 18:48:57 -07:00
Michal Kordas 30438ebdf9 Mark fields final where possible. #1538 2015-08-02 18:48:57 -07:00
Michal Kordas 1ce6badd8f Replace new array expressions with an array initializer. #1538
Array initializers omit the type declaration because that is already specified by the declaration of the variable the expression is assigned to.
2015-08-02 18:48:57 -07:00
Michal Kordas fd794d428c Remove unnecessary consecutive lines in Checkstyle code. #1534 2015-08-02 18:41:32 -07:00
Ilja Dubinin 2e1ab8dd86 100% coverage in OuterType check. Issue #1290 2015-08-02 18:33:12 -07:00
Ilja Dubinin 688d428e55 Coverage has been increased to 100% in TrailingCommentCheck. Issue 1290 2015-08-02 18:32:09 -07:00
Baratali Izmailov d6a255f365 Issue #1539: Fixed NPE in MultipleVariableDeclarationsCheck 2015-08-02 18:30:15 -07:00
Baratali Izmailov b097b3f002 Issue #1293: Improved coverage for FinalLocalVariableCheck 2015-08-02 18:27:52 -07:00
Ruslan Diachenko e794bd04c7 Issue #1296: 'SuppressionsLoader' refactored, UT coverage improved 2015-08-02 16:04:50 +01:00
Michal Kordas 9d2cc769f0 Fix SonarQube violations in pom.xml. #46 2015-08-01 22:46:44 +02:00
Michal Kordas 068702d695 Replace StringBuffer with StringBuilder. #46
Fixes squid:S1149 violations.
2015-08-01 13:26:53 -07:00
Michal Kordas 58473e4e73 Make method "static". #46
Fixes squid:S2325 violation.
2015-08-01 13:26:53 -07:00
Michal Kordas 24d8ecc0ae Return expression without assigning it to temporary variable. #46
Fixes squid:S1488 violation.
2015-08-01 13:26:53 -07:00
Michal Kordas 081c654df8 Remove superfluous runtime exception declarations. #46 2015-08-01 13:24:47 -07:00
Michal Kordas 88cc5edb4c Enable NonEmptyAtclauseDescription check on Checkstyle code. #945 2015-08-01 13:20:40 -07:00
Michal Kordas fcd823e0d5 Add missing "@Override" annotations. #46 2015-08-01 13:18:29 -07:00
Andrei Selkin 3a5a73d5c1 Added column number into violation messages for RightCurlyCheck and LeftCurlyCheck, issue #1511. 2015-08-01 13:16:25 -07:00
Baratali Izmailov af52963008 Issue #1293: Refactoring of AbstractSuperCheck. Code coverage has been improved. 2015-08-01 13:15:03 -07:00
Andrei Selkin f8ba0d7279 Fix BooleanExpressionComplexity check violations in Checkstyle code, issue #1052 2015-08-01 09:42:45 -07:00
Baratali Izmailov bd55b45981 Issue #1293: Improved coverage for SimplifyBooleanReturnCheck. 2015-08-01 09:24:38 -07:00
Baratali Izmailov d53fc277c6 Issue #1293: Improved coverage for ExplicitInitializationCheck 2015-08-01 06:58:57 -07:00
Baratali Izmailov 5fa34fa1b2 Issue #1293: Refactoring of ParameterAssignmentCheck 2015-08-01 06:58:26 -07:00
Michal Kordas 2c41aaf844 Improve test coverage in AbstractJavadocCheck. #1308 2015-08-01 14:29:18 +02:00
Roman Ivanov 6a97715527 coverage for TreeWalker (move IOException to setCacheFile method signature). #1294 2015-07-31 01:20:13 -07:00
Roman Ivanov b881dd8faf coverage for TreeWalker. #1294 2015-07-31 01:08:43 -07:00
Roman Ivanov aa51835e53 100% Coverage for DefaultLogger. #1294 2015-07-31 00:02:06 -07:00
Bhavik Patel b2a80ceca3 Solution to Magic Number is not detected properly #1266 2015-07-30 23:27:01 -07:00
Roman Ivanov 71c16c55c3 100% code coverage for ConfigurationLoader. #1294 2015-07-30 22:52:51 -07:00
Ilja Dubinin dcd7085ce2 Coverage has been increased to 100% in UncommentedMainCheck. Issue #1290 2015-07-30 16:50:12 -07:00
Ruslan Diachenko e3366844c4 Issue #1296: 'SuppressWithNearbyCommentFilter' refactored, UT coverage improved 2015-07-30 22:57:20 +01:00
Michal Kordas af095344e1 Add tests and refactor JavadocMethod check. #1308 2015-07-30 21:46:11 +02:00
Andrei Selkin f1dced161a Add new option for RightCurlyCheck, issue #1019. 2015-07-30 12:40:11 -07:00
Roman Ivanov f712557e03 experiment with coverage problem on appveyor. #1496 2015-07-30 17:01:03 -07:00
Roman Ivanov fef1efe791 fix for UTs on Windows7 and do not conflict with WindowsServer. #1496 2015-07-30 14:51:24 -07:00
Roman Ivanov d1b747d206 again problem at appveyor. #1496 2015-07-30 00:13:18 -07:00
Roman Ivanov 570eba585b final fix for TreeWalkerTest.testDestroyNonExistingCache failure on Windows. #1496 2015-07-30 00:02:21 -07:00
Roman Ivanov 62a8b24971 revert to let build pass on appveyor. #1496 2015-07-29 21:28:51 -07:00
Roman Ivanov bea99e188f additonal experiment to fix failure of appveyor. #1496 2015-07-29 21:10:45 -07:00
Roman Ivanov b82be7c60f Investigate TreeWalkerTest.testDestroyNonExistingCache failure on Windows. #1496 2015-07-29 20:56:09 -07:00
Roman Ivanov f8bd84c6e3 additional experiment to fix build on appveyor. #1510 2015-07-29 20:38:29 -07:00
Roman Ivanov 88f75f5413 Investigate UTs failure to MainTest on Windows. #1510 2015-07-30 03:23:35 -07:00
Roman Ivanov 61dcaf5f51 fix for build problem in Idea on Windows 2015-07-30 03:22:09 -07:00
Ruslan Diachenko 66dd2e127b Issue #1296: 'SuppressionCommentFilter' UT coverage improved 2015-07-29 18:02:44 -07:00
Ilja Dubinin c3797e0ad8 Coverage has been increased to 100% in SinglelineDetector. Issue #1010 2015-07-29 22:01:20 +01:00