2e32ba7ab6
Fix suspicious method call. #1555
...
Fixes SuspiciousMethodCalls inspection violation.
Description:
>This inspection reports method calls to parameterized collections, where actual argument type does not correspond to the collection's elements type. For example if you have the following code:
```
List<Integer> list = getListOfElements();
list.remove("");
```
the call to `remove()` will be highlighted.
2015-08-08 07:13:56 +03:00
8a3f5bf6d5
Remove unused assignments. #1555
...
Fixes UnusedAssignment inspection violations.
Description:
>This inspection points out the cases where a variable value is never used after its assignment, i.e.:
- the variable never gets read after assignment OR
- the value is always overwritten with another assignment before the next variable read OR
- the variable initializer is redundant (for one of the above two reasons) OR
- the variable is never used.
2015-08-08 07:12:41 +03:00
7d513f08c2
Copy collections and arrays before assigning to fields. #1555
...
Fixes AssignmentToCollectionFieldFromParameter violations.
Description:
>Reports any attempt to assign an array or Collection field from a method parameter. Since the array or Collection may have its contents modified by the calling method, this construct may result in an object having its state modified unexpectedly. While occasionally useful for performance reasons, this construct is inherently bug-prone.
2015-08-08 07:11:07 +03:00
68959eeeff
Issue #1566 : AvoidNestedBlocks, FinalLocalVariable, RegexpSingleline (THIS as a lock) violations fixed
2015-08-08 07:08:28 +03:00
782da01103
Fixed overly strong type cast, issue #1555 .
2015-08-08 06:59:27 +03:00
4d526a44a7
Minor typo: have -> has the
2015-08-08 06:18:24 +03:00
7f90c5aef3
Minor typo on site homepage: 'desig' -> 'design'
2015-08-08 06:18:24 +03:00
3c5d80db4c
6.10-SNAPSHOT
2015-08-07 16:57:36 +03:00
2ad80f4e9e
[maven-release-plugin] prepare for next development iteration
2015-08-07 15:20:43 +03:00
75be892cb1
[maven-release-plugin] prepare release checkstyle-6.9
2015-08-07 15:20:41 +03:00
e04257c669
release notes 6.9
2015-08-07 06:46:50 +03:00
f727a3d885
release notes for 6.8.2
2015-08-07 05:53:19 +03:00
b0d1f7fd52
Remove redundant characters from regular expressions. #1555
...
Fixes:
* Obsolete single repetition
* Redundant character escapes
2015-08-06 06:32:36 +03:00
1df3af1d42
Add tag required by schema to Cobertura configuration. #1555
...
Fixes IntelliJ IDEA MavenModelInspection violation.
2015-08-06 06:31:48 +03:00
d2b16c06ed
Collapse empty tags in XML. #1555
2015-08-06 06:30:42 +03:00
dd5562f6dc
Issue #1293 : Improved coverage for ReturnCountCheck
2015-08-06 06:29:22 +03:00
75ddaad1c5
fix for build on windows. #1294
2015-08-06 06:17:12 +03:00
ead1a5e5dc
100% UTs coverage for Checker (no way to reproduce/mock IOException). #1294
2015-08-05 17:06:17 +03:00
3fe08f2968
UT coverage for Checker. #1294
2015-08-05 16:27:10 +03:00
a2da840df3
100% UTs coverage for TreeWalker. #1294
2015-08-05 15:39:51 +03:00
b2d7013e9e
UT coverage for TreeWalker. #1294
2015-08-05 08:04:48 +03:00
ddafe73dda
Fixed incorrect Google Java Style links, issue #751 .
2015-08-04 12:02:40 +03:00
78fbe6abf4
Coverage has been increased to 100% in DescedantTokensCheck. Issue #1290
2015-08-03 20:54:04 -07:00
d282d5b8db
Refactoring of RightCurlyCheck, issue #1511 .
2015-08-03 12:03:09 +03:00
ef422e76c6
Remove redundant throws declarations. #1542
2015-08-02 18:54:23 -07:00
c6df309827
Access static members via class reference. #1542
2015-08-02 18:54:23 -07:00
59fa63c67d
Remove unnecessary qualifiers for statically imported elements. #1542
2015-08-02 18:54:23 -07:00
f0d637e28c
Remove redundant constructor. #1542
2015-08-02 18:54:23 -07:00
2880edd655
Decrease scope of variables. #1538
2015-08-02 18:48:58 -07:00
d49eaaf2e4
Extract increment operations to separate expressions. #1538
...
While increment or decrement expressions nested inside other expressions are admirably terse, such expressions may be confusing, and violate the general design principle that a given construct should do precisely one thing.
2015-08-02 18:48:58 -07:00
85ba2a3dce
Replace assignment with operator assignment. #1538
2015-08-02 18:48:58 -07:00
4b26a472cc
Replace manual array unboxing with ArrayUtils.toPrimitive(). #1538
2015-08-02 18:48:58 -07:00
0a6026c9ab
Remove unnecessary unboxing. #1538
2015-08-02 18:48:58 -07:00
111bd4b1df
Collapse 'catch' blocks. #1538
2015-08-02 18:48:58 -07:00
e6538f822f
Replace 'for' loop with 'foreach'. #1538
2015-08-02 18:48:58 -07:00
0dc308ff69
Remove unnecessary 'return' statement. #1538
2015-08-02 18:48:58 -07:00
bf64651a0d
Remove redundant if statement. #1538
2015-08-02 18:48:58 -07:00
49404dbd70
Replace for loop with simpler while statement. #1538
2015-08-02 18:48:58 -07:00
6fd60de0a4
Remove confusing else branches. #1538
2015-08-02 18:48:58 -07:00
693e8820d5
Remove fully qualified class names which can be shortened. #1538
2015-08-02 18:48:57 -07:00
940eb6509f
Remove unnecessary uses of the super qualifier. #1538
...
A super qualifier is unnecessary when the field or method of the super class is not overridden in the calling class.
2015-08-02 18:48:57 -07:00
5c9e55ae70
Use .isEmpty() method instead of comparisons to 0. #1538
2015-08-02 18:48:57 -07:00
30438ebdf9
Mark fields final where possible. #1538
2015-08-02 18:48:57 -07:00
1ce6badd8f
Replace new array expressions with an array initializer. #1538
...
Array initializers omit the type declaration because that is already specified by the declaration of the variable the expression is assigned to.
2015-08-02 18:48:57 -07:00
fd794d428c
Remove unnecessary consecutive lines in Checkstyle code. #1534
2015-08-02 18:41:32 -07:00
2e1ab8dd86
100% coverage in OuterType check. Issue #1290
2015-08-02 18:33:12 -07:00
688d428e55
Coverage has been increased to 100% in TrailingCommentCheck. Issue 1290
2015-08-02 18:32:09 -07:00
d6a255f365
Issue #1539 : Fixed NPE in MultipleVariableDeclarationsCheck
2015-08-02 18:30:15 -07:00
b097b3f002
Issue #1293 : Improved coverage for FinalLocalVariableCheck
2015-08-02 18:27:52 -07:00
e794bd04c7
Issue #1296 : 'SuppressionsLoader' refactored, UT coverage improved
2015-08-02 16:04:50 +01:00
Michal Kordas
Ruslan Diachenko
Andrei Selkin
Dave Moloney
Roman Ivanov
Baratali Izmailov
Ilja Dubinin