Commit Graph

3522 Commits

Author SHA1 Message Date
Roman Ivanov 580b7ba8a2 fix accordng to detected outdated versions - https://www.versioneye.com/user/projects/55264178c4b71d7001000002#tab-dependencies 2015-04-09 16:19:44 -07:00
Michal Kordas fc0d10e8f4 Fix PMD violations from 'braces' ruleset, issue #876 2015-04-09 16:10:31 -07:00
Roman Ivanov 2493166c3d minor changes for link to SuppressWarningsHolder 2015-04-09 15:14:13 -07:00
Roman Ivanov 65e15b32db Findbugs with default configuration is enforced, some violations were added to exclude with reason in comment. Issue #778 2015-04-08 23:33:35 -07:00
Roman Ivanov 702a1a9576 fix for Findbugs violation DM_DEFAULT_ENCODING. Issue #778 2015-04-08 22:37:46 -07:00
Roman Ivanov 480de89b47 exculde for Findbugs violation DM_DEFAULT_ENCODING. Issue #778 2015-04-08 14:18:41 -07:00
Roman Ivanov fb68212a18 fix for Findbugs violation DM_DEFAULT_ENCODING. Issue #778 2015-04-08 13:17:25 -07:00
Michal Kordas 95fc97c6d8 Fix PMD violations from 'typeresolution' ruleset, issue #875 2015-04-08 21:11:54 +02:00
Roman Ivanov 362abdf0ca fix for EI_EXPOSE_REP. Issue #778 2015-04-08 09:26:09 -07:00
Roman Ivanov a8f5fa3225 fix for EI_EXPOSE_REP. Issue #778 2015-04-08 08:33:04 -07:00
Roman Ivanov 01b9628d34 fix for RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE. Issue #778 2015-04-07 16:36:05 -07:00
Roman Ivanov 547fb51b1d fix for NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH. Issue #778 2015-04-07 16:15:15 -07:00
Roman Ivanov 8f047f2ebd future plan for new validations. Issue #778 2015-04-07 15:56:05 -04:00
Roman Ivanov cce20fc3c7 fix for SF_SWITCH_FALLTHROUGH. Issue #778 2015-04-06 23:16:29 -07:00
Roman Ivanov 9619cf2728 fix for SF_SWITCH_FALLTHROUGH. Issue #778 2015-04-06 23:12:13 -07:00
Roman Ivanov 0cc1f87aa5 PMD report is not empty on web site. Issue #902 2015-04-06 22:20:13 -07:00
Michal Kordas bff7a1d5af Update Apache Commons Lang to 3.4, issue #899 2015-04-06 22:54:40 +02:00
Roman Ivanov 914bf53cd0 resolving PMD issues with braces, removing dead code conditions that are impossible to test, coverage become 100% 2015-04-03 00:25:32 -07:00
Roman Ivanov d58f720c81 MagicNumberCheck: javadoc and xdoc was updated to describe all options, examples were added. Issue #148 2015-04-03 00:25:18 -07:00
ychulovskyy 7a1b0b12a6 Issue #148 magic number detection: option to ignore magic numbers in field declarations 2015-04-03 00:25:05 -07:00
liscju 5026b7228d Added option in ModifiedControlVariable Check to ignore validation of variables defined in for which are not change in for iterator part, fix issue #286 2015-04-01 14:44:18 -07:00
Michal Kordas 3a20dbe8ed Use use Java 7 instead of custom logic for relative paths, issue #857 2015-03-31 11:25:03 -07:00
Roman Ivanov aae2d7156d revert to shields image for gitter to make pictured be the same style 2015-03-31 06:09:33 -07:00
AnirvanSarkar 253c20b6f2 Use SVG badge for coveralls.io.
Now the coveralls.io badge will have a consistent flat look like the other badges.
2015-03-31 15:04:37 +05:30
Roman Ivanov 0be8c0468b Add Stackoverflow badge to readme, done by @Mebibyte user, issue #880 2015-03-30 17:38:49 -07:00
Roman Ivanov 598cfb57cc giter icon was changed to orginal from gitter 2015-03-30 17:34:23 -07:00
Roman Ivanov fb92bd8173 gitter room is not a support, it is only for developers 2015-03-30 17:25:51 -07:00
Michal Kordas cf1d22f39f Use entrySet iterator to fix FindBugs violations, issue #778
These methods accessed the value of a `Map` entry, using a key that was retrieved from a `keySet` iterator. It is more efficient to use an iterator on the `entrySet` of the map, to avoid the `Map.get(key)` lookup.

All violations of FindBugs rule [WMI: Inefficient use of keySet iterator instead of entrySet iterator](http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR) are fixed.
2015-03-30 14:01:57 -07:00
Michał Kordas c037e6419d Integrate Gitter with Checkstyle, issue #864 2015-03-30 13:41:25 -07:00
Michal Kordas 9923fd6778 Resolve some problems in Javadoc reported by Java 8, issue #291
It is not possible to nest block-level elements, such as `<pre>`, inside `<p>`.
2015-03-30 13:33:22 -07:00
Michal Kordas d92c4c19ca Add more rulesets to PMD configuration, issue #744 2015-03-30 13:30:02 -07:00
Michal Kordas 26e72b35ca Disable Findbugs for 'grammars' package, issue #778
Package `com.puppycrawl.tools.checkstyle.grammars` contains only autogenerated code, so it should be excluded from Findbugs analysis.
2015-03-29 18:33:56 +02:00
Michał Kordas 9db050a5ff Update Maven Compiler Plugin to 3.3, issue #867 2015-03-28 15:24:53 -07:00
Michał Kordas 97447d9cb9 Update FindBugs Maven Plugin to 3.0.1, issue #865 2015-03-28 23:00:41 +01:00
Roman Ivanov afda7d0632 [maven-release-plugin] prepare for next development iteration 2015-03-28 11:07:24 -07:00
Roman Ivanov 983a77a3ca [maven-release-plugin] prepare release checkstyle-6.5 2015-03-28 11:07:23 -07:00
Roman Ivanov 827651af91 release notes 6.5, after content update from Michal Kordas 2015-03-28 08:47:14 -07:00
Roman Ivanov c09360f8e8 release notes 6.5 2015-03-28 08:11:34 -07:00
Damian Szczepanik 97f0829897 Added test method for Utils.isPatternValid method
Pull #861
2015-03-27 15:34:34 -07:00
Roman Ivanov b20532ed18 pmd:check is assigned to verify phase of build, issue #744 2015-03-27 18:27:32 -04:00
Damian Szczepanik ebd4afdebe Deleted cache from Utils class + unified setters with patterns
Issue #845
2015-03-27 22:39:02 +01:00
Danil Lopatin c2c34c8408 Token WILDCARD_TYPE was added to WhitespaceAroundCheck, issue #853 2015-03-27 17:39:31 +03:00
Roman Ivanov 09ea9591e2 unused profiles are removed from POM : release, release-sign-artifacts 2015-03-26 15:47:29 -07:00
Roman Ivanov a924f59914 pmd report should always be generated even it is empty 2015-03-26 15:43:15 -07:00
Michal Kordas b771841de7 Remove deprecated getLines() methods from Utils, issue #854 2015-03-26 22:15:10 +01:00
Michal Kordas 8a24026433 Add unit tests for class base name util to improve coverage 2015-03-26 20:36:15 +01:00
Michal Kordas 6e6d912013 Add logging to empty catch blocks to fix PMD violations, issue #744
All violations of PMD rule [EmptyCatchBlock](http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/empty.html#EmptyCatchBlock) are fixed by logging exceptions.
2015-03-26 20:35:25 +01:00
Michal Kordas 06865630aa Use Guava Closeables to manage closing exceptions
>While it's not safe in the general case to ignore exceptions that are thrown when closing an I/O resource, it should generally be safe in the case of a resource that's being used only for reading, such as a Reader. Unlike with writable resources, there's no chance that a failure that occurs when closing the reader indicates a meaningful problem such as a failure to flush all bytes to the underlying resource.

`Reader` and `InputStream` instances are closed using `Closeables.closeQuietly()`, while `RandomAccessFile` is closed with `Closeables.close()` that throws `IOException` and needs to be handled.

From Javadoc:
>```java
public static void close(@Nullable
         Closeable closeable,
         boolean swallowIOException)
                  throws IOException
```
>Closes a Closeable, with control over whether an IOException may be thrown. This is primarily useful in a finally block, where a thrown exception needs to be logged but not propagated (otherwise the original exception will be lost).
If swallowIOException is true then we never throw IOException but merely log it.

>Example:
```java
   public void useStreamNicely() throws IOException {
     SomeStream stream = new SomeStream("foo");
     boolean threw = true;
     try {
       // ... code which does something with the stream ...
       threw = false;
     } finally {
       // If an exception occurs, rethrow it only if threw==false:
       Closeables.close(stream, threw);
     }
   }
```

Moreover, `Closeables.close()` and  `Flushables.flush()` are used to flush and close `OutputStream`.
2015-03-26 20:35:17 +01:00
Michal Kordas cbfe72383b CustomImportOrder checks import sorting according to ASCII order, fixes #847
Previously used 'ignoreCase' order is different than required ASCII order.
2015-03-25 21:00:55 -07:00
Michal Kordas fb8c630359 Update org.apache.ant:ant-nodeps to 1.8.1, issue #790 2015-03-25 07:51:47 -07:00