75f0ef8a42
remove dead code
2002-11-09 22:13:50 +00:00
4b754899a4
remove dead code
2002-11-09 22:00:17 +00:00
ecaaaeb254
added operator wrap check
2002-11-09 20:24:22 +00:00
58517365db
modified to use an array of names for improved performance
2002-11-09 17:39:51 +00:00
d5c0ea5395
removed unecessary IGNORE check
2002-11-09 14:51:31 +00:00
468541ac37
added check for 'instanceof'
...
refactored to a new variable
removed redundant IGNORE option
2002-11-09 14:50:49 +00:00
36af550d96
Changes for clover
2002-11-09 10:32:31 +00:00
df9f4920a3
Fixed checkstyle errors
2002-11-09 10:31:53 +00:00
8505901864
port operator wrap policy
2002-11-08 19:20:56 +00:00
8c80de1692
cleanup from ConstantNameCheck
2002-11-08 10:53:10 +00:00
faeb93df42
added test to increase code coverage of JavadocMethodCheck
2002-11-08 00:41:27 +00:00
0b38b65f91
strengthened to also check fields of outer classes, and to check
...
parameters by default.
improved code coverage.
2002-11-08 00:12:20 +00:00
215db57b5f
changed I added to support Clover - still need to re-factor slightly.
2002-11-07 20:49:40 +00:00
fc6eea95b8
added if without block to increase test coverage of EmptyBlockCheck
2002-11-07 20:04:14 +00:00
f454aa6d90
added whitespace to improve code coverage in NoWhiteSpaceAroundCheckTest
2002-11-07 19:45:54 +00:00
e6571e6f57
removed paranoia checks to increase code coverage
2002-11-07 19:10:10 +00:00
26fcfecd43
added if without else to increase test coverage
2002-11-07 19:05:29 +00:00
0eded9de9c
removed unused throws declaration, Exception is never thrown inside method body
2002-11-07 19:03:28 +00:00
3db24e2377
clarified comment for method inCodeBlock
2002-11-07 18:31:30 +00:00
d93f403e8f
added comments
2002-11-07 18:03:08 +00:00
5057b2c44f
added coverage to test interfaces
2002-11-07 17:22:18 +00:00
d2a0e41072
fixed bug in checking an interface.
2002-11-07 17:21:41 +00:00
74989ba011
Checks whether a local variable or parameter shadows a field.
...
This is the cause for one of the most common logic errors of beginners.
2002-11-07 10:20:55 +00:00
b19d1056bb
Moved the Scope class into the API package.
2002-11-06 07:26:26 +00:00
1321eda54e
remove dead code
2002-11-06 07:12:58 +00:00
5fc3ff2bfb
Please ensure you thoroughly test code before committing it. As a sanity test,
...
ensure that the target "checkstyle.checkstyle" will run! If in doubt, do not
commit, but instead said a patch to the devel mailing list for a review.
Finished the port of the ClassResolver code. Even though it compiled, it had
no chance of working due to class casting problems. They have not been
fixed. Also needed to ensure the correct class loader is being used.
2002-11-06 03:57:58 +00:00
e7556f4af6
Fixed more Checkstyle errors.
2002-11-06 02:52:12 +00:00
fc358e2da0
Fixed Javadoc errors
2002-11-06 00:47:21 +00:00
267bdf5417
Refactor to improve the AbstractOptionCheck code.
2002-11-06 00:40:26 +00:00
903f780d58
Added a getAbstractOption() method. I am going to change the design of this
...
class to improve the following:
- Not have protected member variables that are accessed directly. Checkstyle
reports this error.
- By default the mOption member is not initialised to a default value. This is
causing strange behaviour in the EmptyBlockCheck when no option is specified,
as it does nothing. It should default to statement.
2002-11-06 00:23:32 +00:00
c9bcfe0be0
Fixed checkstyle errors - could we all now get into the habit of running
...
"checkstyle.checkstyle" before committing.
2002-11-06 00:18:46 +00:00
93bba09f70
Wanting to turn on the check - but it fails. Need to resolve as it is most
...
likely to be a classpath issue.
2002-11-06 00:14:40 +00:00
f38b8c49c4
Update to version 1.5.
2002-11-05 23:57:36 +00:00
3bcc2c1391
update for JavadocMethodCheck
2002-11-05 20:39:56 +00:00
d75ea91dd1
cleanup for JavadocMethodCheck
2002-11-05 17:10:25 +00:00
c75f97dbc2
Javadoc method check
2002-11-05 13:13:14 +00:00
f42953e35b
handle anonymous class
2002-11-05 00:37:59 +00:00
dbf2a5cb49
made methods final if they are not meant to be overridden
...
made most methods protected, they are only called by Check implementations
removed todo comments
2002-11-04 06:10:45 +00:00
065c1d3bc5
Fixed a series of Checkstyle errors.
2002-11-03 22:13:24 +00:00
ad0a4e637a
style cleanup, plus query about TokenTypes.LITERAL_SYNCHRONIZED
2002-11-03 18:45:01 +00:00
da628acc0d
cleanup for EmptyBlockCheck
2002-11-03 18:37:41 +00:00
6c8770ef09
refactor to use AbstractOption and AbstractOptionCheck
2002-11-03 17:47:37 +00:00
982b3963ca
empty block check with options
2002-11-03 17:46:03 +00:00
d471c9cd54
override read(), leads to ~10 percent performance increase
2002-11-03 15:03:36 +00:00
fb97056b9b
Fixed bug in MethodLeftCurlyCheck where it did not handle interfaces and
...
abstract methods.
2002-11-03 12:06:15 +00:00
bf1b83ee6f
made class package local again
2002-11-03 09:53:29 +00:00
1aa2134399
fixed NPE
2002-11-03 08:37:00 +00:00
4945b82e6d
Folded the constructor length test into the method length check. Seems silly
...
to have them as separate checks.
2002-11-03 02:37:20 +00:00
ba8a851e90
Fixed bug in MethodLengthCheck where it was assuming that a method definition
...
had to have braces. Not the case for interfaces and abstract methods. Need to
make the same change to the other method check.
2002-11-03 02:14:07 +00:00
ce177456e7
Made some style changes.
2002-11-03 01:47:12 +00:00
Oliver Burn
Rick Giles
Lars Kühne