Commit Graph

550 Commits

Author SHA1 Message Date
Oliver Burn 823ef8630a Renamed LeftCurlyCheck to AbstractLeftCurlyCheck.
Completely happy with the name. :-)
2002-11-25 01:04:48 +00:00
Oliver Burn af958820c7 Renamed ImportCheck to AbstractImportCheck.
Not completely happy with the name.
2002-11-25 00:57:21 +00:00
Oliver Burn cf4da985e0 Fix indentation 2002-11-25 00:52:22 +00:00
Oliver Burn 7ad61673cc Fix Javadoc copy and paste error (643148) 2002-11-25 00:30:32 +00:00
Oliver Burn 6a5a68f6d8 Fixed bug in handling '{' for whitespace checking. 2002-11-23 08:08:50 +00:00
Oliver Burn aa1032931c Tighten the checks. 2002-11-23 07:54:25 +00:00
Lars Kühne 672244cf2f When the same property filename is used in multiple
directories, only the ones in the same directory
should have the same keys. Yes, I know, unit tests are
still missing...

Alex, thanks for the fix!
2002-11-23 07:01:34 +00:00
Lars Kühne 18e561669b ups, forgot to finish that sentence... :-) 2002-11-23 06:46:55 +00:00
Lars Kühne 31ac01616c improved javadoc and made append methods private. 2002-11-23 06:35:41 +00:00
Oliver Burn a6542ab75c Enable checking for whitespace after type casts. Also fix found errors. 2002-11-23 06:23:32 +00:00
Oliver Burn e4a4b6dc01 Small bugfix 2002-11-23 02:51:45 +00:00
Oliver Burn 59378eb655 Small bugfix 2002-11-23 00:53:40 +00:00
Oliver Burn 4a5ccfb6fe Bug fix the handling of '{'. Demonstrates the power of using findFirstToken(). 2002-11-23 00:20:17 +00:00
Oliver Burn b657e696ff Backed out the change as ReplaceTest does not exist. 2002-11-22 23:18:16 +00:00
Rick Giles 9488272ec0 updated for all current tests 2002-11-22 17:32:29 +00:00
Oliver Burn b787d5ed90 Fix bug with needing whitespace around '*' using in import blah.*; 2002-11-22 14:14:37 +00:00
Oliver Burn 068f85a72b fixed checkstyle error. We now have reached 0 (thats ZERO) errors. Yahoo!!!! 2002-11-22 13:53:58 +00:00
Oliver Burn 109b8f02b6 Sorry, but the Eclipse warning was getting annoying. I wish there was a way to
ignore specific errors.
2002-11-22 13:45:26 +00:00
Oliver Burn 2d1cc52679 fixed checkstyle errors 2002-11-22 13:43:10 +00:00
Oliver Burn d83cf71c6b Fixed bug in parameter name check. did not handle catch blocks. 2002-11-22 13:35:49 +00:00
Oliver Burn 303352fe2d fixed checkstyle errors 2002-11-22 13:00:01 +00:00
Oliver Burn 3430721be2 fixed checkstyle errors 2002-11-22 12:46:24 +00:00
Oliver Burn 0ff652ab52 minor patch 2002-11-22 10:09:02 +00:00
Oliver Burn fe98987973 Minor cleanup 2002-11-21 10:53:14 +00:00
Lars Kühne 7429b6641b removed some debugging leftovers 2002-11-20 21:57:37 +00:00
Lars Kühne fe39ab1558 fixed message bundle PacakgeHtmlCheck 2002-11-20 21:55:07 +00:00
Lars Kühne f116754656 added test for PackageHtmlCheck 2002-11-20 21:53:45 +00:00
Lars Kühne 6568a9b882 fixed checkstyle errors 2002-11-20 05:56:06 +00:00
Lars Kühne 0f050732b0 added todo comment about GlobalConfiguration field 2002-11-20 05:50:38 +00:00
Lars Kühne abff1a2489 Made TreeWalker a FileSetCheck and moved the
processing logic from Checker to TreeWalker.

Checker is now only concerned with managing FileSetChecks,
although the setup is still hardcoded in the constructor,
c.f. TODO comments in Checker constructor.

Uncommenting the addFileSetCheck calls for real is
left until we have better control our configuration.
2002-11-19 20:21:46 +00:00
Lars Kühne 54a09706ec Introduced MessageDispatcher interface so
FileSetChecks do not need to be tightly coupled
with Checker to report errors.

FileSetCheck implementations report errors now.

Error counting in Checker is now done via an
AuditListener, no need to bother about that in
each individual FileSetCheck.
2002-11-19 19:17:25 +00:00
Oliver Burn a49d4e972a fix import 2002-11-19 10:08:25 +00:00
Rick Giles cf7e4c19e3 renamed XML element "set-property" to "property" 2002-11-18 10:03:05 +00:00
Lars Kühne bac2f07937 removed toString() to
get better coverage of DetailAST and to
improve the readability of the leftmost column in the gui
2002-11-17 16:13:38 +00:00
Lars Kühne 0e57b8d026 improve test coverage of AbstractFormatCheck 2002-11-17 15:57:36 +00:00
Lars Kühne a8dc464f06 improve test coverage of HeaderCheck 2002-11-17 15:41:06 +00:00
Lars Kühne dce6e0d57e removed obsolete Global Property "require package html"
and additional cleanup since that was the last boolean property
2002-11-17 15:37:39 +00:00
Lars Kühne 08f2b317d6 removed obsolete Global Property "require package html"
and additional cleanup since that was the last boolean property
2002-11-17 15:24:55 +00:00
Lars Kühne 52d9d94ca6 removed obsolete Global Property "require package html"
and additional cleanup since that was the last boolean property
2002-11-17 09:14:30 +00:00
Lars Kühne 82b2ba5269 Moved stripping of basedir to the event handling routines.
This separates concerns in parse(File) as a preparation for moving that method to TreeWalker.
It also fixes bug #622290 (package name reported incorrectly) once I integrate PackageHtmlCheck.
2002-11-17 08:24:50 +00:00
Lars Kühne b33ff29c69 made TreeWalker public so that parse() is accessible from gui 2002-11-17 08:13:20 +00:00
Lars Kühne 93390fbc8a moved parse() from Checker to TreeWalker 2002-11-17 08:05:35 +00:00
Lars Kühne 62133d9541 fixed javadoc errors for build.bindist 2002-11-17 07:17:35 +00:00
Lars Kühne 822384a711 Changed signature of Checker.process(String[]) to process(File[])
This is a step towards making TreeWalker a FileSetCheck, next some
methods need to be moved around.
2002-11-17 06:48:56 +00:00
Lars Kühne cb2862b73a fixed checkstyle errors 2002-11-17 06:47:38 +00:00
Rick Giles cb475adb81 corrected syntax errors in test inputs 2002-11-16 20:27:48 +00:00
Rick Giles 2debda611f Added overriding global properties
Needs testing, especially in ant with CheckstyleTask.
2002-11-16 19:38:07 +00:00
Lars Kühne a4ce4c6bb4 added initial core implementation of TranslationCheck (rfe #634966)
integration into checker and tests is still missing
2002-11-16 17:31:56 +00:00
Rick Giles 3c0608f33a Wrapped GlobalProperties and CheckConfiguration[] into a Configuration
class. TODO: Integrate with CheckStyleTask
2002-11-15 18:18:52 +00:00
Oliver Burn f8f6ded7b4 Upgrading to JUnit 3.8.1 2002-11-15 14:08:11 +00:00