Commit Graph

258 Commits

Author SHA1 Message Date
Lars Kühne dfd870600d added test for package name
fixed TODO check (got lost during recent refactoring)
2002-09-08 12:30:56 +00:00
Lars Kühne 01d0f17ca7 Basic implementation of RFE #597787 (check package name).
Configuration, tests and docs still missing
2002-09-08 08:44:00 +00:00
Oliver Burn 9ef57a9502 Renamed to CHECK_UNUSED_FIELDS_PROP to allow for CHECK_UNUSED_METHODS_PROP in
the future. Not this release.
2002-09-08 07:50:02 +00:00
Oliver Burn 7f06106f4e Yahoo! Implemented checking for unused private fields. Just need to document
the new feature. It is off by default as the class path must be set up. Can
use the same technique for private methods.
2002-09-08 07:31:37 +00:00
Oliver Burn 49eb0e934e Yet another refactor to have the ANT task support a nested <property>
element. This let me remove the ugly have I put in to support relative
paths. Got the idea from Vincet Massol. Bug 605141.
2002-09-07 01:36:40 +00:00
Oliver Burn fdc564f6b2 Cleaned up visibility 2002-09-05 02:52:47 +00:00
Oliver Burn aff5047c9e Patch to make loading of relative file paths work. Basically duplicating the
work that ANT used to do. There had to be some pain in the refactoring. ;-)
2002-09-05 02:46:40 +00:00
Oliver Burn 2df5874fc8 Improved the error handling 2002-09-04 14:33:07 +00:00
Oliver Burn 62354b2ad9 Major refactor to make Configuration only be configured through properties 2002-09-04 13:50:23 +00:00
Oliver Burn 7335df239d Major refactor to make Configuration only be configured through properties 2002-09-04 13:38:51 +00:00
Oliver Burn 98d883bb3b Major refactor of the CheckerTest to configure using properties. 2002-09-04 13:28:53 +00:00
Oliver Burn 54948c48df Moved test inputs files to another directory so that Eclipse does not give
lots of error messages. Another reason that IDEA is nicer :-)
2002-09-02 12:09:51 +00:00
Oliver Burn 31e98a9230 Made more tolerant of an empty property for the header file. 2002-08-28 01:41:32 +00:00
Oliver Burn f45a53a37f Fixed dependance on JDK 1.4 (shame on me! :-) 2002-08-27 04:21:38 +00:00
Oliver Burn a021a7e165 Incorporate Japanese translation of messages from Shinya OHNUMA [ ohnuma AT
bump DOT co DOT jp.
2002-08-25 09:13:29 +00:00
Oliver Burn 7b7eea6e9a A rather large refactoring to improve the way Checkstyle is configured. It all
started with adding the Configuration.getProperties() method.
2002-08-25 08:21:19 +00:00
Oliver Burn 1818ae8ab1 Refactored some more messages. 2002-08-22 08:32:17 +00:00
Oliver Burn 5703b6e335 Changes to make localisation simpler. 2002-08-22 08:25:02 +00:00
Oliver Burn f8a53831f0 Incorporate patch 555878 from Rick Giles to allow pattern for local final
variables to be specified.
2002-08-21 08:08:43 +00:00
Oliver Burn 1fdf65bf01 Incorporate patch 566855 from Rob Worth to optionally check that parenthesis
are padded with spaces.

Big thanks to Lars for suggesting that the Pad Option not be a boolean so
somebody could one day submit this patch. :-)
2002-08-21 04:39:27 +00:00
Oliver Burn 9aa8268e47 Applied the ideas in patch 580230 - More consistent messages 2002-08-20 13:56:28 +00:00
Oliver Burn d92ceb81a6 Implemented enforcing having @version tag. (Request 543964). 2002-08-20 13:08:37 +00:00
Oliver Burn b8d742ecd2 Changes to make maxLen easier to localise. 2002-08-20 07:45:33 +00:00
Oliver Burn eec6e39766 Removed a blank line (and tested Eclipse for CVS mode) 2002-08-18 23:50:03 +00:00
Oliver Burn 25a13442f2 Fixed bug (594469) where unit tests would fail under different locales. Also
fixed a potential bug on how messages are located.
2002-08-14 01:58:44 +00:00
Lars Kühne 816c6b33c9 use accessor methods for superclass atributes, fixes bug #594466 (I hope) 2002-08-13 16:58:42 +00:00
Oliver Burn 751257987b Refactored the logging out of Verifier. Also fixed all gump errors. 2002-08-12 13:18:22 +00:00
Oliver Burn ecc852d48b Added support to specify a country so that the call to the Locale()
constructor is not dependent on JDK 1.4.
2002-08-12 12:10:57 +00:00
Oliver Burn 5890d22a6d Added documentation for localisation and the ability to set the language. 2002-08-12 09:02:41 +00:00
Oliver Burn 7781985a34 Request 582144: added documentation. 2002-08-12 07:40:29 +00:00
Oliver Burn 378e87f1e3 Since this class is meant to be seen outside the package - fixed the access
rights
2002-08-11 10:07:59 +00:00
Oliver Burn f7e86cdf5f changed to use LocalizedMessage. 2002-08-11 10:07:07 +00:00
Oliver Burn 20483ae032 Major rework to support localized error messages. Inspired by patch 580410. At
the moment it is not possible to override the system locale, this probably
should be added.

Now possible to specify the locale to use.
2002-08-11 10:01:01 +00:00
Lars Kühne 495227c608 german translation of messages 2002-08-10 16:10:33 +00:00
Oliver Burn c682b5725d Major rework to support localized error messages. Inspired by patch 580410. At
the moment it is not possible to override the system locale, this probably
should be added.
2002-08-10 14:15:00 +00:00
Oliver Burn e7c7215349 request 583719 - detect unused @throws that subclass java.lang.Error. 2002-08-04 05:01:20 +00:00
Oliver Burn a9884dffce Incorporate patch from ronald _DOT d _DOT hastings _AT boeing _DOT com to
correctly handle C++ style comments being between Javadoc comments and
declarations.
2002-08-02 00:02:26 +00:00
Oliver Burn 7f8726ee78 Changed # parameters to 7 (from 5) and in the process spent more time writing
this comment that changing the code. :-)
2002-07-21 12:04:27 +00:00
Lars Kühne 49bcb59031 fixed false alarm about unused imports for class array objects (e.g. Vector[].class), reported by Michael Rumpf 2002-07-21 10:27:32 +00:00
Oliver Burn c8a57d0b85 Added a check for excessive numbers of parameters. Still need to add the
documentation and a unit test. Still not sure what the correct default value
it, taken the value of 5.
2002-07-16 13:25:15 +00:00
Oliver Burn e543c01abd Changed the wrap on operator implementation to take an option rather than a
boolean. This allows it to be extended easily in the future.
2002-07-08 02:23:38 +00:00
Lars Kühne 7521f1897b fixed bug where reported file names were not correct when checkstyle.basedir ended with File.separator 2002-07-06 06:35:29 +00:00
Lars Kühne 784085d313 close the OutputStream when audit has finished 2002-07-04 04:21:11 +00:00
Oliver Burn f60f8b7e20 Made the output like it was before 2002-07-04 01:30:55 +00:00
Oliver Burn f5d8599819 Corrected problem where property JAVADOC_CHECK_UNUSED_THROWS_PROP not being
set.
2002-07-03 23:45:37 +00:00
Oliver Burn 3382af9cc9 Fixed a compile error. 2002-07-03 01:38:28 +00:00
Oliver Burn 041413baf7 Fixed what I believe was a bug in closing the streams - the logic was around
the wrong way. Also made some member variables private.

LARS - PLEASE CHECK I GOT THIS RIGHT!
2002-07-03 01:35:05 +00:00
Lars Kühne add2bdfb27 fixed bug 561616 (ant task should log errors, not infos)
This required a redesign of the AuditListener interface, the get/setOutputStream methoeds have been removed, as there might be listeners that have no or more than one OutputStream.

The DefaultLogger now differentiates between info messages ("started checking file ...", etc.) and error messages (style errors found by checkstyle) by writing the messages to two different OutputStreams.
2002-07-02 20:08:37 +00:00
Oliver Burn b3133035a4 576165: better error handling for missing properties file. 2002-07-02 11:51:56 +00:00
Oliver Burn bbe51f6884 571161: Added support for basedir attribute. 2002-07-01 01:57:36 +00:00